Sign upLogin

prebid/Prebid.js

View on GitHub
Star
modules/nobidAnalyticsAdapter.js

Summary

Maintainability
D
2 days
Test Coverage

Function carbonizeAdunits has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

  carbonizeAdunits: function (adunits, skipTestGroup) {
    function processBlockedBidders (blockedBidders) {
      function sendOptimizerData() {
        let optData = storage.getDataFromLocalStorage(nobidAnalytics.ANALYTICS_OPT_NAME);
        storage.removeDataFromLocalStorage(nobidAnalytics.ANALYTICS_OPT_NAME);
Severity: Minor
Found in modules/nobidAnalyticsAdapter.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function carbonizeAdunits has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  carbonizeAdunits: function (adunits, skipTestGroup) {
    function processBlockedBidders (blockedBidders) {
      function sendOptimizerData() {
        let optData = storage.getDataFromLocalStorage(nobidAnalytics.ANALYTICS_OPT_NAME);
        storage.removeDataFromLocalStorage(nobidAnalytics.ANALYTICS_OPT_NAME);
Severity: Minor
Found in modules/nobidAnalyticsAdapter.js - About 2 hrs to fix

    Function sendEvent has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function sendEvent (event, eventType) {
  function resolveEndpoint() {
    var ret = 'https://carbon-nv.servenobids.com/admin/status';
    var env = (typeof getParameterByName === 'function') && (getParameterByName('nobid-env'));
    env = window.location.href.indexOf('nobid-env=dev') > 0 ? 'dev' : env;
    Severity: Minor
    Found in modules/nobidAnalyticsAdapter.js - About 1 hr to fix

      Function sendEvent has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      function sendEvent (event, eventType) {
  function resolveEndpoint() {
    var ret = 'https://carbon-nv.servenobids.com/admin/status';
    var env = (typeof getParameterByName === 'function') && (getParameterByName('nobid-env'));
    env = window.location.href.indexOf('nobid-env=dev') > 0 ? 'dev' : env;
      Severity: Minor
      Found in modules/nobidAnalyticsAdapter.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function processBlockedBidders has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function processBlockedBidders (blockedBidders) {
      function sendOptimizerData() {
        let optData = storage.getDataFromLocalStorage(nobidAnalytics.ANALYTICS_OPT_NAME);
        storage.removeDataFromLocalStorage(nobidAnalytics.ANALYTICS_OPT_NAME);
        if (isJson(optData)) {
      Severity: Minor
      Found in modules/nobidAnalyticsAdapter.js - About 1 hr to fix

        Function isAnalyticsDisabled has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          isAnalyticsDisabled (eventType) {
    let stored = storage.getDataFromLocalStorage(this.ANALYTICS_DATA_NAME);
    if (!isJson(stored)) return false;
    stored = JSON.parse(stored);
    if (this.isExpired(stored)) return false;
        Severity: Minor
        Found in modules/nobidAnalyticsAdapter.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function sendAuctionEndEvent has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        function sendAuctionEndEvent (event, eventType) {
  if (event?.bidderRequests?.length > 0 && event?.bidderRequests[0]?.refererInfo?.topmostLocation) {
    nobidAnalytics.topLocation = event.bidderRequests[0].refererInfo.topmostLocation;
  }
  const data = deepClone(event);
        Severity: Minor
        Found in modules/nobidAnalyticsAdapter.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

            return false;
        Severity: Major
        Found in modules/nobidAnalyticsAdapter.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                else if (stored[`disabled_${eventType}`] === 0) return false;
          Severity: Major
          Found in modules/nobidAnalyticsAdapter.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  if (stored[`disabled_${eventType}`] === 1) return true;
            Severity: Major
            Found in modules/nobidAnalyticsAdapter.js - About 30 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                if (event?.bidderRequests?.length > 0 && event?.bidderRequests[0]?.refererInfo?.topmostLocation) {
    nobidAnalytics.topLocation = event.bidderRequests[0].refererInfo.topmostLocation;
  }
              Severity: Major
              Found in modules/nobidAnalyticsAdapter.js and 1 other location - About 1 hr to fix
              modules/nobidAnalyticsAdapter.js on lines 112..114

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 66.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                if (event?.bidderRequests?.length > 0 && event?.bidderRequests[0]?.refererInfo?.topmostLocation) {
    nobidAnalytics.topLocation = event.bidderRequests[0].refererInfo.topmostLocation;
  }
              Severity: Major
              Found in modules/nobidAnalyticsAdapter.js and 1 other location - About 1 hr to fix
              modules/nobidAnalyticsAdapter.js on lines 90..92

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 66.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    Object.keys(item).forEach(attr => { if (!attributes.includes(attr)) delete item[attr] });
              Severity: Minor
              Found in modules/nobidAnalyticsAdapter.js and 1 other location - About 40 mins to fix
              modules/nobidAnalyticsAdapter.js on lines 81..81

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 48.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                } else Object.keys(obj).forEach(attr => { if (!attributes.includes(attr)) delete obj[attr] });
              Severity: Minor
              Found in modules/nobidAnalyticsAdapter.js and 1 other location - About 40 mins to fix
              modules/nobidAnalyticsAdapter.js on lines 79..79

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 48.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status