Sign upLogin

prebid/Prebid.js

View on GitHub
Star
modules/prebidServerBidAdapter/index.js

Summary

Maintainability
F
3 days
Test Coverage

File index.js has 406 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import Adapter from '../../src/adapter.js';
import {
  deepAccess,
  deepClone,
  flatten,
Severity: Minor
Found in modules/prebidServerBidAdapter/index.js - About 5 hrs to fix

    Function PrebidServer has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
    Open

    export function PrebidServer() {
  const baseAdapter = new Adapter('prebidServer');

  /* Prebid executes this function when the page asks to send out bid requests */
  baseAdapter.callBids = function(s2sBidRequest, bidRequests, addBidResponse, done, ajax) {
    Severity: Minor
    Found in modules/prebidServerBidAdapter/index.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function PrebidServer has 66 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function PrebidServer() {
  const baseAdapter = new Adapter('prebidServer');

  /* Prebid executes this function when the page asks to send out bid requests */
  baseAdapter.callBids = function(s2sBidRequest, bidRequests, addBidResponse, done, ajax) {
    Severity: Major
    Found in modules/prebidServerBidAdapter/index.js - About 2 hrs to fix

      Function queueSync has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

      function queueSync(bidderCodes, gdprConsent, uspConsent, gppConsent, s2sConfig) {
  if (_s2sConfigs.length === _syncCount) {
    return;
  }
  _syncCount++;
      Severity: Minor
      Found in modules/prebidServerBidAdapter/index.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function processPBSRequest has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

      export const processPBSRequest = hook('sync', function (s2sBidRequest, bidRequests, ajax, {onResponse, onError, onBid, onFledge}) {
  let { gdprConsent } = getConsentData(bidRequests);
  const adUnits = deepClone(s2sBidRequest.ad_units);

  // in case config.bidders contains invalid bidders, we only process those we sent requests for
      Severity: Minor
      Found in modules/prebidServerBidAdapter/index.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function callBids has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        baseAdapter.callBids = function(s2sBidRequest, bidRequests, addBidResponse, done, ajax) {
    const adapterMetrics = s2sBidRequest.metrics = useMetrics(deepAccess(bidRequests, '0.metrics'))
      .newMetrics()
      .renameWith((n) => [`adapter.s2s.${n}`, `adapters.s2s.${s2sBidRequest.s2sConfig.defaultVendor}.${n}`])
    done = adapterMetrics.startTiming('total').stopBefore(done);
      Severity: Major
      Found in modules/prebidServerBidAdapter/index.js - About 2 hrs to fix

        Function queueSync has 54 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function queueSync(bidderCodes, gdprConsent, uspConsent, gppConsent, s2sConfig) {
  if (_s2sConfigs.length === _syncCount) {
    return;
  }
  _syncCount++;
        Severity: Major
        Found in modules/prebidServerBidAdapter/index.js - About 2 hrs to fix

          Function setS2sConfig has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

          function setS2sConfig(options) {
  if (!options) {
    return;
  }
  const normalizedOptions = Array.isArray(options) ? options : [options];
          Severity: Minor
          Found in modules/prebidServerBidAdapter/index.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function setS2sConfig has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function setS2sConfig(options) {
  if (!options) {
    return;
  }
  const normalizedOptions = Array.isArray(options) ? options : [options];
          Severity: Minor
          Found in modules/prebidServerBidAdapter/index.js - About 1 hr to fix

            Function doBidderSync has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            function doBidderSync(type, url, bidder, done, timeout) {
            Severity: Minor
            Found in modules/prebidServerBidAdapter/index.js - About 35 mins to fix

              Function doPreBidderSync has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              function doPreBidderSync(type, url, bidder, done, s2sConfig) {
              Severity: Minor
              Found in modules/prebidServerBidAdapter/index.js - About 35 mins to fix

                Function queueSync has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                function queueSync(bidderCodes, gdprConsent, uspConsent, gppConsent, s2sConfig) {
                Severity: Minor
                Found in modules/prebidServerBidAdapter/index.js - About 35 mins to fix

                  Function callBids has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                    baseAdapter.callBids = function(s2sBidRequest, bidRequests, addBidResponse, done, ajax) {
                  Severity: Minor
                  Found in modules/prebidServerBidAdapter/index.js - About 35 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    function removeWurl(auctionId, adId) {
  if ([auctionId, adId].every(isStr)) {
    wurlMap[`${auctionId}${adId}`] = undefined;
  }
}
                    Severity: Minor
                    Found in modules/prebidServerBidAdapter/index.js and 1 other location - About 35 mins to fix
                    modules/prebidServerBidAdapter/index.js on lines 380..384

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 46.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    function addWurl(auctionId, adId, wurl) {
  if ([auctionId, adId].every(isStr)) {
    wurlMap[`${auctionId}${adId}`] = wurl;
  }
}
                    Severity: Minor
                    Found in modules/prebidServerBidAdapter/index.js and 1 other location - About 35 mins to fix
                    modules/prebidServerBidAdapter/index.js on lines 390..394

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 46.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status