Sign upLogin

prebid/Prebid.js

View on GitHub
Star
modules/readpeakBidAdapter.js

Summary

Maintainability
D
1 day
Test Coverage

File readpeakBidAdapter.js has 332 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { logError, replaceAuctionPrice, triggerPixel, isStr } from '../src/utils.js';
import { registerBidder } from '../src/adapters/bidderFactory.js';
import { config } from '../src/config.js';
import { NATIVE, BANNER } from '../src/mediaTypes.js';
import { convertOrtbRequestToProprietaryNative } from '../src/native.js';
Severity: Minor
Found in modules/readpeakBidAdapter.js - About 4 hrs to fix

    Function bidResponseAvailable has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function bidResponseAvailable(bidRequest, bidResponse) {
  const idToImpMap = {};
  const idToBidMap = {};
  if (!bidResponse['body']) {
    return [];
    Severity: Minor
    Found in modules/readpeakBidAdapter.js - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

          if (nativeAd && nativeAd.assets) {
      nativeAd.assets.forEach(asset => {
        keys.title = asset.title ? asset.title.text : keys.title;
        keys.body = asset.data && asset.id === 4 ? asset.data.value : keys.body;
        keys.sponsoredBy =
      Severity: Critical
      Found in modules/readpeakBidAdapter.js - About 1 hr to fix

        Function nativeImpression has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function nativeImpression(slot) {
  if (slot.nativeParams) {
    const assets = [];
    addAsset(
      assets,
        Severity: Minor
        Found in modules/readpeakBidAdapter.js - About 1 hr to fix

          Function buildRequests has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            buildRequests: (bidRequests, bidderRequest) => {
    // convert Native ORTB definition to old-style prebid native definition
    bidRequests = convertOrtbRequestToProprietaryNative(bidRequests);

    const currencyObj = config.getConfig('currency');
          Severity: Minor
          Found in modules/readpeakBidAdapter.js - About 1 hr to fix

            Function nativeResponse has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function nativeResponse(imp, bid) {
  if (imp && imp['native']) {
    const nativeAd = parse(bid.adm);
    const keys = {};
    if (nativeAd && nativeAd.assets) {
            Severity: Minor
            Found in modules/readpeakBidAdapter.js - About 1 hr to fix

              Function impression has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

              function impression(slot) {
  let bidFloorFromModule
  if (typeof slot.getFloor === 'function') {
    const floorInfo = slot.getFloor({
      currency: 'USD',
              Severity: Minor
              Found in modules/readpeakBidAdapter.js - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function nativeResponse has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

              function nativeResponse(imp, bid) {
  if (imp && imp['native']) {
    const nativeAd = parse(bid.adm);
    const keys = {};
    if (nativeAd && nativeAd.assets) {
              Severity: Minor
              Found in modules/readpeakBidAdapter.js - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function imageAsset has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              function imageAsset(id, params, type, defaultMinWidth, defaultMinHeight) {
              Severity: Minor
              Found in modules/readpeakBidAdapter.js - About 35 mins to fix

                Function site has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                function site(bidRequests, bidderRequest) {
  const pubId =
    bidRequests && bidRequests.length > 0
      ? bidRequests[0].params.publisherId
      : '0';
                Severity: Minor
                Found in modules/readpeakBidAdapter.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        keys.cta = asset.data && asset.id === 5 ? asset.data.value : keys.cta;
                Severity: Minor
                Found in modules/readpeakBidAdapter.js and 2 other locations - About 30 mins to fix
                modules/readpeakBidAdapter.js on lines 338..338
                modules/readpeakBidAdapter.js on lines 339..340

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        keys.body = asset.data && asset.id === 4 ? asset.data.value : keys.body;
                Severity: Minor
                Found in modules/readpeakBidAdapter.js and 2 other locations - About 30 mins to fix
                modules/readpeakBidAdapter.js on lines 339..340
                modules/readpeakBidAdapter.js on lines 349..349

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        keys.sponsoredBy =
          asset.data && asset.id === 3 ? asset.data.value : keys.sponsoredBy;
                Severity: Minor
                Found in modules/readpeakBidAdapter.js and 2 other locations - About 30 mins to fix
                modules/readpeakBidAdapter.js on lines 338..338
                modules/readpeakBidAdapter.js on lines 349..349

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status