Sign upLogin

prebid/Prebid.js

View on GitHub
Star
modules/symitriDapRtdProvider.js

Summary

Maintainability
F
1 wk
Test Coverage

Function createRtdProvider has a Cognitive Complexity of 164 (exceeds 5 allowed). Consider refactoring.
Open

export function createRtdProvider(moduleName, moduleCode, headerPrefix) {
  const MODULE_NAME = 'realTimeData';
  const SUBMODULE_NAME = moduleName;
  const MODULE_CODE = moduleCode;
Severity: Minor
Found in modules/symitriDapRtdProvider.js - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createRtdProvider has 563 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function createRtdProvider(moduleName, moduleCode, headerPrefix) {
  const MODULE_NAME = 'realTimeData';
  const SUBMODULE_NAME = moduleName;
  const MODULE_CODE = moduleCode;
Severity: Major
Found in modules/symitriDapRtdProvider.js - About 2 days to fix

    File symitriDapRtdProvider.js has 586 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * This module adds the Symitri DAP RTD provider to the real time data module
 * The {@link module:modules/realTimeData} module is required
 * The module will fetch real-time data from DAP
 * @module modules/symitriDapRtdProvider
    Severity: Major
    Found in modules/symitriDapRtdProvider.js - About 1 day to fix

      Function dapTokenize has 71 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          dapTokenize: function(config, identity, onDone, onSuccess = null, onError = null) {
      let hasTokenizeError;
      [ config, hasTokenizeError ] = this.dapValidationHelper(config, onDone, null, onError);
      if (hasTokenizeError) { return; }
      Severity: Major
      Found in modules/symitriDapRtdProvider.js - About 2 hrs to fix

        Function dapRefreshToken has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            dapRefreshToken: function(ortb2, config, refreshMembership, onDone) {
      dapUtils.dapLog('Token missing or expired, fetching a new one...');
      // Trigger a refresh
      let now = Math.round(Date.now() / 1000.0); // in seconds
      let item = {}
        Severity: Minor
        Found in modules/symitriDapRtdProvider.js - About 1 hr to fix

          Function dapGetRtdObj has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              dapGetRtdObj: function(membership, segtax) {
      let segment = {
        name: 'dap.symitri.com',
        ext: {
          'segtax': segtax
          Severity: Minor
          Found in modules/symitriDapRtdProvider.js - About 1 hr to fix

            Function dapRefreshMembership has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                dapRefreshMembership: function(ortb2, config, token, onDone) {
      let now = Math.round(Date.now() / 1000.0); // in seconds
      let item = {}
      let configAsync = {...config};
      dapUtils.dapMembership(configAsync, token, onDone,
            Severity: Minor
            Found in modules/symitriDapRtdProvider.js - About 1 hr to fix

              Function dapRefreshEncryptedMembership has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  dapRefreshEncryptedMembership: function(ortb2, config, token, onDone) {
      let now = Math.round(Date.now() / 1000.0); // in seconds
      let item = {};
      let configAsync = {...config};
      dapUtils.dapEncryptedMembership(configAsync, token, onDone,
              Severity: Minor
              Found in modules/symitriDapRtdProvider.js - About 1 hr to fix

                Function getRealTimeData has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  function getRealTimeData(bidConfig, onDone, rtdConfig, userConsent) {
    let entropyDict = JSON.parse(storage.getDataFromLocalStorage(DAP_CLIENT_ENTROPY));
    let loadScriptPromise = new Promise((resolve, reject) => {
      if (rtdConfig && rtdConfig.params && rtdConfig.params.dapEntropyTimeout && Number.isInteger(rtdConfig.params.dapEntropyTimeout)) {
        setTimeout(reject, rtdConfig.params.dapEntropyTimeout, Error('DapEntropy script could not be loaded'));
                Severity: Minor
                Found in modules/symitriDapRtdProvider.js - About 1 hr to fix

                  Function generateRealTimeData has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    function generateRealTimeData(bidConfig, onDone, rtdConfig, userConsent) {
    logInfo('DEBUG(generateRealTimeData) - ENTER');
    logMessage('  - apiHostname: ' + rtdConfig.params.apiHostname);
    logMessage('  - apiVersion:  ' + rtdConfig.params.apiVersion);
    dapRetryTokenize = 0;
                  Severity: Minor
                  Found in modules/symitriDapRtdProvider.js - About 1 hr to fix

                    Function dapTokenize has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        dapTokenize: function(config, identity, onDone, onSuccess = null, onError = null) {
                    Severity: Minor
                    Found in modules/symitriDapRtdProvider.js - About 35 mins to fix

                      Function dapEncryptedMembership has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          dapEncryptedMembership: function(config, token, onDone, onSuccess = null, onError = null) {
                      Severity: Minor
                      Found in modules/symitriDapRtdProvider.js - About 35 mins to fix

                        Function dapMembership has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            dapMembership: function(config, token, onDone, onSuccess = null, onError = null) {
                        Severity: Minor
                        Found in modules/symitriDapRtdProvider.js - About 35 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                    return;
                          Severity: Major
                          Found in modules/symitriDapRtdProvider.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                    return;
                            Severity: Major
                            Found in modules/symitriDapRtdProvider.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                    return [ config, false ];
                              Severity: Major
                              Found in modules/symitriDapRtdProvider.js - About 30 mins to fix

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                export const {
  addRealTimeData,
  getRealTimeData,
  generateRealTimeData,
  rtdSubmodule: symitriDapRtdSubmodule,
                                Severity: Major
                                Found in modules/symitriDapRtdProvider.js and 1 other location - About 2 hrs to fix
                                modules/akamaiDapRtdProvider.js on lines 13..27

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 80.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                        function(xhr, status, error, onDone) {
          logError('ERROR(' + error + '): failed to retrieve encrypted membership! ' + status);
          if (status == 403 && dapRetryTokenize < DAP_MAX_RETRY_TOKENIZE) {
            dapRetryTokenize++;
            dapUtils.dapRefreshToken(ortb2, config, true, onDone);
                                Severity: Major
                                Found in modules/symitriDapRtdProvider.js and 1 other location - About 2 hrs to fix
                                modules/symitriDapRtdProvider.js on lines 277..285

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 77.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                        function(xhr, status, error, onDone) {
          logError('ERROR(' + error + '): failed to retrieve membership! ' + status);
          if (status == 403 && dapRetryTokenize < DAP_MAX_RETRY_TOKENIZE) {
            dapRetryTokenize++;
            dapUtils.dapRefreshToken(ortb2, config, true, onDone);
                                Severity: Major
                                Found in modules/symitriDapRtdProvider.js and 1 other location - About 2 hrs to fix
                                modules/symitriDapRtdProvider.js on lines 323..331

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 77.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                  function mergeLazy(target, source) {
    if (!isPlainObject(target)) {
      target = {};
    }
    if (!isPlainObject(source)) {
                                Severity: Major
                                Found in modules/symitriDapRtdProvider.js and 1 other location - About 1 hr to fix
                                modules/hadronRtdProvider.js on lines 98..108

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 64.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                      if (rtdConfig.params.segtax == 504) {
        let encMembership = dapUtils.dapGetEncryptedMembershipFromLocalStorage();
        if (encMembership) {
          jsonData = dapUtils.dapGetEncryptedRtdObj(encMembership, rtdConfig.params.segtax)
        }
                                Severity: Minor
                                Found in modules/symitriDapRtdProvider.js and 1 other location - About 40 mins to fix
                                modules/symitriDapRtdProvider.js on lines 113..118

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 48.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                      } else {
        let membership = dapUtils.dapGetMembershipFromLocalStorage();
        if (membership) {
          jsonData = dapUtils.dapGetRtdObj(membership, rtdConfig.params.segtax)
        }
                                Severity: Minor
                                Found in modules/symitriDapRtdProvider.js and 1 other location - About 40 mins to fix
                                modules/symitriDapRtdProvider.js on lines 108..113

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 48.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                There are no issues that match your filters.

                                Category
                                Status