Sign upLogin

prebid/Prebid.js

View on GitHub
Star
modules/viouslyBidAdapter.js

Summary

Maintainability
D
1 day
Test Coverage

Function buildRequests has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  buildRequests: function(validBidRequests, bidderRequest) {
    let payload = {};

    /** Viously Publisher ID */
    if (validBidRequests[0].params.pid) {
Severity: Major
Found in modules/viouslyBidAdapter.js - About 2 hrs to fix

    Function buildRequests has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

      buildRequests: function(validBidRequests, bidderRequest) {
    let payload = {};

    /** Viously Publisher ID */
    if (validBidRequests[0].params.pid) {
    Severity: Minor
    Found in modules/viouslyBidAdapter.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function isBidRequestValid has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      isBidRequestValid: function(bid) {
    let videoParams = deepAccess(bid, 'mediaTypes.video');
    let bannerParams = deepAccess(bid, 'mediaTypes.banner');

    if (!bid.params) {
    Severity: Minor
    Found in modules/viouslyBidAdapter.js - About 1 hr to fix

      Function interpretResponse has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        interpretResponse: function(serverResponse, requests) {
    const bidResponses = [];
    const responseBody = serverResponse.body;

    if (responseBody.ads && responseBody.ads.length > 0) {
      Severity: Minor
      Found in modules/viouslyBidAdapter.js - About 1 hr to fix

        Function isBidRequestValid has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

          isBidRequestValid: function(bid) {
    let videoParams = deepAccess(bid, 'mediaTypes.video');
    let bannerParams = deepAccess(bid, 'mediaTypes.banner');

    if (!bid.params) {
        Severity: Minor
        Found in modules/viouslyBidAdapter.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                      if (bidResponse.ad_url) {
                bid.vastUrl = bidResponse.ad_url;
              } else {
                bid.vastXml = bidResponse.ad;
              }
        Severity: Major
        Found in modules/viouslyBidAdapter.js - About 45 mins to fix

          Avoid too many return statements within this function.
          Open

              return true;
          Severity: Major
          Found in modules/viouslyBidAdapter.js - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        if (bidResponse.type == VIDEO) {
              if (bidResponse.ad_url) {
                bid.vastUrl = bidResponse.ad_url;
              } else {
                bid.vastXml = bidResponse.ad;
            Severity: Major
            Found in modules/viouslyBidAdapter.js and 1 other location - About 2 hrs to fix
            modules/kargoBidAdapter.js on lines 229..237

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 79.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  if (bidderRequest.gdprConsent.addtlConsent && bidderRequest.gdprConsent.addtlConsent.indexOf('~') !== -1) {
        payload.addtl_consent = bidderRequest.gdprConsent.addtlConsent;
      }
            Severity: Major
            Found in modules/viouslyBidAdapter.js and 1 other location - About 1 hr to fix
            modules/ampliffyBidAdapter.js on lines 38..40

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 60.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                if (bannerParams) {
      let sizes = bannerParams.sizes;

      if (!sizes || parseSizesInput(sizes).length == 0) {
        logError('mediaTypes.banner.sizes must be set for banner placement at the right format.');
            Severity: Major
            Found in modules/viouslyBidAdapter.js and 1 other location - About 1 hr to fix
            modules/sparteoBidAdapter.js on lines 92..99

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 57.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                return {
      method: HTTP_METHOD,
      url: validBidRequests[0].params.endpoint ? validBidRequests[0].params.endpoint : REQUEST_URL,
      data: payload
    };
            Severity: Minor
            Found in modules/viouslyBidAdapter.js and 1 other location - About 40 mins to fix
            modules/sparteoBidAdapter.js on lines 118..122

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status