Sign upLogin

prebid/Prebid.js

View on GitHub
Star
src/config.js

Summary

Maintainability
F
5 days
Test Coverage

Function newConfig has a Cognitive Complexity of 99 (exceeds 5 allowed). Consider refactoring.
Open

export function newConfig() {
  let listeners = [];
  let defaults;
  let config;
  let bidderConfig;
Severity: Minor
Found in src/config.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function newConfig has 357 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function newConfig() {
  let listeners = [];
  let defaults;
  let config;
  let bidderConfig;
Severity: Major
Found in src/config.js - About 1 day to fix

    Function resetConfig has 149 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function resetConfig() {
    defaults = {};

    function getProp(name) {
      return props[name].val;
    Severity: Major
    Found in src/config.js - About 5 hrs to fix

      File config.js has 399 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*
 * Module for getting and setting Prebid configuration.
*/

/**
      Severity: Minor
      Found in src/config.js - About 5 hrs to fix

        Function setBidderConfig has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          function setBidderConfig(config, mergeFlag = false) {
    try {
      check(config);
      config.bidders.forEach(bidder => {
        if (!bidderConfig[bidder]) {
        Severity: Minor
        Found in src/config.js - About 1 hr to fix

          Avoid too many return statements within this function.
          Open

                return true;
          Severity: Major
          Found in src/config.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return false;
            Severity: Major
            Found in src/config.js - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                return {
    getCurrentBidder,
    resetBidder,
    getConfig,
    getAnyConfig,
              Severity: Major
              Found in src/config.js and 1 other location - About 2 hrs to fix
              src/auction.js on lines 172..188

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 79.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status