Sign upLogin

prescottprue/gitsearch

View on GitHub
Star

Showing 4 of 10 total issues

Function render has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render () {
    const openRowDetail = (r) => {
      console.log('open row detail called:', r)
    }
Severity: Major
Found in src/components/UsersTable/UsersTable.js - About 2 hrs to fix

    Function render has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      render () {
    const { users, isFetching, removeUser, error } = this.props
    const errorMessage = error ? `${error.status === 404 ? 'User' : ''} ${error.statusText}` : null
    return (
      <div className={styles.container}>
    Severity: Minor
    Found in src/containers/Home/Home.js - About 1 hr to fix

      Function render has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        render () {
    const { users, isFetching, removeUser, error } = this.props
    const errorMessage = error ? `${error.status === 404 ? 'User' : ''} ${error.statusText}` : null
    return (
      <div className={styles.container}>
      Severity: Minor
      Found in src/containers/Home/Home.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

            return Object.assign({}, state, {
        isFetching: false,
        items: state.items.filter(user => user !== action.payload)
      })
      Severity: Major
      Found in src/reducers/selectedUsers.js - About 30 mins to fix
        Severity
        Category
        Status
        Source
        Language