presidential-innovation-fellows/hack-the-paygap

View on GitHub

Showing 3 of 7 total issues

File components.js has 276 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

/* globals $: false */


Severity: Minor
Found in scss/web-design-standards/js/components.js - About 2 hrs to fix

    Function validator has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    function validator($el) {
      var data = $('#password[data-validation-element]').data(),
          key,
          validatorName,
          validatorPattern,
    Severity: Minor
    Found in scss/web-design-standards/js/components.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _divideIntoArray has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        Politespace.prototype._divideIntoArray = function( value ) {
            var split = ( '' + this.groupLength ).split( ',' ),
                isUniformSplit = split.length === 1,
                dividedValue = [],
                loopIndex = 0,
    Severity: Minor
    Found in scss/web-design-standards/js/components.js - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language