Sign upLogin

prey/prey-node-client

View on GitHub
Star
lib/agent/commands.js

Summary

Maintainability
D
2 days
Test Coverage

Function perform has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

exports.perform = function (command, persist = 1) {
  if (!command) return handle_error(new Error('No command received'));

  if (typeof command.options == 'string') {
    try {
Severity: Minor
Found in lib/agent/commands.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function perform has 93 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.perform = function (command, persist = 1) {
  if (!command) return handle_error(new Error('No command received'));

  if (typeof command.options == 'string') {
    try {
Severity: Major
Found in lib/agent/commands.js - About 3 hrs to fix

    File commands.js has 309 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    var common = require('./common');
var hooks = require('./hooks');
var actions = require('./actions');
var triggers = require('./triggers');
var providers = require('./providers');
    Severity: Minor
    Found in lib/agent/commands.js - About 3 hrs to fix

      Function parse has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

      exports.parse = function (body) {
  var c;
  var matches;

  if ((matches = body.match(/^help\s?(\w+)?/))) c = ['help', matches[1]];
      Severity: Minor
      Found in lib/agent/commands.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function watch_stopped has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var watch_stopped = function () {
  if (!watching) return;

  hooks.on('action', function (event, id) {
    if (event == 'stopped' || event == 'failed') {
      Severity: Minor
      Found in lib/agent/commands.js - About 1 hr to fix

        Function parse has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        exports.parse = function (body) {
  var c;
  var matches;

  if ((matches = body.match(/^help\s?(\w+)?/))) c = ['help', matches[1]];
        Severity: Minor
        Found in lib/agent/commands.js - About 1 hr to fix

          Function store has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          var store = function (type, id, name, opts, cb) {
          Severity: Minor
          Found in lib/agent/commands.js - About 35 mins to fix

            Function watch_stopped has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            var watch_stopped = function () {
  if (!watching) return;

  hooks.on('action', function (event, id) {
    if (event == 'stopped' || event == 'failed') {
            Severity: Minor
            Found in lib/agent/commands.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (event == 'stopped' || event == 'failed') {
      storage.do(
        'update',
        {
          type: 'commands',
            Severity: Major
            Found in lib/agent/commands.js and 1 other location - About 1 hr to fix
            lib/agent/commands.js on lines 336..352

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 73.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (event == 'started') {
      storage.do(
        'update',
        {
          type: 'commands',
            Severity: Major
            Found in lib/agent/commands.js and 1 other location - About 1 hr to fix
            lib/agent/commands.js on lines 318..334

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 73.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              if ((matches = body.match(/^start ([\w\-]+)(?: (using|with) )?(.*)/)))
    c = [
      'command',
      this.build('start', matches[1], parse_arguments(matches[3])),
    ];
            Severity: Minor
            Found in lib/agent/commands.js and 1 other location - About 40 mins to fix
            lib/agent/commands.js on lines 80..84

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              if ((matches = body.match(/^watch ([\w\-]+)(?: (using|with) )?(.*)/)))
    c = [
      'command',
      this.build('watch', matches[1], parse_arguments(matches[3])),
    ];
            Severity: Minor
            Found in lib/agent/commands.js and 1 other location - About 40 mins to fix
            lib/agent/commands.js on lines 74..78

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status