Sign upLogin

prey/prey-node-client

View on GitHub
Star
lib/agent/providers/hardware/windows.js

Summary

Maintainability
C
1 day
Test Coverage

Function get_firmware_info has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

exports.get_firmware_info = (callback) => {
  let data = {};
  const fetch = (key, section, value) => {
    wmic.get_value(section, value, null, (err, resp) => {
      let res = resp;
Severity: Minor
Found in lib/agent/providers/hardware/windows.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_firmware_info has 93 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.get_firmware_info = (callback) => {
  let data = {};
  const fetch = (key, section, value) => {
    wmic.get_value(section, value, null, (err, resp) => {
      let res = resp;
Severity: Major
Found in lib/agent/providers/hardware/windows.js - About 3 hrs to fix

    Function fetch has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const fetch = (key, section, value) => {
    wmic.get_value(section, value, null, (err, resp) => {
      let res = resp;
      if (key === 'device_type') {
        res = err ? 'Desktop' : 'Laptop';
    Severity: Minor
    Found in lib/agent/providers/hardware/windows.js - About 1 hr to fix

      Function get_ram_module_list has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      exports.get_ram_module_list = (cb) => {
  const list = [];
  const file = join(__dirname, 'ramcheck.vbs');

  // eslint-disable-next-line consistent-return
      Severity: Minor
      Found in lib/agent/providers/hardware/windows.js - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                            if (!stdoutsiBattery || !stdoutsiBattery.hasBattery) {
                      data.device_type = 'Desktop';
                      callback(null, data);
                    } else {
                      data.device_type = 'Laptop';
        Severity: Major
        Found in lib/agent/providers/hardware/windows.js - About 45 mins to fix

          There are no issues that match your filters.

          Category
          Status