Sign upLogin

prey/prey-node-client

View on GitHub
Star
lib/conf/tasks/prey_owl.js

Summary

Maintainability
C
1 day
Test Coverage

Function testExistingConfigurations has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

const testExistingConfigurations = (cb) => {
  exec(exports.existsNewPath, (_error, stdout) => {
    if (stdout && stdout.trim() !== '') {
      // look for old .plist and remove it
      // eslint-disable-next-line consistent-return
Severity: Minor
Found in lib/conf/tasks/prey_owl.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getPreyUserVersions has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

const getPreyUserVersions = (preyUserVersion, cb) => {
  const successHandler = (foundVersion) => {
    if (foundVersion) {
      compareVersionsDaemon(foundVersion, preyUserVersion, cb);
    } else {
Severity: Minor
Found in lib/conf/tasks/prey_owl.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getPreyUserVersions has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const getPreyUserVersions = (preyUserVersion, cb) => {
  const successHandler = (foundVersion) => {
    if (foundVersion) {
      compareVersionsDaemon(foundVersion, preyUserVersion, cb);
    } else {
Severity: Minor
Found in lib/conf/tasks/prey_owl.js - About 1 hr to fix

    Function versionPromise has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const versionPromise = new Promise((resolve, reject) => {
    exec(exports.cmdExistInstallPreyUser, (_parentError, parentStdout) => {
      if (parentStdout && parentStdout.trim() !== '') {
        exec(exports.cmdInstallPreyUserVersion, (error, preyUserVersionInstall) => {
          if (error) {
    Severity: Minor
    Found in lib/conf/tasks/prey_owl.js - About 1 hr to fix

      Function trigger_set_watcher has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      exports.trigger_set_watcher = (cb) => {
  // eslint-disable-next-line consistent-return
  exec(exports.cmdExistsCurrentBinPreyUser, (error, stdout) => {
    if (stdout) {
      // eslint-disable-next-line consistent-return
      Severity: Minor
      Found in lib/conf/tasks/prey_owl.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status