Sign upLogin

privly/privly-applications

View on GitHub
Star
History/js/new.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function getMessageDOM has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function getMessageDOM(row) {
  var href = row.privly_URL;
  var app = row.privly_application;

  // Rename deperecated apps - TODO Will be removed soon
Severity: Major
Found in History/js/new.js - About 2 hrs to fix

    Function parseDate has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      parseDate: function(string, mode) {

    var date = new Date(string);
    var current = new Date();
    Severity: Minor
    Found in History/js/new.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function parseDate has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      parseDate: function(string, mode) {

    var date = new Date(string);
    var current = new Date();
    Severity: Minor
    Found in History/js/new.js - About 1 hr to fix

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

      document.addEventListener('DOMContentLoaded', function () {
  // Don't start the script if it is running in a Headless
  // browser
  if (!document.getElementById("logout_link")) {
    return;
      Severity: Major
      Found in History/js/new.js and 2 other locations - About 3 hrs to fix
      Help/js/help.js on lines 69..84
      Login/js/new.js on lines 175..190

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 102.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status