Sign upLogin

privly/privly-applications

View on GitHub
Star

Showing 48 of 109 total issues

Avoid deeply nested control flow statements.
Open

          if "nav" in template.keys() and template["nav"] == "new":
            creation_apps.append(template["subtemplate_dict"]["name"])

  # Hack to maintain current app order
  creation_apps.sort()
Severity: Major
Found in build.py - About 45 mins to fix

    Function getAuthenticatedUrl has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      getAuthenticatedUrl: function(url) {
    
    // get the parameter string for the auth token
    privlyNetworkService.setAuthTokenString();
    Severity: Minor
    Found in shared/javascripts/network_service.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

            return undefined;
    Severity: Major
    Found in shared/javascripts/local_storage.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return "SAFARI";
      Severity: Major
      Found in shared/javascripts/network_service.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return "FIREFOX";
        Severity: Major
        Found in shared/javascripts/network_service.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                    return ls.preferences.getCharPref(key);
          Severity: Major
          Found in shared/javascripts/local_storage.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return "HOSTED";
            Severity: Major
            Found in shared/javascripts/network_service.js - About 30 mins to fix

              Function saveServer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              function saveServer(event){

  // fired event object
  var target = event.target;
              Severity: Minor
              Found in Pages/js/options.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language