File context_messenger.js
has 477 lines of code (exceeds 250 allowed). Consider refactoring. Open
/**
* @fileOverview This script is responsible for integrating privly-applications,
* content scripts, the browser extension background script,
* and mobile architectures with message passing. Each of these scripting contexts
* include this script on each of the platforms (Chrome, Firefox, etc).
Function sendMessageTo
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
SafariAdapter.prototype.sendMessageTo = function (to, payload) {
if (to === 'BACKGROUND_SCRIPT') {
if (this.getContextName() === 'BACKGROUND_SCRIPT') {
safari.self.contentWindow.postMessage(payload, '*');
}
Function sendMessageTo
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
FirefoxAdapter.prototype.sendMessageTo = function (to, data) {
var contextName = this.getContextName();
// Messages from Privly Applications to Background Script, Content Scripts
// Privly Applications can't send messages directly to background scripts, they do so via
Function setListener
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
SafariAdapter.prototype.setListener = function (callback) {
if (this.getContextName() === 'BACKGROUND_SCRIPT') {
safari.application.addEventListener("message", function(payload) {
if (typeof payload.name !== "undefined" && payload.name === "privlyMessage") {
// The message is received from other than BACKGROUND_SCRIPT
Avoid deeply nested control flow statements. Open
for(var i=0 ; i<len ; i++) {
this.workers[i].port.emit("PRIVLY_MESSAGE", data);
}
Similar blocks of code found in 2 locations. Consider refactoring. Open
if (this.getContextName() === 'BACKGROUND_SCRIPT') {
safari.application.addEventListener("message", function(payload) {
if (typeof payload.name !== "undefined" && payload.name === "privlyMessage") {
// The message is received from other than BACKGROUND_SCRIPT
callback(payload.message);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 96.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
if (this.getContextName() === 'CONTENT_SCRIPT') {
safari.self.addEventListener("message", function(payload) {
if (typeof payload.name !== "undefined" && payload.name === "privlyMessage") {
// The message is received from other than PRIVLY_APPLICATION
callback(payload.message);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 96.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76