privly/privly-applications

View on GitHub
shared/javascripts/local_storage.js

Summary

Maintainability
A
2 hrs
Test Coverage

Function getItem has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  getItem: function(key) {
    if ( ls.localStorageDefined ) {
      var value = localStorage.getItem(key);
      if (value === null){
        return undefined;
Severity: Minor
Found in shared/javascripts/local_storage.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return undefined;
Severity: Major
Found in shared/javascripts/local_storage.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

              return ls.preferences.getCharPref(key);
    Severity: Major
    Found in shared/javascripts/local_storage.js - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status