Sign upLogin

privly/privly-applications

View on GitHub
Star
shared/javascripts/network_service.js

Summary

Maintainability
F
3 days
Test Coverage

File network_service.js has 267 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * @fileOverview Interfaces the application with its current architecture.
 * This could be an extension, mobile app, or a hosted web server.
 *
 **/
Severity: Minor
Found in shared/javascripts/network_service.js - About 2 hrs to fix

    Function isWhitelistedDomain has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      isWhitelistedDomain: function(url) {
    
    // Chrome maintains an explicit whitelist in local storage
    if( privlyNetworkService.platformName() === "CHROME" || 
      privlyNetworkService.platformName() === "FIREFOX") {
    Severity: Minor
    Found in shared/javascripts/network_service.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function initializeNavigation has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      initializeNavigation: function() {
    var domain = privlyNetworkService.contentServerDomain();
    $(".home_domain").text(domain.split("/")[2]);
    $(".account_url").attr("href", domain + "/pages/account");
    $(".legal_nav").attr("href", domain + "/pages/privacy");
    Severity: Minor
    Found in shared/javascripts/network_service.js - About 1 hr to fix

      Function platformName has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        platformName: function() {
    if (navigator.userAgent.indexOf("iPhone") >= 0 || 
      navigator.userAgent.indexOf("iPad") >= 0) {
      if( navigator.userAgent.indexOf("Safari") >= 0 ) { return "HOSTED"; }
        return "IOS";
      Severity: Minor
      Found in shared/javascripts/network_service.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getAuthenticatedUrl has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        getAuthenticatedUrl: function(url) {
    
    // get the parameter string for the auth token
    privlyNetworkService.setAuthTokenString();
      Severity: Minor
      Found in shared/javascripts/network_service.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

            return "SAFARI";
      Severity: Major
      Found in shared/javascripts/network_service.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return "FIREFOX";
        Severity: Major
        Found in shared/javascripts/network_service.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return "HOSTED";
          Severity: Major
          Found in shared/javascripts/network_service.js - About 30 mins to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

              sameOriginDeleteRequest: function(url, callback, data) {
    url = privlyNetworkService.getAuthenticatedUrl(url);
    return $.ajax({
      url: url,
      cache: false,
            Severity: Major
            Found in shared/javascripts/network_service.js and 2 other locations - About 6 hrs to fix
            shared/javascripts/network_service.js on lines 294..314
            shared/javascripts/network_service.js on lines 331..351

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 169.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

              sameOriginPutRequest: function(url, callback, data) {
    url = privlyNetworkService.getAuthenticatedUrl(url);
    return $.ajax({
      url: url,
      cache: false,
            Severity: Major
            Found in shared/javascripts/network_service.js and 2 other locations - About 6 hrs to fix
            shared/javascripts/network_service.js on lines 294..314
            shared/javascripts/network_service.js on lines 368..388

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 169.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

              sameOriginPostRequest: function(url, callback, data) {
    url = privlyNetworkService.getAuthenticatedUrl(url);
    return $.ajax({
      url: url,
      cache: false,
            Severity: Major
            Found in shared/javascripts/network_service.js and 2 other locations - About 6 hrs to fix
            shared/javascripts/network_service.js on lines 331..351
            shared/javascripts/network_service.js on lines 368..388

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 169.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status