Sign upLogin

privly/privly-applications

View on GitHub
Star
shared/javascripts/viewAdapters/show.js

Summary

Maintainability
D
2 days
Test Coverage

File show.js has 318 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * @fileOverview This is a general adapter for interfacing with the Privly-web
 * server: github.com/privly/privly-web
 *
 * Its purpose is to allow all privly-web derived applications to interface
Severity: Minor
Found in shared/javascripts/viewAdapters/show.js - About 3 hrs to fix

    Function contentReturned has 74 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      contentReturned: function(response, callback) {
    if( response.jqXHR.status === 200 ) {
      
      var json = response.json;
    Severity: Major
    Found in shared/javascripts/viewAdapters/show.js - About 2 hrs to fix

      Function pendingContent has 74 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        pendingContent: function(callback) {

    // Show prompt to download extension, if in the hosted environment
    callbacks.showDownloadMessage();
      Severity: Major
      Found in shared/javascripts/viewAdapters/show.js - About 2 hrs to fix

        Function contentReturned has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

          contentReturned: function(response, callback) {
    if( response.jqXHR.status === 200 ) {
      
      var json = response.json;
        Severity: Minor
        Found in shared/javascripts/viewAdapters/show.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function pendingContent has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

          pendingContent: function(callback) {

    // Show prompt to download extension, if in the hosted environment
    callbacks.showDownloadMessage();
        Severity: Minor
        Found in shared/javascripts/viewAdapters/show.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function click has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          click: function(evt, callback) {
    
    if( ! privlyNetworkService.permissions.canUpdate ) {
      callbacks.singleClick(evt, callback);
      return;
        Severity: Minor
        Found in shared/javascripts/viewAdapters/show.js - About 1 hr to fix

          Function click has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

            click: function(evt, callback) {
    
    if( ! privlyNetworkService.permissions.canUpdate ) {
      callbacks.singleClick(evt, callback);
      return;
          Severity: Minor
          Found in shared/javascripts/viewAdapters/show.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function showDownloadMessage has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            showDownloadMessage: function(callback) {

    // Show the download extension link in the hosted context
    if( privlyNetworkService.platformName() === "HOSTED" && !privlyHostPage.isInjected() ){
          Severity: Minor
          Found in shared/javascripts/viewAdapters/show.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (window.getSelection && document.createRange) {
          selection = window.getSelection();
          range = document.createRange();
          range.selectNodeContents($(this)[0]);
          selection.removeAllRanges();
          Severity: Major
          Found in shared/javascripts/viewAdapters/show.js and 1 other location - About 6 hrs to fix
          shared/javascripts/viewAdapters/new.js on lines 372..382

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 158.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status