Sign upLogin

privly/privly-web

View on GitHub
Star

Showing 60 of 98 total issues

Function getUrlVariables has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  getUrlVariables: function(url) {
    
    "use strict";
    
    var vars = {};
Severity: Minor
Found in public/cdn/privly-0.1.2.js - About 1 hr to fix

    Function replaceLinks has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      replaceLinks: function(){
    var anchors = document.links;
    var i = anchors.length;
    while (i--){
      var a = anchors[i];
    Severity: Minor
    Found in public/cdn/privly-0.1.1.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method create has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def create
    @user = User.find_by_email(params[:email])
    
    if @user and not @user.valid_password?(params[:password])
      @user.failed_attempts += 1
    Severity: Minor
    Found in app/controllers/token_authentications_controller.rb - About 1 hr to fix

      Function correctIndirection has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        correctIndirection: function()
  {
    "use strict";
    var anchors = document.links;
    var i = anchors.length;
      Severity: Minor
      Found in public/cdn/privly-0.1.2.js - About 1 hr to fix

        Function createLinks has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          createLinks: function() 
  {
      /*************************************************************************
      Inspired by Linkify script:
        http://downloads.mozdev.org/greasemonkey/linkify.user.js
        Severity: Minor
        Found in public/cdn/privly-0.1.1.js - About 1 hr to fix

          Method create has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def create
    
    if not params[:user] or not params[:user][:email]
      return
    end
          Severity: Minor
          Found in app/controllers/users/invitations_controller.rb - About 1 hr to fix

            Function getUrlVariables has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

              getUrlVariables: function(url) {
    
    "use strict";
    
    var vars = {};
            Severity: Minor
            Found in public/cdn/privly-0.1.2.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function applyPlacement has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              , applyPlacement: function(offset, placement){
      var $tip = this.tip()
        , width = $tip[0].offsetWidth
        , height = $tip[0].offsetHeight
        , actualWidth
            Severity: Minor
            Found in app/assets/javascripts/bootstrap.js - About 1 hr to fix

              Function getUrlVariables has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                getUrlVariables: function(url) {
    
    "use strict";
    
    var vars = {};
              Severity: Minor
              Found in public/cdn/privly.js - About 1 hr to fix

                Function getUrlVariables has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  getUrlVariables: function(url) {
    
    "use strict";
    
    var vars = {};
                Severity: Minor
                Found in public/cdn/privly-0.1.3.js - About 1 hr to fix

                  Function correctIndirection has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    correctIndirection: function()
  {
    "use strict";
    var anchors = document.links;
    var i = anchors.length;
                  Severity: Minor
                  Found in public/cdn/privly-0.1.3.js - About 1 hr to fix

                    Function correctIndirection has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      correctIndirection: function()
  {
    "use strict";
    var anchors = document.links;
    var i = anchors.length;
                    Severity: Minor
                    Found in public/cdn/privly.js - About 1 hr to fix

                      Method update has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def update
    
    unless current_user == @post.user
      return
    end
                      Severity: Minor
                      Found in app/controllers/posts_controller.rb - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method create has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def create
    
    if not params[:user] or not params[:user][:email]
      return
    end
                      Severity: Minor
                      Found in app/controllers/users/invitations_controller.rb - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method create has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        def create
    
    unless current_user.can_post
      redirect_to welcome_page_path
    end
                      Severity: Minor
                      Found in app/controllers/posts_controller.rb - About 1 hr to fix

                        Method use_invite has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          def use_invite
    
    # Make sure the user has invites remaining
    if current_user.alpha_invites < 1
      redirect_to pages_account_path, :notice => "You do not have any invitations at this time."
                        Severity: Minor
                        Found in app/controllers/users/invitations_controller.rb - About 1 hr to fix

                          Function resizeIframePostedMessage has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                            resizeIframePostedMessage: function(message){
    
    "use strict";
    
    //check the format of the message
                          Severity: Minor
                          Found in public/cdn/privly-0.1.2.js - About 1 hr to fix

                            Function keydown has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                              , keydown: function (e) {
      var $this
        , $items
        , $active
        , $parent
                            Severity: Minor
                            Found in app/assets/javascripts/bootstrap.js - About 1 hr to fix

                              Avoid deeply nested control flow statements.
                              Open

                                          if (privly.privlyReferencesRegex.test(attrib.value)) {
              a.setAttribute("privlyHref", attrib.value);
            }
                              Severity: Major
                              Found in public/cdn/privly.js - About 45 mins to fix

                                Method create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                                Open

                                  def create
    @user = User.find_by_email(params[:email])
    
    if @user and not @user.valid_password?(params[:password])
      @user.failed_attempts += 1
                                Severity: Minor
                                Found in app/controllers/token_authentications_controller.rb - About 45 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Severity
                                Category
                                Status
                                Source
                                Language