Sign upLogin

privly/privly-web

View on GitHub
Star
public/cdn/privly.js

Summary

Maintainability
F
1 mo
Test Coverage

File privly.js has 418 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*******************************************************************************
Open Source Initiative OSI - The MIT License (MIT):Licensing
[OSI Approved License]
The MIT License (MIT)
Severity: Minor
Found in public/cdn/privly.js - About 6 hrs to fix

    Function correctIndirection has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

      correctIndirection: function()
  {
    "use strict";
    var anchors = document.links;
    var i = anchors.length;
    Severity: Minor
    Found in public/cdn/privly.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function createLinks has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

      createLinks: function()
  {
    "use strict";
    /***********************************************************************
    Inspired by Linkify script:
    Severity: Minor
    Found in public/cdn/privly.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function createLinks has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      createLinks: function()
  {
    "use strict";
    /***********************************************************************
    Inspired by Linkify script:
    Severity: Minor
    Found in public/cdn/privly.js - About 1 hr to fix

      Function getUrlVariables has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        getUrlVariables: function(url) {
    
    "use strict";
    
    var vars = {};
      Severity: Minor
      Found in public/cdn/privly.js - About 1 hr to fix

        Function correctIndirection has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          correctIndirection: function()
  {
    "use strict";
    var anchors = document.links;
    var i = anchors.length;
        Severity: Minor
        Found in public/cdn/privly.js - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                      if (privly.privlyReferencesRegex.test(attrib.value)) {
              a.setAttribute("privlyHref", attrib.value);
            }
          Severity: Major
          Found in public/cdn/privly.js - About 45 mins to fix

            Function toggleInjection has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              toggleInjection: function() {
    var iframes = document.getElementsByTagName("iframe");
    for(var i = 0; i < iframes.length; i++) {
      var iframe = iframes[i];
      if (iframe.getAttribute("data-privly-display") === "true") {
            Severity: Minor
            Found in public/cdn/privly.js - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getUrlVariables has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              getUrlVariables: function(url) {
    
    "use strict";
    
    var vars = {};
            Severity: Minor
            Found in public/cdn/privly.js - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function isEditable has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              isEditable: function(node) {

   "use strict";

   if ( node.contentEditable === "true" ) {
            Severity: Minor
            Found in public/cdn/privly.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this function.
            Open

                 return false;
            Severity: Major
            Found in public/cdn/privly.js - About 30 mins to fix

              Function injectLink has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                injectLink: function(object)
  {
    "use strict";
    
    //Sets content URL.
              Severity: Minor
              Found in public/cdn/privly.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              var privly = {
  
  /**
   * Gives a map of the URL parameters and the anchor. 
   * This method assumes the parameters and the anchor are encoded
              Severity: Major
              Found in public/cdn/privly.js and 1 other location - About 3 wks to fix
              public/cdn/privly-0.1.3.js on lines 40..800

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 4181.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status