Sign upLogin

programandoarg/pg_rails

View on GitHub
Star

Showing 15 of 30 total issues

Function connect has a Cognitive Complexity of 34 (exceeds 7 allowed). Consider refactoring.
Confirmed

  connect () {
    // ID único para identificar el campo y el modal
    this.elemId = Math.trunc(Math.random() * 1000000000)

    this.input = this.element.querySelector('input[type=text]')
Severity: Minor
Found in pg_associable/app/javascript/asociable_controller.tsx - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function connect has 92 lines of code (exceeds 25 allowed). Consider refactoring.
Confirmed

  connect () {
    // ID único para identificar el campo y el modal
    this.elemId = Math.trunc(Math.random() * 1000000000)

    this.input = this.element.querySelector('input[type=text]')
Severity: Major
Found in pg_associable/app/javascript/asociable_controller.tsx - About 3 hrs to fix

    File simple_form_bootstrap.rb has 294 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    SimpleForm.setup do |config|
  # Default class for buttons
  config.button_class = 'btn'

  # Define the default class of the input wrapper of the boolean input.
    Severity: Minor
    Found in pg_engine/config/simple_form/simple_form_bootstrap.rb - About 3 hrs to fix

      Method encabezado has a Cognitive Complexity of 21 (exceeds 7 allowed). Consider refactoring.
      Open

          def encabezado(campo, options = {})
      campo = campo.to_s.sub(/_f\z/, '')
      campo = campo.to_s.sub(/_text\z/, '')
      clase = options[:clase] || @clase_modelo
      if options[:ordenable]
      Severity: Minor
      Found in pg_engine/app/helpers/pg_engine/index_helper.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File resource.rb has 258 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      module PgEngine
  module Resource
    def self.included(clazz)
      # clazz.before_action :authenticate_user!
      clazz.helper_method :atributos_para_listar
      Severity: Minor
      Found in pg_engine/app/controllers/concerns/pg_engine/resource.rb - About 2 hrs to fix

        Method pg_respond_destroy has a Cognitive Complexity of 15 (exceeds 7 allowed). Consider refactoring.
        Confirmed

            def pg_respond_destroy(model, redirect_url = nil)
      if destroy_model(model)
        msg = "#{model.model_name.human} #{model.gender == 'f' ? 'borrada' : 'borrado'}"
        respond_to do |format|
          if redirect_url.present?
        Severity: Minor
        Found in pg_engine/app/controllers/concerns/pg_engine/resource.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method pg_respond_create has a Cognitive Complexity of 14 (exceeds 7 allowed). Consider refactoring.
        Confirmed

            def pg_respond_create
      object = instancia_modelo
      respond_to do |format|
        if (@saved = object.save)
          if params[:asociable]
        Severity: Minor
        Found in pg_engine/app/controllers/concerns/pg_engine/resource.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function flashMessage has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function flashMessage (message, flashType = 'warning', toast = false) {
  const el = document.createElement('div')
  const toastClasses = toast ? 'position-absolute pg-toast' : ''
  let iconClasses
  let alertClassSuffix
        Severity: Minor
        Found in pg_layout/app/javascript/utils/utils.ts - About 1 hr to fix

          Function resetResultados has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Confirmed

            resetResultados () {
    this.lastValue = null
    const rows = []
    if (this.element.dataset.puedeCrear) {
      rows.push(
          Severity: Minor
          Found in pg_associable/app/javascript/asociable_controller.tsx - About 1 hr to fix

            Method encabezado has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def encabezado(campo, options = {})
      campo = campo.to_s.sub(/_f\z/, '')
      campo = campo.to_s.sub(/_text\z/, '')
      clase = options[:clase] || @clase_modelo
      if options[:ordenable]
            Severity: Minor
            Found in pg_engine/app/helpers/pg_engine/index_helper.rb - About 1 hr to fix

              Method pg_respond_create has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Confirmed

                  def pg_respond_create
      object = instancia_modelo
      respond_to do |format|
        if (@saved = object.save)
          if params[:asociable]
              Severity: Minor
              Found in pg_engine/app/controllers/concerns/pg_engine/resource.rb - About 1 hr to fix

                Method pg_respond_destroy has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    def pg_respond_destroy(model, redirect_url = nil)
      if destroy_model(model)
        msg = "#{model.model_name.human} #{model.gender == 'f' ? 'borrada' : 'borrado'}"
        respond_to do |format|
          if redirect_url.present?
                Severity: Minor
                Found in pg_engine/app/controllers/concerns/pg_engine/resource.rb - About 1 hr to fix

                  Method do_sort has a Cognitive Complexity of 11 (exceeds 7 allowed). Consider refactoring.
                  Open

                      def do_sort(scope, field, direction)
      # TODO: restringir ciertos campos?
      unless scope.model.column_names.include?(field.to_s) ||
             scope.model.respond_to?("order_by_#{field}")
        pg_warn("No existe el campo \"#{field}\"")
                  Severity: Minor
                  Found in pg_engine/app/controllers/concerns/pg_engine/resource.rb - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method matches? has a Cognitive Complexity of 9 (exceeds 7 allowed). Consider refactoring.
                  Open

                          def matches?(proc)
          msg = 'have_logged only support block expectations'
          raise ArgumentError, msg unless proc.is_a?(Proc)

          original_messages = Set.new(PgEngine::PgLogger.test_logged_messages)
                  Severity: Minor
                  Found in pg_rails/lib/pg_rails/rspec_logger_matchers.rb - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function setMaxHeight has a Cognitive Complexity of 8 (exceeds 7 allowed). Consider refactoring.
                  Confirmed

                    setMaxHeight () {
    let maxHeight
    if (!this.element.closest('.modal')) {
      const scrollTop = document.scrollingElement.scrollTop
      const inputY = this.input.getBoundingClientRect().bottom + scrollTop
                  Severity: Minor
                  Found in pg_associable/app/javascript/asociable_controller.tsx - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language