Sign upLogin

public-law/open-gov-crawlers

View on GitHub
Star

Showing 3 of 4 total issues

File rome_statute.py has 262 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# pyright: reportGeneralTypeIssues=false

import re
from functools import cache
from typing import Any, List, cast
Severity: Minor
Found in public_law/parsers/int/rome_statute.py - About 2 hrs to fix

    Function parse_divisions has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    def parse_divisions(title_number: NonemptyString, dom_or_sel: Selector | XmlResponse, logger: Any) -> list[Division]:
    if isinstance(dom_or_sel, XmlResponse):
        dom = dom_or_sel.selector
    else:
        dom = dom_or_sel
    Severity: Minor
    Found in public_law/parsers/usa/colorado/crs_divisions.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function parse_sections has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    def parse_sections(dom: XmlResponse, logger: Any) -> list[Section]:
    section_nodes = dom.selector.xpath("//SECTION-TEXT")

    sections: list[Section] = []
    for node in section_nodes:
    Severity: Minor
    Found in public_law/parsers/usa/colorado/crs_sections.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language