Sign upLogin

public-market/spree_batch_api

View on GitHub
Star

Showing 3 of 49 total issues

Class DefaultVariantProvider has 35 methods (exceeds 20 allowed). Consider refactoring.
Open

      class DefaultVariantProvider < Spree::BaseAction # rubocop:disable Metrics/ClassLength
        KEYWORDS_DELIMITER = ' '.freeze
        VALIDATION_SCHEMA =
          ::Dry::Validation.Schema do
            required(:sku).filled(:str?)
Severity: Minor
Found in app/actions/spree/inventory/providers/default_variant_provider.rb - About 4 hrs to fix

    Method call has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

              def call
            return if isbn == UNKNOWN_ISBN

            {
              title: book_title,
    Severity: Minor
    Found in app/actions/spree/inventory/providers/fake/metadata_provider.rb - About 1 hr to fix

      Method build_option_value has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def build_option_value(opt_name, opt_value)
      # no option values on master
      return if is_master

      option_type = Spree::OptionType.where(name: opt_name).first_or_initialize do |o|
      Severity: Minor
      Found in app/models/spree/variant_decorator.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language