Sign upLogin

publiclab/spectral-workbench

View on GitHub
Star
app/assets/javascripts/api.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function setup has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    setup: function(min_width,min_height,min_slope,threshold,pixels,wavelengths) {
      min_width = min_width || 7 // min peak width to search for
      min_height = min_height || 20 // min peak width to search for
      min_slope = 3 // minimum peak slope to search for, where 1 = 45 deg
      threshold = threshold || min_width // ignore peaks within <threshold> distance of each other
Severity: Minor
Found in app/assets/javascripts/api.js - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Open

                if (check_slope(1,i) && (i+min_width < pixels.length && i-min_width > 0) && Math.abs(pixels[i]['average']-pixels[i+min_width]['average'])/min_width >= min_slope && Math.abs(pixels[i]['average']-pixels[i-min_width]['average'])/min_width >= min_slope && pixels[i]['average']-pixels[i-min_width]['average'] > min_height && pixels[i]['average']-pixels[i+min_width]['average'] > min_height) { 
              // it's a peak pixel, add it to peak pixel list
              peaks.push(pixels[i]) // here, adding the entire pixel object, including separate rgb and wavelength values
              peaks[peaks.length-1]['index'] = i // save the pixel index too
              // be aware of non-calibrated spectra
    Severity: Major
    Found in app/assets/javascripts/api.js - About 1 hr to fix

      Function setup has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          setup: function(min_width,min_height,min_slope,threshold,pixels,wavelengths) {
      Severity: Minor
      Found in app/assets/javascripts/api.js - About 45 mins to fix

        Function setup has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            setup: function(min_width,min_height,min_slope,threshold,pixels,wavelengths) {
        Severity: Minor
        Found in app/assets/javascripts/api.js - About 45 mins to fix

          Function calibrate has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          $W.calibrate = function(id,x1,w1,x2,w2) {
          Severity: Minor
          Found in app/assets/javascripts/api.js - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                window.location = "/spectra/calibrate/"+$W.spectrum_id+"?x1="+x1+"&w1="+w1+"&x2="+x2+"&w2="+w2
            Severity: Minor
            Found in app/assets/javascripts/api.js and 1 other location - About 50 mins to fix
            app/assets/javascripts/analyze.js on lines 141..141

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status