puffer/puffer_pages

View on GitHub
app/assets/javascripts/puffer/codemirror/xml.js

Summary

Maintainability
C
1 day
Test Coverage

File xml.js has 306 lines of code (exceeds 250 allowed). Consider refactoring.
Open

CodeMirror.defineMode("xml", function(config, parserConfig) {
  var indentUnit = config.indentUnit;
  var Kludges = parserConfig.htmlMode ? {
    autoSelfClosers: {'area': true, 'base': true, 'br': true, 'col': true, 'command': true,
                      'embed': true, 'frame': true, 'hr': true, 'img': true, 'input': true,
Severity: Minor
Found in app/assets/javascripts/puffer/codemirror/xml.js - About 3 hrs to fix

    Function inText has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function inText(stream, state) {
        function chain(parser) {
          state.tokenize = parser;
          return parser(stream, state);
        }
    Severity: Major
    Found in app/assets/javascripts/puffer/codemirror/xml.js - About 2 hrs to fix

      Avoid too many return statements within this function.
      Open

              return "meta";
      Severity: Major
      Found in app/assets/javascripts/puffer/codemirror/xml.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                if (!tagName) return "error";
        Severity: Major
        Found in app/assets/javascripts/puffer/codemirror/xml.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return "tag";
          Severity: Major
          Found in app/assets/javascripts/puffer/codemirror/xml.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return ok ? "atom" : "error";
            Severity: Major
            Found in app/assets/javascripts/puffer/codemirror/xml.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      else return null;
              Severity: Major
              Found in app/assets/javascripts/puffer/codemirror/xml.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return null;
                Severity: Major
                Found in app/assets/javascripts/puffer/codemirror/xml.js - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    function pass() {
                      for (var i = arguments.length - 1; i >= 0; i--) curState.cc.push(arguments[i]);
                    }
                  Severity: Major
                  Found in app/assets/javascripts/puffer/codemirror/xml.js and 1 other location - About 1 hr to fix
                  app/assets/javascripts/puffer/codemirror/javascript.js on lines 191..193

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 55.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status