Sign upLogin

pure-js/browser-detection

View on GitHub
Star

Showing 11 of 24 total issues

Function detectBrowserVersion has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

export function detectBrowserVersion(
  nav: {
    userAgent: string;
    appName?: string;
    appVersion?: string;
Severity: Minor
Found in src/detect-browser-version.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function detectBrowserName has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function detectBrowserName(userAgent: string): BrowserName | undefined {
  if (isChrome(userAgent)) {
    return 'Chrome';
  }
Severity: Minor
Found in src/browser-detection.ts - About 1 hr to fix

    Function detectBrowserName has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    function detectBrowserName(userAgent: string): BrowserName | undefined {
  if (isChrome(userAgent)) {
    return 'Chrome';
  }
    Severity: Minor
    Found in src/browser-detection.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function detectBrowserVersion has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function detectBrowserVersion(
  nav: {
    userAgent: string;
    appName?: string;
    appVersion?: string;
    Severity: Minor
    Found in src/detect-browser-version.ts - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

          return 'Firefox';
      Severity: Major
      Found in src/browser-detection.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return 'UC Browser';
        Severity: Major
        Found in src/browser-detection.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return 'Edge';
          Severity: Major
          Found in src/browser-detection.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return 'Android Browser';
            Severity: Major
            Found in src/browser-detection.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return 'QQ Browser';
              Severity: Major
              Found in src/browser-detection.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return 'IE';
                Severity: Major
                Found in src/browser-detection.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                    return undefined;
                  Severity: Major
                  Found in src/browser-detection.ts - About 30 mins to fix
                    Severity
                    Category
                    Status
                    Source
                    Language