Sign upLogin

pyama86/sac

View on GitHub
Star

Showing 3 of 3 total issues

Method notify_alert has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def self.notify_alert(subject, alerts)
      org = Mackerel.org.name
      attachments = []
      alerts.each do |alert|
        color = case alert.status
Severity: Minor
Found in lib/malsh/notification/slack.rb - About 1 hr to fix

    Method check has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

          def check(hosts)
        to  = Time.now.to_i
        # 7 = 1week
        from = to - (Malsh.options[:past_date] || 7) * 86400
    Severity: Minor
    Found in lib/malsh/host_metrics/base.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method notify_alert has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.notify_alert(subject, alerts)
      org = Mackerel.org.name
      attachments = []
      alerts.each do |alert|
        color = case alert.status
    Severity: Minor
    Found in lib/malsh/notification/slack.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language