Sign upLogin

qcminecraft/Carbon-Forum-F

View on GitHub
Star
static/js/mobile/notifications.function.js

Summary

Maintainability
F
3 days
Test Coverage

Function loadMoreMention has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

function loadMoreMention(forceToShow) {
    var MentionedMeList = $("#MentionedMeList");
    var MentionedMePage = $("#MentionedMePage");
    var MentionedMeLoading = $("#MentionedMeLoading");
Severity: Minor
Found in static/js/mobile/notifications.function.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function loadMoreReply has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

function loadMoreReply(forceToShow) {
    var RepliedToMeList = $("#RepliedToMeList");
    var RepliedToMePage = $("#RepliedToMePage");
    var RepliedToMeLoading = $("#RepliedToMeLoading");
Severity: Minor
Found in static/js/mobile/notifications.function.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function loadMoreInbox has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

function loadMoreInbox(forceToShow) {
    var InboxList = $("#InboxList");
    var InboxPage = $("#InboxPage");
    var InboxLoading = $("#InboxLoading");
    if (forceToShow || (InboxList.is(":visible") && InboxLoading.val() !== "1")) {
Severity: Minor
Found in static/js/mobile/notifications.function.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

function loadMoreInbox(forceToShow) {
    var InboxList = $("#InboxList");
    var InboxPage = $("#InboxPage");
    var InboxLoading = $("#InboxLoading");
    if (forceToShow || (InboxList.is(":visible") && InboxLoading.val() !== "1")) {
Severity: Major
Found in static/js/mobile/notifications.function.js and 4 other locations - About 1 day to fix
static/js/default/global.js on lines 40..67
static/js/default/global.js on lines 69..96
static/js/default/global.js on lines 98..125
static/js/mobile/notifications.function.js on lines 43..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 281.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

function loadMoreMention(forceToShow) {
    var MentionedMeList = $("#MentionedMeList");
    var MentionedMePage = $("#MentionedMePage");
    var MentionedMeLoading = $("#MentionedMeLoading");
Severity: Major
Found in static/js/mobile/notifications.function.js and 4 other locations - About 1 day to fix
static/js/default/global.js on lines 40..67
static/js/default/global.js on lines 69..96
static/js/default/global.js on lines 98..125
static/js/mobile/notifications.function.js on lines 73..99

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 281.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    function isUrlEndWith(endStr) {
        var url = window.document.location.pathname;
        var d = url.length - endStr.length;
        return d >= 0 && url.lastIndexOf(endStr) === d;
    }
Severity: Major
Found in static/js/mobile/notifications.function.js and 1 other location - About 1 hr to fix
static/js/default/global.js on lines 178..182

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status