qcubed/framework

View on GitHub
assets/js/jquery/jquery-migrate.js

Summary

Maintainability
C
1 day
Test Coverage

File jquery-migrate.js has 371 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * jQuery Migrate - v1.1.1 - 2013-02-16
 * https://github.com/jquery/jquery-migrate
 * Copyright 2005, 2013 jQuery Foundation, Inc. and other contributors; Licensed MIT
 */
Severity: Minor
Found in assets/js/jquery/jquery-migrate.js - About 4 hrs to fix

    Function has too many statements (52). Maximum allowed is 30.
    Open

    (function( jQuery, window, undefined ) {
    Severity: Minor
    Found in assets/js/jquery/jquery-migrate.js by eslint

    enforce a maximum number of statements allowed in function blocks (max-statements)

    The max-statements rule allows you to specify the maximum number of statements allowed in a function.

    function foo() {
      var bar = 1; // one statement
      var baz = 2; // two statements
      var qux = 3; // three statements
    }

    Rule Details

    This rule enforces a maximum number of statements allowed in function blocks.

    Options

    This rule has a number or object option:

    • "max" (default 10) enforces a maximum number of statements allows in function blocks

    Deprecated: The object property maximum is deprecated; please use the object property max instead.

    This rule has an object option:

    • "ignoreTopLevelFunctions": true ignores top-level functions

    max

    Examples of incorrect code for this rule with the default { "max": 10 } option:

    /*eslint max-statements: ["error", 10]*/
    /*eslint-env es6*/
    
    function foo() {
      var foo1 = 1;
      var foo2 = 2;
      var foo3 = 3;
      var foo4 = 4;
      var foo5 = 5;
      var foo6 = 6;
      var foo7 = 7;
      var foo8 = 8;
      var foo9 = 9;
      var foo10 = 10;
    
      var foo11 = 11; // Too many.
    }
    
    let foo = () => {
      var foo1 = 1;
      var foo2 = 2;
      var foo3 = 3;
      var foo4 = 4;
      var foo5 = 5;
      var foo6 = 6;
      var foo7 = 7;
      var foo8 = 8;
      var foo9 = 9;
      var foo10 = 10;
    
      var foo11 = 11; // Too many.
    };

    Examples of correct code for this rule with the default { "max": 10 } option:

    /*eslint max-statements: ["error", 10]*/
    /*eslint-env es6*/
    
    function foo() {
      var foo1 = 1;
      var foo2 = 2;
      var foo3 = 3;
      var foo4 = 4;
      var foo5 = 5;
      var foo6 = 6;
      var foo7 = 7;
      var foo8 = 8;
      var foo9 = 9;
      var foo10 = 10;
      return function () {
    
        // The number of statements in the inner function does not count toward the
        // statement maximum.
    
        return 42;
      };
    }
    
    let foo = () => {
      var foo1 = 1;
      var foo2 = 2;
      var foo3 = 3;
      var foo4 = 4;
      var foo5 = 5;
      var foo6 = 6;
      var foo7 = 7;
      var foo8 = 8;
      var foo9 = 9;
      var foo10 = 10;
      return function () {
    
        // The number of statements in the inner function does not count toward the
        // statement maximum.
    
        return 42;
      };
    }

    ignoreTopLevelFunctions

    Examples of additional correct code for this rule with the { "max": 10 }, { "ignoreTopLevelFunctions": true } options:

    /*eslint max-statements: ["error", 10, { "ignoreTopLevelFunctions": true }]*/
    
    function foo() {
      var foo1 = 1;
      var foo2 = 2;
      var foo3 = 3;
      var foo4 = 4;
      var foo5 = 5;
      var foo6 = 6;
      var foo7 = 7;
      var foo8 = 8;
      var foo9 = 9;
      var foo10 = 10;
      var foo11 = 11;
    }

    Related Rules

    • [complexity](complexity.md)
    • [max-depth](max-depth.md)
    • [max-len](max-len.md)
    • [max-nested-callbacks](max-nested-callbacks.md)
    • [max-params](max-params.md) Source: http://eslint.org/docs/rules/

    Function has a complexity of 15.
    Open

    (function( jQuery, window, undefined ) {
    Severity: Minor
    Found in assets/js/jquery/jquery-migrate.js by eslint

    Limit Cyclomatic Complexity (complexity)

    Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

    function a(x) {
        if (true) {
            return x; // 1st path
        } else if (false) {
            return x+1; // 2nd path
        } else {
            return 4; // 3rd path
        }
    }

    Rule Details

    This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

    Examples of incorrect code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/
    
    function a(x) {
        if (true) {
            return x;
        } else if (false) {
            return x+1;
        } else {
            return 4; // 3rd path
        }
    }

    Examples of correct code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/
    
    function a(x) {
        if (true) {
            return x;
        } else {
            return 4;
        }
    }

    Options

    Optionally, you may specify a max object property:

    "complexity": ["error", 2]

    is equivalent to

    "complexity": ["error", { "max": 2 }]

    Deprecated: the object property maximum is deprecated. Please use the property max instead.

    When Not To Use It

    If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

    Further Reading

    Related Rules

    • [max-depth](max-depth.md)
    • [max-len](max-len.md)
    • [max-nested-callbacks](max-nested-callbacks.md)
    • [max-params](max-params.md)
    • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

    Function has a complexity of 8.
    Open

    jQuery.attr = function( elem, name, value, pass ) {
    Severity: Minor
    Found in assets/js/jquery/jquery-migrate.js by eslint

    Limit Cyclomatic Complexity (complexity)

    Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

    function a(x) {
        if (true) {
            return x; // 1st path
        } else if (false) {
            return x+1; // 2nd path
        } else {
            return 4; // 3rd path
        }
    }

    Rule Details

    This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

    Examples of incorrect code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/
    
    function a(x) {
        if (true) {
            return x;
        } else if (false) {
            return x+1;
        } else {
            return 4; // 3rd path
        }
    }

    Examples of correct code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/
    
    function a(x) {
        if (true) {
            return x;
        } else {
            return 4;
        }
    }

    Options

    Optionally, you may specify a max object property:

    "complexity": ["error", 2]

    is equivalent to

    "complexity": ["error", { "max": 2 }]

    Deprecated: the object property maximum is deprecated. Please use the property max instead.

    When Not To Use It

    If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

    Further Reading

    Related Rules

    • [max-depth](max-depth.md)
    • [max-len](max-len.md)
    • [max-nested-callbacks](max-nested-callbacks.md)
    • [max-params](max-params.md)
    • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

    Function has a complexity of 8.
    Open

    jQuery.uaMatch = function( ua ) {
    Severity: Minor
    Found in assets/js/jquery/jquery-migrate.js by eslint

    Limit Cyclomatic Complexity (complexity)

    Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

    function a(x) {
        if (true) {
            return x; // 1st path
        } else if (false) {
            return x+1; // 2nd path
        } else {
            return 4; // 3rd path
        }
    }

    Rule Details

    This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

    Examples of incorrect code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/
    
    function a(x) {
        if (true) {
            return x;
        } else if (false) {
            return x+1;
        } else {
            return 4; // 3rd path
        }
    }

    Examples of correct code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/
    
    function a(x) {
        if (true) {
            return x;
        } else {
            return 4;
        }
    }

    Options

    Optionally, you may specify a max object property:

    "complexity": ["error", 2]

    is equivalent to

    "complexity": ["error", { "max": 2 }]

    Deprecated: the object property maximum is deprecated. Please use the property max instead.

    When Not To Use It

    If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

    Further Reading

    Related Rules

    • [max-depth](max-depth.md)
    • [max-len](max-len.md)
    • [max-nested-callbacks](max-nested-callbacks.md)
    • [max-params](max-params.md)
    • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

    Function has a complexity of 8.
    Open

        jQuery.clean = function( elems, context, fragment, scripts ) {
    Severity: Minor
    Found in assets/js/jquery/jquery-migrate.js by eslint

    Limit Cyclomatic Complexity (complexity)

    Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

    function a(x) {
        if (true) {
            return x; // 1st path
        } else if (false) {
            return x+1; // 2nd path
        } else {
            return 4; // 3rd path
        }
    }

    Rule Details

    This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

    Examples of incorrect code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/
    
    function a(x) {
        if (true) {
            return x;
        } else if (false) {
            return x+1;
        } else {
            return 4; // 3rd path
        }
    }

    Examples of correct code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/
    
    function a(x) {
        if (true) {
            return x;
        } else {
            return 4;
        }
    }

    Options

    Optionally, you may specify a max object property:

    "complexity": ["error", 2]

    is equivalent to

    "complexity": ["error", { "max": 2 }]

    Deprecated: the object property maximum is deprecated. Please use the property max instead.

    When Not To Use It

    If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

    Further Reading

    Related Rules

    • [max-depth](max-depth.md)
    • [max-len](max-len.md)
    • [max-nested-callbacks](max-nested-callbacks.md)
    • [max-params](max-params.md)
    • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

    Function attr has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    jQuery.attr = function( elem, name, value, pass ) {
        var lowerName = name.toLowerCase(),
            nType = elem && elem.nodeType;
    
        if ( pass ) {
    Severity: Minor
    Found in assets/js/jquery/jquery-migrate.js - About 1 hr to fix

      Function clean has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          jQuery.clean = function( elems, context, fragment, scripts ) {
              // Set context per 1.8 logic
              context = context || document;
              context = !context.nodeType && context[0] || context;
              context = context.ownerDocument || context;
      Severity: Minor
      Found in assets/js/jquery/jquery-migrate.js - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                            if ( typeof elem.getElementsByTagName !== "undefined" ) {
                                // handleScript alters the DOM, so use jQuery.merge to ensure snapshot iteration
                                jsTags = jQuery.grep( jQuery.merge( [], elem.getElementsByTagName("script") ), handleScript );
        
                                // Splice the scripts into ret after their former ancestor and advance our index beyond them
        Severity: Major
        Found in assets/js/jquery/jquery-migrate.js - About 45 mins to fix

          Function remove has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          jQuery.event.remove = function( elem, types, handler, selector, mappedTypes ){
          Severity: Minor
          Found in assets/js/jquery/jquery-migrate.js - About 35 mins to fix

            Function add has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            jQuery.event.add = function( elem, types, handler, data, selector ){
            Severity: Minor
            Found in assets/js/jquery/jquery-migrate.js - About 35 mins to fix

              Use ‘===’ to compare with ‘null’.
              Open

                          for ( i = 0; (elem = ret[i]) != null; i++ ) {
              Severity: Minor
              Found in assets/js/jquery/jquery-migrate.js by eslint

              Disallow Null Comparisons (no-eq-null)

              Comparing to null without a type-checking operator (== or !=), can have unintended results as the comparison will evaluate to true when comparing to not just a null, but also an undefined value.

              if (foo == null) {
                bar();
              }

              Rule Details

              The no-eq-null rule aims reduce potential bug and unwanted behavior by ensuring that comparisons to null only match null, and not also undefined. As such it will flag comparisons to null when using == and !=.

              Examples of incorrect code for this rule:

              /*eslint no-eq-null: "error"*/
              
              if (foo == null) {
                bar();
              }
              
              while (qux != null) {
                baz();
              }

              Examples of correct code for this rule:

              /*eslint no-eq-null: "error"*/
              
              if (foo === null) {
                bar();
              }
              
              while (qux !== null) {
                baz();
              }

              Source: http://eslint.org/docs/rules/

              Shadowing of global property 'undefined'.
              Open

              (function( jQuery, window, undefined ) {
              Severity: Minor
              Found in assets/js/jquery/jquery-migrate.js by eslint

              Disallow Shadowing of Restricted Names (no-shadow-restricted-names)

              ES5 §15.1.1 Value Properties of the Global Object (NaN, Infinity, undefined) as well as strict mode restricted identifiers eval and arguments are considered to be restricted names in JavaScript. Defining them to mean something else can have unintended consequences and confuse others reading the code. For example, there's nothing prevent you from writing:

              var undefined = "foo";

              Then any code used within the same scope would not get the global undefined, but rather the local version with a very different meaning.

              Rule Details

              Examples of incorrect code for this rule:

              /*eslint no-shadow-restricted-names: "error"*/
              
              function NaN(){}
              
              !function(Infinity){};
              
              var undefined;
              
              try {} catch(eval){}

              Examples of correct code for this rule:

              /*eslint no-shadow-restricted-names: "error"*/
              
              var Object;
              
              function f(a, b){}

              Further Reading

              Related Rules

              Expected '!==' and instead saw '!='.
              Open

                          for ( i = 0; (elem = ret[i]) != null; i++ ) {
              Severity: Minor
              Found in assets/js/jquery/jquery-migrate.js by eslint

              Require === and !== (eqeqeq)

              It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

              The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

              • [] == false
              • [] == ![]
              • 3 == "03"

              If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

              Rule Details

              This rule is aimed at eliminating the type-unsafe equality operators.

              Examples of incorrect code for this rule:

              /*eslint eqeqeq: "error"*/
              
              if (x == 42) { }
              
              if ("" == text) { }
              
              if (obj.getStuff() != undefined) { }

              The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

              Options

              always

              The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

              Examples of incorrect code for the "always" option:

              /*eslint eqeqeq: ["error", "always"]*/
              
              a == b
              foo == true
              bananas != 1
              value == undefined
              typeof foo == 'undefined'
              'hello' != 'world'
              0 == 0
              true == true
              foo == null

              Examples of correct code for the "always" option:

              /*eslint eqeqeq: ["error", "always"]*/
              
              a === b
              foo === true
              bananas !== 1
              value === undefined
              typeof foo === 'undefined'
              'hello' !== 'world'
              0 === 0
              true === true
              foo === null

              This rule optionally takes a second argument, which should be an object with the following supported properties:

              • "null": Customize how this rule treats null literals. Possible values:
                • always (default) - Always use === or !==.
                • never - Never use === or !== with null.
                • ignore - Do not apply this rule to null.

              smart

              The "smart" option enforces the use of === and !== except for these cases:

              • Comparing two literal values
              • Evaluating the value of typeof
              • Comparing against null

              Examples of incorrect code for the "smart" option:

              /*eslint eqeqeq: ["error", "smart"]*/
              
              // comparing two variables requires ===
              a == b
              
              // only one side is a literal
              foo == true
              bananas != 1
              
              // comparing to undefined requires ===
              value == undefined

              Examples of correct code for the "smart" option:

              /*eslint eqeqeq: ["error", "smart"]*/
              
              typeof foo == 'undefined'
              'hello' != 'world'
              0 == 0
              true == true
              foo == null

              allow-null

              Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

              ["error", "always", {"null": "ignore"}]

              When Not To Use It

              If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

              Move the invocation into the parens that contain the function.
              Open

              (function( jQuery, window, undefined ) {
              Severity: Minor
              Found in assets/js/jquery/jquery-migrate.js by eslint

              Require IIFEs to be Wrapped (wrap-iife)

              You can immediately invoke function expressions, but not function declarations. A common technique to create an immediately-invoked function expression (IIFE) is to wrap a function declaration in parentheses. The opening parentheses causes the contained function to be parsed as an expression, rather than a declaration.

              // function expression could be unwrapped
              var x = function () { return { y: 1 };}();
              
              // function declaration must be wrapped
              function () { /* side effects */ }(); // SyntaxError

              Rule Details

              This rule requires all immediately-invoked function expressions to be wrapped in parentheses.

              Options

              This rule has two options, a string option and an object option.

              String option:

              • "outside" enforces always wrapping the call expression. The default is "outside".
              • "inside" enforces always wrapping the function expression.
              • "any" enforces always wrapping, but allows either style.

              Object option:

              • "functionPrototypeMethods": true additionally enforces wrapping function expressions invoked using .call and .apply. The default is false.

              outside

              Examples of incorrect code for the default "outside" option:

              /*eslint wrap-iife: ["error", "outside"]*/
              
              var x = function () { return { y: 1 };}(); // unwrapped
              var x = (function () { return { y: 1 };})(); // wrapped function expression

              Examples of correct code for the default "outside" option:

              /*eslint wrap-iife: ["error", "outside"]*/
              
              var x = (function () { return { y: 1 };}()); // wrapped call expression

              inside

              Examples of incorrect code for the "inside" option:

              /*eslint wrap-iife: ["error", "inside"]*/
              
              var x = function () { return { y: 1 };}(); // unwrapped
              var x = (function () { return { y: 1 };}()); // wrapped call expression

              Examples of correct code for the "inside" option:

              /*eslint wrap-iife: ["error", "inside"]*/
              
              var x = (function () { return { y: 1 };})(); // wrapped function expression

              any

              Examples of incorrect code for the "any" option:

              /*eslint wrap-iife: ["error", "any"]*/
              
              var x = function () { return { y: 1 };}(); // unwrapped

              Examples of correct code for the "any" option:

              /*eslint wrap-iife: ["error", "any"]*/
              
              var x = (function () { return { y: 1 };}()); // wrapped call expression
              var x = (function () { return { y: 1 };})(); // wrapped function expression

              functionPrototypeMethods

              Examples of incorrect code for this rule with the "inside", { "functionPrototypeMethods": true } options:

              /* eslint wrap-iife: [2, "inside", { functionPrototypeMethods: true }] */
              
              var x = function(){ foo(); }()
              var x = (function(){ foo(); }())
              var x = function(){ foo(); }.call(bar)
              var x = (function(){ foo(); }.call(bar))

              Examples of correct code for this rule with the "inside", { "functionPrototypeMethods": true } options:

              /* eslint wrap-iife: [2, "inside", { functionPrototypeMethods: true }] */
              
              var x = (function(){ foo(); })()
              var x = (function(){ foo(); }).call(bar)

              Source: http://eslint.org/docs/rules/

              There are no issues that match your filters.

              Category
              Status