Sign upLogin

qlik-oss/sn-org-chart

View on GitHub
Star
src/utils/tree-utils.js

Summary

Maintainability
C
1 day
Test Coverage
A
99%

Function createNodes has 71 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function createNodes(matrix, attributeIndecies, status, navigationMode, translator) {
  const nodeMap = {};
  const allNodes = [];
  for (let i = 0; i < matrix.length; ++i) {
    const row = matrix[i];
Severity: Major
Found in src/utils/tree-utils.js - About 2 hrs to fix

    Function createNodes has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

    export function createNodes(matrix, attributeIndecies, status, navigationMode, translator) {
  const nodeMap = {};
  const allNodes = [];
  for (let i = 0; i < matrix.length; ++i) {
    const row = matrix[i];
    Severity: Minor
    Found in src/utils/tree-utils.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function anyCycle has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

    export function anyCycle(nodes) {
  const visited = {};
  const marked = {};
  function isCycleUtil(node) {
    visited[node.id] = true;
    Severity: Minor
    Found in src/utils/tree-utils.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function fetchPage has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    export async function fetchPage(dataPages, dataMatrix, model, fullHeight, currentRow, callNum, maxCalls) {
    Severity: Major
    Found in src/utils/tree-utils.js - About 50 mins to fix

      Function createNodes has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      export function createNodes(matrix, attributeIndecies, status, navigationMode, translator) {
      Severity: Minor
      Found in src/utils/tree-utils.js - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status