Sign upLogin

quran/quran.com-frontend

View on GitHub
Star
src/redux/modules/audioplayer.js

Summary

Maintainability
D
2 days
Test Coverage

Function reducer has 179 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function reducer(state = initialState, action = {}) {
  switch (action.type) {
    case VERSES_CLEAR_CURRENT: {
      const stateFilesCurrent = state.files;
Severity: Major
Found in src/redux/modules/audioplayer.js - About 7 hrs to fix

    Function reducer has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function reducer(state = initialState, action = {}) {
  switch (action.type) {
    case VERSES_CLEAR_CURRENT: {
      const stateFilesCurrent = state.files;
    Severity: Minor
    Found in src/redux/modules/audioplayer.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

          return {
        ...state,
        isPlaying: false
      };
    Severity: Major
    Found in src/redux/modules/audioplayer.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            if (!action.word) return state;
      Severity: Major
      Found in src/redux/modules/audioplayer.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return state;
        Severity: Major
        Found in src/redux/modules/audioplayer.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return {
        ...state,
        currentVerse: nextId,
        currentFile: state.files[chapterId][nextId],
        currentTime: 0
          Severity: Major
          Found in src/redux/modules/audioplayer.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return {
        ...state,
        currentVerse,
        currentFile,
        currentTime: 0
            Severity: Major
            Found in src/redux/modules/audioplayer.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return {
        ...state,
        repeat
      };
              Severity: Major
              Found in src/redux/modules/audioplayer.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      if (!state.segments[chapterId][nextId].words[position]) return state;
                Severity: Major
                Found in src/redux/modules/audioplayer.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return {
          ...state,
          currentWord: action.word,
          currentTime
        };
                  Severity: Major
                  Found in src/redux/modules/audioplayer.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return {
        ...state,
        currentWord: word
      };
                    Severity: Major
                    Found in src/redux/modules/audioplayer.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            return {
        ...state,
        currentVerse: nextId,
        currentFile: state.files[chapterId][nextId],
        currentTime: 0
                      Severity: Major
                      Found in src/redux/modules/audioplayer.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                              return {
        ...state,
        currentFile: action.file
      };
                        Severity: Major
                        Found in src/redux/modules/audioplayer.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                return {
        ...state,
        currentWord: action.word,
        currentVerse: nextId,
        isPlaying: false,
                          Severity: Major
                          Found in src/redux/modules/audioplayer.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                  return {
        ...state,
        isPlaying: true
      };
                            Severity: Major
                            Found in src/redux/modules/audioplayer.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                    if (!state.segments[chapterId][nextId]) return state;
                              Severity: Major
                              Found in src/redux/modules/audioplayer.js - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                      if (!action.payload) return state;
                                Severity: Major
                                Found in src/redux/modules/audioplayer.js - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                        return {
        ...state,
        shouldScroll: !state.shouldScroll
      };
                                  Severity: Major
                                  Found in src/redux/modules/audioplayer.js - About 30 mins to fix

                                    Avoid too many return statements within this function.
                                    Open

                                          return {
        ...state,
        currentVerse: action.id
      };
                                    Severity: Major
                                    Found in src/redux/modules/audioplayer.js - About 30 mins to fix

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                          case PREVIOUS: {
      const [chapterId, ayahNum] = action.currentVerse.split(':');
      const nextId = `${chapterId}:${parseInt(ayahNum, 10) - 1}`;

      return {
                                      Severity: Major
                                      Found in src/redux/modules/audioplayer.js and 1 other location - About 2 hrs to fix
                                      src/redux/modules/audioplayer.js on lines 110..120

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 92.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                          case NEXT: {
      const [chapterId, ayahNum] = action.currentVerse.split(':');
      const nextId = `${chapterId}:${parseInt(ayahNum, 10) + 1}`;

      return {
                                      Severity: Major
                                      Found in src/redux/modules/audioplayer.js and 1 other location - About 2 hrs to fix
                                      src/redux/modules/audioplayer.js on lines 121..131

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 92.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      There are no issues that match your filters.

                                      Category
                                      Status