quran/quran.com-frontend

View on GitHub
src/utils/routeFilters.js

Summary

Maintainability
C
1 day
Test Coverage

Function filterValidVerse has 134 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function filterValidVerse(replaceState, chapterId, verseRange) {
  const chapterToVersesMap = {
    1: 7,
    2: 286,
    3: 200,
Severity: Major
Found in src/utils/routeFilters.js - About 5 hrs to fix

    Function checkValidChapterOrVerse has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function checkValidChapterOrVerse(nextState, replaceState) {
      const chapterId = parseInt(nextState.params.chapterId, 10);
      filterValidChapter(replaceState, chapterId);
    
      if (nextState.params.range) {
    Severity: Minor
    Found in src/utils/routeFilters.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function checkValidChapterOrVerse has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export default function checkValidChapterOrVerse(nextState, replaceState) {
      const chapterId = parseInt(nextState.params.chapterId, 10);
      filterValidChapter(replaceState, chapterId);
    
      if (nextState.params.range) {
    Severity: Minor
    Found in src/utils/routeFilters.js - About 1 hr to fix

      Function filterValidVerse has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      function filterValidVerse(replaceState, chapterId, verseRange) {
        const chapterToVersesMap = {
          1: 7,
          2: 286,
          3: 200,
      Severity: Minor
      Found in src/utils/routeFilters.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status