r2js/r2admin

View on GitHub
assets/js/scripts/fields/relation.js

Summary

Maintainability
C
1 day
Test Coverage

Function select has 78 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const select = (el) => {
  const data = el.data();
  const { ref, display, value, qtype, placeholder } = data;
  const isMultiple = el.attr('multiple') === 'multiple';
  const { sort = display } = data;
Severity: Major
Found in assets/js/scripts/fields/relation.js - About 3 hrs to fix

    Function select2nested has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    const select2nested = (data, valueField, displayField, isMultiple, prefix, initPrefix = '-') => {
      let r = [];
      let getPrefix = prefix;
      if (!getPrefix) {
        getPrefix = isMultiple ? '' : `${initPrefix} `;
    Severity: Minor
    Found in assets/js/scripts/fields/relation.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function onInitialize has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        onInitialize() {
          const self = this;
          const q = { limit: 100, sort };
    
          if (qtype === 'fullArrayTree') {
    Severity: Minor
    Found in assets/js/scripts/fields/relation.js - About 1 hr to fix

      Function select has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      const select = (el) => {
        const data = el.data();
        const { ref, display, value, qtype, placeholder } = data;
        const isMultiple = el.attr('multiple') === 'multiple';
        const { sort = display } = data;
      Severity: Minor
      Found in assets/js/scripts/fields/relation.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Unexpected dangling '_' in '_id'.
      Open

                    vals.push(item._id);
      Severity: Minor
      Found in assets/js/scripts/fields/relation.js by eslint

      disallow dangling underscores in identifiers (no-underscore-dangle)

      As far as naming conventions for identifiers go, dangling underscores may be the most polarizing in JavaScript. Dangling underscores are underscores at either the beginning or end of an identifier, such as:

      var _foo;

      There is actually a long history of using dangling underscores to indicate "private" members of objects in JavaScript (though JavaScript doesn't have truly private members, this convention served as a warning). This began with SpiderMonkey adding nonstandard methods such as __defineGetter__(). The intent with the underscores was to make it obvious that this method was special in some way. Since that time, using a single underscore prefix has become popular as a way to indicate "private" members of objects.

      Whether or not you choose to allow dangling underscores in identifiers is purely a convention and has no effect on performance, readability, or complexity. It's purely a preference.

      Rule Details

      This rule disallows dangling underscores in identifiers.

      Examples of incorrect code for this rule:

      /*eslint no-underscore-dangle: "error"*/
      
      var foo_;
      var __proto__ = {};
      foo._bar();

      Examples of correct code for this rule:

      /*eslint no-underscore-dangle: "error"*/
      
      var _ = require('underscore');
      var obj = _.contains(items, item);
      obj.__proto__ = {};
      var file = __filename;

      Options

      This rule has an object option:

      • "allow" allows specified identifiers to have dangling underscores
      • "allowAfterThis": false (default) disallows dangling underscores in members of the this object
      • "allowAfterSuper": false (default) disallows dangling underscores in members of the super object

      allow

      Examples of additional correct code for this rule with the { "allow": ["foo_", "_bar"] } option:

      /*eslint no-underscore-dangle: ["error", { "allow": ["foo_", "_bar"] }]*/
      
      var foo_;
      foo._bar();

      allowAfterThis

      Examples of correct code for this rule with the { "allowAfterThis": true } option:

      /*eslint no-underscore-dangle: ["error", { "allowAfterThis": true }]*/
      
      var a = this.foo_;
      this._bar();

      allowAfterSuper

      Examples of correct code for this rule with the { "allowAfterSuper": true } option:

      /*eslint no-underscore-dangle: ["error", { "allowAfterSuper": true }]*/
      
      var a = super.foo_;
      super._bar();

      When Not To Use It

      If you want to allow dangling underscores in identifiers, then you can safely turn this rule off. Source: http://eslint.org/docs/rules/

      Unexpected dangling '_' in '_id'.
      Open

                  if (getValue.includes(item._id)) {
      Severity: Minor
      Found in assets/js/scripts/fields/relation.js by eslint

      disallow dangling underscores in identifiers (no-underscore-dangle)

      As far as naming conventions for identifiers go, dangling underscores may be the most polarizing in JavaScript. Dangling underscores are underscores at either the beginning or end of an identifier, such as:

      var _foo;

      There is actually a long history of using dangling underscores to indicate "private" members of objects in JavaScript (though JavaScript doesn't have truly private members, this convention served as a warning). This began with SpiderMonkey adding nonstandard methods such as __defineGetter__(). The intent with the underscores was to make it obvious that this method was special in some way. Since that time, using a single underscore prefix has become popular as a way to indicate "private" members of objects.

      Whether or not you choose to allow dangling underscores in identifiers is purely a convention and has no effect on performance, readability, or complexity. It's purely a preference.

      Rule Details

      This rule disallows dangling underscores in identifiers.

      Examples of incorrect code for this rule:

      /*eslint no-underscore-dangle: "error"*/
      
      var foo_;
      var __proto__ = {};
      foo._bar();

      Examples of correct code for this rule:

      /*eslint no-underscore-dangle: "error"*/
      
      var _ = require('underscore');
      var obj = _.contains(items, item);
      obj.__proto__ = {};
      var file = __filename;

      Options

      This rule has an object option:

      • "allow" allows specified identifiers to have dangling underscores
      • "allowAfterThis": false (default) disallows dangling underscores in members of the this object
      • "allowAfterSuper": false (default) disallows dangling underscores in members of the super object

      allow

      Examples of additional correct code for this rule with the { "allow": ["foo_", "_bar"] } option:

      /*eslint no-underscore-dangle: ["error", { "allow": ["foo_", "_bar"] }]*/
      
      var foo_;
      foo._bar();

      allowAfterThis

      Examples of correct code for this rule with the { "allowAfterThis": true } option:

      /*eslint no-underscore-dangle: ["error", { "allowAfterThis": true }]*/
      
      var a = this.foo_;
      this._bar();

      allowAfterSuper

      Examples of correct code for this rule with the { "allowAfterSuper": true } option:

      /*eslint no-underscore-dangle: ["error", { "allowAfterSuper": true }]*/
      
      var a = super.foo_;
      super._bar();

      When Not To Use It

      If you want to allow dangling underscores in identifiers, then you can safely turn this rule off. Source: http://eslint.org/docs/rules/

      Missing trailing comma.
      Open

                select2nested(data[d].children, valueField, displayField, isMultiple, addPrefix)
      Severity: Minor
      Found in assets/js/scripts/fields/relation.js by eslint

      require or disallow trailing commas (comma-dangle)

      Trailing commas in object literals are valid according to the ECMAScript 5 (and ECMAScript 3!) spec. However, IE8 (when not in IE8 document mode) and below will throw an error when it encounters trailing commas in JavaScript.

      var foo = {
          bar: "baz",
          qux: "quux",
      };

      Trailing commas simplify adding and removing items to objects and arrays, since only the lines you are modifying must be touched. Another argument in favor of trailing commas is that it improves the clarity of diffs when an item is added or removed from an object or array:

      Less clear:

      var foo = {
      -    bar: "baz",
      -    qux: "quux"
      +    bar: "baz"
       };

      More clear:

      var foo = {
           bar: "baz",
      -    qux: "quux",
       };

      Rule Details

      This rule enforces consistent use of trailing commas in object and array literals.

      Options

      This rule has a string option or an object option:

      {
          "comma-dangle": ["error", "never"],
          // or
          "comma-dangle": ["error", {
              "arrays": "never",
              "objects": "never",
              "imports": "never",
              "exports": "never",
              "functions": "ignore",
          }]
      }
      • "never" (default) disallows trailing commas
      • "always" requires trailing commas
      • "always-multiline" requires trailing commas when the last element or property is in a different line than the closing ] or } and disallows trailing commas when the last element or property is on the same line as the closing ] or }
      • "only-multiline" allows (but does not require) trailing commas when the last element or property is in a different line than the closing ] or } and disallows trailing commas when the last element or property is on the same line as the closing ] or }

      Trailing commas in function declarations and function calls are valid syntax since ECMAScript 2017; however, the string option does not check these situations for backwards compatibility.

      You can also use an object option to configure this rule for each type of syntax. Each of the following options can be set to "never", "always", "always-multiline", "only-multiline", or "ignore". The default for each option is "never" unless otherwise specified.

      • arrays is for array literals and array patterns of destructuring. (e.g. let [a,] = [1,];)
      • objects is for object literals and object patterns of destructuring. (e.g. let {a,} = {a: 1};)
      • imports is for import declarations of ES Modules. (e.g. import {a,} from "foo";)
      • exports is for export declarations of ES Modules. (e.g. export {a,};)
      • functions is for function declarations and function calls. (e.g. (function(a,){ })(b,);)
        functions is set to "ignore" by default for consistency with the string option.

      never

      Examples of incorrect code for this rule with the default "never" option:

      /*eslint comma-dangle: ["error", "never"]*/
      
      var foo = {
          bar: "baz",
          qux: "quux",
      };
      
      var arr = [1,2,];
      
      foo({
        bar: "baz",
        qux: "quux",
      });

      Examples of correct code for this rule with the default "never" option:

      /*eslint comma-dangle: ["error", "never"]*/
      
      var foo = {
          bar: "baz",
          qux: "quux"
      };
      
      var arr = [1,2];
      
      foo({
        bar: "baz",
        qux: "quux"
      });

      always

      Examples of incorrect code for this rule with the "always" option:

      /*eslint comma-dangle: ["error", "always"]*/
      
      var foo = {
          bar: "baz",
          qux: "quux"
      };
      
      var arr = [1,2];
      
      foo({
        bar: "baz",
        qux: "quux"
      });

      Examples of correct code for this rule with the "always" option:

      /*eslint comma-dangle: ["error", "always"]*/
      
      var foo = {
          bar: "baz",
          qux: "quux",
      };
      
      var arr = [1,2,];
      
      foo({
        bar: "baz",
        qux: "quux",
      });

      always-multiline

      Examples of incorrect code for this rule with the "always-multiline" option:

      /*eslint comma-dangle: ["error", "always-multiline"]*/
      
      var foo = {
          bar: "baz",
          qux: "quux"
      };
      
      var foo = { bar: "baz", qux: "quux", };
      
      var arr = [1,2,];
      
      var arr = [1,
          2,];
      
      var arr = [
          1,
          2
      ];
      
      foo({
        bar: "baz",
        qux: "quux"
      });

      Examples of correct code for this rule with the "always-multiline" option:

      /*eslint comma-dangle: ["error", "always-multiline"]*/
      
      var foo = {
          bar: "baz",
          qux: "quux",
      };
      
      var foo = {bar: "baz", qux: "quux"};
      var arr = [1,2];
      
      var arr = [1,
          2];
      
      var arr = [
          1,
          2,
      ];
      
      foo({
        bar: "baz",
        qux: "quux",
      });

      only-multiline

      Examples of incorrect code for this rule with the "only-multiline" option:

      /*eslint comma-dangle: ["error", "only-multiline"]*/
      
      var foo = { bar: "baz", qux: "quux", };
      
      var arr = [1,2,];
      
      var arr = [1,
          2,];

      Examples of correct code for this rule with the "only-multiline" option:

      /*eslint comma-dangle: ["error", "only-multiline"]*/
      
      var foo = {
          bar: "baz",
          qux: "quux",
      };
      
      var foo = {
          bar: "baz",
          qux: "quux"
      };
      
      var foo = {bar: "baz", qux: "quux"};
      var arr = [1,2];
      
      var arr = [1,
          2];
      
      var arr = [
          1,
          2,
      ];
      
      var arr = [
          1,
          2
      ];
      
      foo({
        bar: "baz",
        qux: "quux",
      });
      
      foo({
        bar: "baz",
        qux: "quux"
      });

      functions

      Examples of incorrect code for this rule with the {"functions": "never"} option:

      /*eslint comma-dangle: ["error", {"functions": "never"}]*/
      
      function foo(a, b,) {
      }
      
      foo(a, b,);
      new foo(a, b,);

      Examples of correct code for this rule with the {"functions": "never"} option:

      /*eslint comma-dangle: ["error", {"functions": "never"}]*/
      
      function foo(a, b) {
      }
      
      foo(a, b);
      new foo(a, b);

      Examples of incorrect code for this rule with the {"functions": "always"} option:

      /*eslint comma-dangle: ["error", {"functions": "always"}]*/
      
      function foo(a, b) {
      }
      
      foo(a, b);
      new foo(a, b);

      Examples of correct code for this rule with the {"functions": "always"} option:

      /*eslint comma-dangle: ["error", {"functions": "always"}]*/
      
      function foo(a, b,) {
      }
      
      foo(a, b,);
      new foo(a, b,);

      When Not To Use It

      You can turn this rule off if you are not concerned with dangling commas. Source: http://eslint.org/docs/rules/

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

          onChange(elValue) {
            if (!elValue || !elValue.length) {
              return el.parent().removeClass('fl-is-active');
            }
      
      
      Severity: Major
      Found in assets/js/scripts/fields/relation.js and 2 other locations - About 1 hr to fix
      assets/js/scripts/fields/array.js on lines 23..29
      assets/js/scripts/fields/select.js on lines 23..29

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status