radare/radare2-webui

View on GitHub
www/enyo/js/mainpanel.js

Summary

Maintainability
F
4 days
Test Coverage

eval can be harmful.
Open

        eval('var x = this.$.page' + idx);
Severity: Minor
Found in www/enyo/js/mainpanel.js by eslint

Disallow eval() (no-eval)

JavaScript's eval() function is potentially dangerous and is often misused. Using eval() on untrusted code can open a program up to several different injection attacks. The use of eval() in most contexts can be substituted for a better, alternative approach to a problem.

var obj = { x: "foo" },
    key = "x",
    value = eval("obj." + key);

Rule Details

This rule is aimed at preventing potentially dangerous, unnecessary, and slow code by disallowing the use of the eval() function. As such, it will warn whenever the eval() function is used.

Examples of incorrect code for this rule:

/*eslint no-eval: "error"*/

var obj = { x: "foo" },
    key = "x",
    value = eval("obj." + key);

(0, eval)("var a = 0");

var foo = eval;
foo("var a = 0");

// This `this` is the global object.
this.eval("var a = 0");

Example of additional incorrect code for this rule when browser environment is set to true:

/*eslint no-eval: "error"*/
/*eslint-env browser*/

window.eval("var a = 0");

Example of additional incorrect code for this rule when node environment is set to true:

/*eslint no-eval: "error"*/
/*eslint-env node*/

global.eval("var a = 0");

Examples of correct code for this rule:

/*eslint no-eval: "error"*/
/*eslint-env es6*/

var obj = { x: "foo" },
    key = "x",
    value = obj[key];

class A {
    foo() {
        // This is a user-defined method.
        this.eval("var a = 0");
    }

    eval() {
    }
}

Options

This rule has an option to allow indirect calls to eval. Indirect calls to eval are less dangerous than direct calls to eval because they cannot dynamically change the scope. Because of this, they also will not negatively impact performance to the degree of direct eval.

{
    "no-eval": ["error", {"allowIndirect": true}] // default is false
}

Example of incorrect code for this rule with the {"allowIndirect": true} option:

/*eslint no-eval: "error"*/

var obj = { x: "foo" },
    key = "x",
    value = eval("obj." + key);

Examples of correct code for this rule with the {"allowIndirect": true} option:

/*eslint no-eval: "error"*/

(0, eval)("var a = 0");

var foo = eval;
foo("var a = 0");

this.eval("var a = 0");
/*eslint no-eval: "error"*/
/*eslint-env browser*/

window.eval("var a = 0");
/*eslint no-eval: "error"*/
/*eslint-env node*/

global.eval("var a = 0");

Known Limitations

  • This rule is warning every eval() even if the eval is not global's. This behavior is in order to detect calls of direct eval. Such as:
module.exports = function(eval) {
      // If the value of this `eval` is built-in `eval` function, this is a
      // call of direct `eval`.
      eval("var a = 0");
  };
  • This rule cannot catch renaming the global object. Such as:
var foo = window;
  foo.eval("var a = 0");

Further Reading

Related Rules

`` has 29 functions (exceeds 20 allowed). Consider refactoring.
Open

enyo.kind({
    name: 'MainPanel',
    classes: 'onyx',
    kind: 'FittableRows',
    classes: 'enyo-fit',
Severity: Minor
Found in www/enyo/js/mainpanel.js - About 3 hrs to fix

    File mainpanel.js has 311 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    enyo.kind({
        name: 'MainPanel',
        classes: 'onyx',
        kind: 'FittableRows',
        classes: 'enyo-fit',
    Severity: Minor
    Found in www/enyo/js/mainpanel.js - About 3 hrs to fix

      Method 'openPage' has a complexity of 15.
      Open

          openPage: function(idx) {
      Severity: Minor
      Found in www/enyo/js/mainpanel.js by eslint

      Limit Cyclomatic Complexity (complexity)

      Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

      function a(x) {
          if (true) {
              return x; // 1st path
          } else if (false) {
              return x+1; // 2nd path
          } else {
              return 4; // 3rd path
          }
      }

      Rule Details

      This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

      Examples of incorrect code for a maximum of 2:

      /*eslint complexity: ["error", 2]*/
      
      function a(x) {
          if (true) {
              return x;
          } else if (false) {
              return x+1;
          } else {
              return 4; // 3rd path
          }
      }

      Examples of correct code for a maximum of 2:

      /*eslint complexity: ["error", 2]*/
      
      function a(x) {
          if (true) {
              return x;
          } else {
              return 4;
          }
      }

      Options

      Optionally, you may specify a max object property:

      "complexity": ["error", 2]

      is equivalent to

      "complexity": ["error", { "max": 2 }]

      Deprecated: the object property maximum is deprecated. Please use the property max instead.

      When Not To Use It

      If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

      Further Reading

      Related Rules

      • [max-depth](max-depth.md)
      • [max-len](max-len.md)
      • [max-nested-callbacks](max-nested-callbacks.md)
      • [max-params](max-params.md)
      • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

      Function create has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          create: function() {
              this.inherited(arguments);
      
              var mode = readCookie('r2_view_mode');
              if (!mode) mode = 'old';
      Severity: Minor
      Found in www/enyo/js/mainpanel.js - About 2 hrs to fix

        Function openPage has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            openPage: function(idx) {
                var str, sp = this.$.panels;
                // TODO: this is just a hack
                var r = -1;
                switch (idx) {
        Severity: Minor
        Found in www/enyo/js/mainpanel.js - About 1 hr to fix

          Unexpected alert.
          Open

                  alert('nothing to see here! move along.');
          Severity: Minor
          Found in www/enyo/js/mainpanel.js by eslint

          Disallow Use of Alert (no-alert)

          JavaScript's alert, confirm, and prompt functions are widely considered to be obtrusive as UI elements and should be replaced by a more appropriate custom UI implementation. Furthermore, alert is often used while debugging code, which should be removed before deployment to production.

          alert("here!");

          Rule Details

          This rule is aimed at catching debugging code that should be removed and popup UI elements that should be replaced with less obtrusive, custom UIs. As such, it will warn when it encounters alert, prompt, and confirm function calls which are not shadowed.

          Examples of incorrect code for this rule:

          /*eslint no-alert: "error"*/
          
          alert("here!");
          
          confirm("Are you sure?");
          
          prompt("What's your name?", "John Doe");

          Examples of correct code for this rule:

          /*eslint no-alert: "error"*/
          
          customAlert("Something happened!");
          
          customConfirm("Are you sure?");
          
          customPrompt("Who are you?");
          
          function foo() {
              var alert = myCustomLib.customAlert;
              alert();
          }

          Related Rules

          Unexpected alert.
          Open

                  alert('let\'s play!');
          Severity: Minor
          Found in www/enyo/js/mainpanel.js by eslint

          Disallow Use of Alert (no-alert)

          JavaScript's alert, confirm, and prompt functions are widely considered to be obtrusive as UI elements and should be replaced by a more appropriate custom UI implementation. Furthermore, alert is often used while debugging code, which should be removed before deployment to production.

          alert("here!");

          Rule Details

          This rule is aimed at catching debugging code that should be removed and popup UI elements that should be replaced with less obtrusive, custom UIs. As such, it will warn when it encounters alert, prompt, and confirm function calls which are not shadowed.

          Examples of incorrect code for this rule:

          /*eslint no-alert: "error"*/
          
          alert("here!");
          
          confirm("Are you sure?");
          
          prompt("What's your name?", "John Doe");

          Examples of correct code for this rule:

          /*eslint no-alert: "error"*/
          
          customAlert("Something happened!");
          
          customConfirm("Are you sure?");
          
          customPrompt("Who are you?");
          
          function foo() {
              var alert = myCustomLib.customAlert;
              alert();
          }

          Related Rules

          Unexpected prompt.
          Open

               var msg = prompt('How many bytes?', '');
          Severity: Minor
          Found in www/enyo/js/mainpanel.js by eslint

          Disallow Use of Alert (no-alert)

          JavaScript's alert, confirm, and prompt functions are widely considered to be obtrusive as UI elements and should be replaced by a more appropriate custom UI implementation. Furthermore, alert is often used while debugging code, which should be removed before deployment to production.

          alert("here!");

          Rule Details

          This rule is aimed at catching debugging code that should be removed and popup UI elements that should be replaced with less obtrusive, custom UIs. As such, it will warn when it encounters alert, prompt, and confirm function calls which are not shadowed.

          Examples of incorrect code for this rule:

          /*eslint no-alert: "error"*/
          
          alert("here!");
          
          confirm("Are you sure?");
          
          prompt("What's your name?", "John Doe");

          Examples of correct code for this rule:

          /*eslint no-alert: "error"*/
          
          customAlert("Something happened!");
          
          customConfirm("Are you sure?");
          
          customPrompt("Who are you?");
          
          function foo() {
              var alert = myCustomLib.customAlert;
              alert();
          }

          Related Rules

          Unexpected prompt.
          Open

               var msg = prompt('Hexpair', '');
          Severity: Minor
          Found in www/enyo/js/mainpanel.js by eslint

          Disallow Use of Alert (no-alert)

          JavaScript's alert, confirm, and prompt functions are widely considered to be obtrusive as UI elements and should be replaced by a more appropriate custom UI implementation. Furthermore, alert is often used while debugging code, which should be removed before deployment to production.

          alert("here!");

          Rule Details

          This rule is aimed at catching debugging code that should be removed and popup UI elements that should be replaced with less obtrusive, custom UIs. As such, it will warn when it encounters alert, prompt, and confirm function calls which are not shadowed.

          Examples of incorrect code for this rule:

          /*eslint no-alert: "error"*/
          
          alert("here!");
          
          confirm("Are you sure?");
          
          prompt("What's your name?", "John Doe");

          Examples of correct code for this rule:

          /*eslint no-alert: "error"*/
          
          customAlert("Something happened!");
          
          customConfirm("Are you sure?");
          
          customPrompt("Who are you?");
          
          function foo() {
              var alert = myCustomLib.customAlert;
              alert();
          }

          Related Rules

          Unexpected prompt.
          Open

               var msg = prompt('How many bytes?', '');
          Severity: Minor
          Found in www/enyo/js/mainpanel.js by eslint

          Disallow Use of Alert (no-alert)

          JavaScript's alert, confirm, and prompt functions are widely considered to be obtrusive as UI elements and should be replaced by a more appropriate custom UI implementation. Furthermore, alert is often used while debugging code, which should be removed before deployment to production.

          alert("here!");

          Rule Details

          This rule is aimed at catching debugging code that should be removed and popup UI elements that should be replaced with less obtrusive, custom UIs. As such, it will warn when it encounters alert, prompt, and confirm function calls which are not shadowed.

          Examples of incorrect code for this rule:

          /*eslint no-alert: "error"*/
          
          alert("here!");
          
          confirm("Are you sure?");
          
          prompt("What's your name?", "John Doe");

          Examples of correct code for this rule:

          /*eslint no-alert: "error"*/
          
          customAlert("Something happened!");
          
          customConfirm("Are you sure?");
          
          customPrompt("Who are you?");
          
          function foo() {
              var alert = myCustomLib.customAlert;
              alert();
          }

          Related Rules

          Expected '===' and instead saw '=='.
          Open

                  if (addr[0] == '!') {
          Severity: Minor
          Found in www/enyo/js/mainpanel.js by eslint

          Require === and !== (eqeqeq)

          It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

          The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

          • [] == false
          • [] == ![]
          • 3 == "03"

          If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

          Rule Details

          This rule is aimed at eliminating the type-unsafe equality operators.

          Examples of incorrect code for this rule:

          /*eslint eqeqeq: "error"*/
          
          if (x == 42) { }
          
          if ("" == text) { }
          
          if (obj.getStuff() != undefined) { }

          The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

          Options

          always

          The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

          Examples of incorrect code for the "always" option:

          /*eslint eqeqeq: ["error", "always"]*/
          
          a == b
          foo == true
          bananas != 1
          value == undefined
          typeof foo == 'undefined'
          'hello' != 'world'
          0 == 0
          true == true
          foo == null

          Examples of correct code for the "always" option:

          /*eslint eqeqeq: ["error", "always"]*/
          
          a === b
          foo === true
          bananas !== 1
          value === undefined
          typeof foo === 'undefined'
          'hello' !== 'world'
          0 === 0
          true === true
          foo === null

          This rule optionally takes a second argument, which should be an object with the following supported properties:

          • "null": Customize how this rule treats null literals. Possible values:
            • always (default) - Always use === or !==.
            • never - Never use === or !== with null.
            • ignore - Do not apply this rule to null.

          smart

          The "smart" option enforces the use of === and !== except for these cases:

          • Comparing two literal values
          • Evaluating the value of typeof
          • Comparing against null

          Examples of incorrect code for the "smart" option:

          /*eslint eqeqeq: ["error", "smart"]*/
          
          // comparing two variables requires ===
          a == b
          
          // only one side is a literal
          foo == true
          bananas != 1
          
          // comparing to undefined requires ===
          value == undefined

          Examples of correct code for the "smart" option:

          /*eslint eqeqeq: ["error", "smart"]*/
          
          typeof foo == 'undefined'
          'hello' != 'world'
          0 == 0
          true == true
          foo == null

          allow-null

          Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

          ["error", "always", {"null": "ignore"}]

          When Not To Use It

          If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

          Unexpected prompt.
          Open

               var msg = prompt('New name?', '');
          Severity: Minor
          Found in www/enyo/js/mainpanel.js by eslint

          Disallow Use of Alert (no-alert)

          JavaScript's alert, confirm, and prompt functions are widely considered to be obtrusive as UI elements and should be replaced by a more appropriate custom UI implementation. Furthermore, alert is often used while debugging code, which should be removed before deployment to production.

          alert("here!");

          Rule Details

          This rule is aimed at catching debugging code that should be removed and popup UI elements that should be replaced with less obtrusive, custom UIs. As such, it will warn when it encounters alert, prompt, and confirm function calls which are not shadowed.

          Examples of incorrect code for this rule:

          /*eslint no-alert: "error"*/
          
          alert("here!");
          
          confirm("Are you sure?");
          
          prompt("What's your name?", "John Doe");

          Examples of correct code for this rule:

          /*eslint no-alert: "error"*/
          
          customAlert("Something happened!");
          
          customConfirm("Are you sure?");
          
          customPrompt("Who are you?");
          
          function foo() {
              var alert = myCustomLib.customAlert;
              alert();
          }

          Related Rules

          Unexpected prompt.
          Open

               var msg = prompt('Flag name?', '');
          Severity: Minor
          Found in www/enyo/js/mainpanel.js by eslint

          Disallow Use of Alert (no-alert)

          JavaScript's alert, confirm, and prompt functions are widely considered to be obtrusive as UI elements and should be replaced by a more appropriate custom UI implementation. Furthermore, alert is often used while debugging code, which should be removed before deployment to production.

          alert("here!");

          Rule Details

          This rule is aimed at catching debugging code that should be removed and popup UI elements that should be replaced with less obtrusive, custom UIs. As such, it will warn when it encounters alert, prompt, and confirm function calls which are not shadowed.

          Examples of incorrect code for this rule:

          /*eslint no-alert: "error"*/
          
          alert("here!");
          
          confirm("Are you sure?");
          
          prompt("What's your name?", "John Doe");

          Examples of correct code for this rule:

          /*eslint no-alert: "error"*/
          
          customAlert("Something happened!");
          
          customConfirm("Are you sure?");
          
          customPrompt("Who are you?");
          
          function foo() {
              var alert = myCustomLib.customAlert;
              alert();
          }

          Related Rules

          Duplicate key 'classes'.
          Open

              classes: 'enyo-fit',
          Severity: Minor
          Found in www/enyo/js/mainpanel.js by eslint

          disallow duplicate keys in object literals (no-dupe-keys)

          Multiple properties with the same key in object literals can cause unexpected behavior in your application.

          var foo = {
              bar: "baz",
              bar: "qux"
          };

          Rule Details

          This rule disallows duplicate keys in object literals.

          Examples of incorrect code for this rule:

          /*eslint no-dupe-keys: "error"*/
          
          var foo = {
              bar: "baz",
              bar: "qux"
          };
          
          var foo = {
              "bar": "baz",
              bar: "qux"
          };
          
          var foo = {
              0x1: "baz",
              1: "qux"
          };

          Examples of correct code for this rule:

          /*eslint no-dupe-keys: "error"*/
          
          var foo = {
              bar: "baz",
              quxx: "qux"
          };

          Source: http://eslint.org/docs/rules/

          Unexpected prompt.
          Open

               var msg = prompt('Opcode', '');
          Severity: Minor
          Found in www/enyo/js/mainpanel.js by eslint

          Disallow Use of Alert (no-alert)

          JavaScript's alert, confirm, and prompt functions are widely considered to be obtrusive as UI elements and should be replaced by a more appropriate custom UI implementation. Furthermore, alert is often used while debugging code, which should be removed before deployment to production.

          alert("here!");

          Rule Details

          This rule is aimed at catching debugging code that should be removed and popup UI elements that should be replaced with less obtrusive, custom UIs. As such, it will warn when it encounters alert, prompt, and confirm function calls which are not shadowed.

          Examples of incorrect code for this rule:

          /*eslint no-alert: "error"*/
          
          alert("here!");
          
          confirm("Are you sure?");
          
          prompt("What's your name?", "John Doe");

          Examples of correct code for this rule:

          /*eslint no-alert: "error"*/
          
          customAlert("Something happened!");
          
          customConfirm("Are you sure?");
          
          customPrompt("Who are you?");
          
          function foo() {
              var alert = myCustomLib.customAlert;
              alert();
          }

          Related Rules

          Unexpected prompt.
          Open

               var msg = prompt('Comment?', '');
          Severity: Minor
          Found in www/enyo/js/mainpanel.js by eslint

          Disallow Use of Alert (no-alert)

          JavaScript's alert, confirm, and prompt functions are widely considered to be obtrusive as UI elements and should be replaced by a more appropriate custom UI implementation. Furthermore, alert is often used while debugging code, which should be removed before deployment to production.

          alert("here!");

          Rule Details

          This rule is aimed at catching debugging code that should be removed and popup UI elements that should be replaced with less obtrusive, custom UIs. As such, it will warn when it encounters alert, prompt, and confirm function calls which are not shadowed.

          Examples of incorrect code for this rule:

          /*eslint no-alert: "error"*/
          
          alert("here!");
          
          confirm("Are you sure?");
          
          prompt("What's your name?", "John Doe");

          Examples of correct code for this rule:

          /*eslint no-alert: "error"*/
          
          customAlert("Something happened!");
          
          customConfirm("Are you sure?");
          
          customPrompt("Who are you?");
          
          function foo() {
              var alert = myCustomLib.customAlert;
              alert();
          }

          Related Rules

          Expected '===' and instead saw '=='.
          Open

                  if (r == -1) {
          Severity: Minor
          Found in www/enyo/js/mainpanel.js by eslint

          Require === and !== (eqeqeq)

          It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

          The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

          • [] == false
          • [] == ![]
          • 3 == "03"

          If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

          Rule Details

          This rule is aimed at eliminating the type-unsafe equality operators.

          Examples of incorrect code for this rule:

          /*eslint eqeqeq: "error"*/
          
          if (x == 42) { }
          
          if ("" == text) { }
          
          if (obj.getStuff() != undefined) { }

          The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

          Options

          always

          The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

          Examples of incorrect code for the "always" option:

          /*eslint eqeqeq: ["error", "always"]*/
          
          a == b
          foo == true
          bananas != 1
          value == undefined
          typeof foo == 'undefined'
          'hello' != 'world'
          0 == 0
          true == true
          foo == null

          Examples of correct code for the "always" option:

          /*eslint eqeqeq: ["error", "always"]*/
          
          a === b
          foo === true
          bananas !== 1
          value === undefined
          typeof foo === 'undefined'
          'hello' !== 'world'
          0 === 0
          true === true
          foo === null

          This rule optionally takes a second argument, which should be an object with the following supported properties:

          • "null": Customize how this rule treats null literals. Possible values:
            • always (default) - Always use === or !==.
            • never - Never use === or !== with null.
            • ignore - Do not apply this rule to null.

          smart

          The "smart" option enforces the use of === and !== except for these cases:

          • Comparing two literal values
          • Evaluating the value of typeof
          • Comparing against null

          Examples of incorrect code for the "smart" option:

          /*eslint eqeqeq: ["error", "smart"]*/
          
          // comparing two variables requires ===
          a == b
          
          // only one side is a literal
          foo == true
          bananas != 1
          
          // comparing to undefined requires ===
          value == undefined

          Examples of correct code for the "smart" option:

          /*eslint eqeqeq: ["error", "smart"]*/
          
          typeof foo == 'undefined'
          'hello' != 'world'
          0 == 0
          true == true
          foo == null

          allow-null

          Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

          ["error", "always", {"null": "ignore"}]

          When Not To Use It

          If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

          Unexpected alert.
          Open

                          alert(x);
          Severity: Minor
          Found in www/enyo/js/mainpanel.js by eslint

          Disallow Use of Alert (no-alert)

          JavaScript's alert, confirm, and prompt functions are widely considered to be obtrusive as UI elements and should be replaced by a more appropriate custom UI implementation. Furthermore, alert is often used while debugging code, which should be removed before deployment to production.

          alert("here!");

          Rule Details

          This rule is aimed at catching debugging code that should be removed and popup UI elements that should be replaced with less obtrusive, custom UIs. As such, it will warn when it encounters alert, prompt, and confirm function calls which are not shadowed.

          Examples of incorrect code for this rule:

          /*eslint no-alert: "error"*/
          
          alert("here!");
          
          confirm("Are you sure?");
          
          prompt("What's your name?", "John Doe");

          Examples of correct code for this rule:

          /*eslint no-alert: "error"*/
          
          customAlert("Something happened!");
          
          customConfirm("Are you sure?");
          
          customPrompt("Who are you?");
          
          function foo() {
              var alert = myCustomLib.customAlert;
              alert();
          }

          Related Rules

          Unexpected prompt.
          Open

               var msg = prompt('Text', '');
          Severity: Minor
          Found in www/enyo/js/mainpanel.js by eslint

          Disallow Use of Alert (no-alert)

          JavaScript's alert, confirm, and prompt functions are widely considered to be obtrusive as UI elements and should be replaced by a more appropriate custom UI implementation. Furthermore, alert is often used while debugging code, which should be removed before deployment to production.

          alert("here!");

          Rule Details

          This rule is aimed at catching debugging code that should be removed and popup UI elements that should be replaced with less obtrusive, custom UIs. As such, it will warn when it encounters alert, prompt, and confirm function calls which are not shadowed.

          Examples of incorrect code for this rule:

          /*eslint no-alert: "error"*/
          
          alert("here!");
          
          confirm("Are you sure?");
          
          prompt("What's your name?", "John Doe");

          Examples of correct code for this rule:

          /*eslint no-alert: "error"*/
          
          customAlert("Something happened!");
          
          customConfirm("Are you sure?");
          
          customPrompt("Who are you?");
          
          function foo() {
              var alert = myCustomLib.customAlert;
              alert();
          }

          Related Rules

          Unexpected prompt.
          Open

               var msg = prompt('How many bytes?', '');
          Severity: Minor
          Found in www/enyo/js/mainpanel.js by eslint

          Disallow Use of Alert (no-alert)

          JavaScript's alert, confirm, and prompt functions are widely considered to be obtrusive as UI elements and should be replaced by a more appropriate custom UI implementation. Furthermore, alert is often used while debugging code, which should be removed before deployment to production.

          alert("here!");

          Rule Details

          This rule is aimed at catching debugging code that should be removed and popup UI elements that should be replaced with less obtrusive, custom UIs. As such, it will warn when it encounters alert, prompt, and confirm function calls which are not shadowed.

          Examples of incorrect code for this rule:

          /*eslint no-alert: "error"*/
          
          alert("here!");
          
          confirm("Are you sure?");
          
          prompt("What's your name?", "John Doe");

          Examples of correct code for this rule:

          /*eslint no-alert: "error"*/
          
          customAlert("Something happened!");
          
          customConfirm("Are you sure?");
          
          customPrompt("Who are you?");
          
          function foo() {
              var alert = myCustomLib.customAlert;
              alert();
          }

          Related Rules

          Unexpected prompt.
          Open

                  var project_name = prompt('Project Name:', r2.project_name);
          Severity: Minor
          Found in www/enyo/js/mainpanel.js by eslint

          Disallow Use of Alert (no-alert)

          JavaScript's alert, confirm, and prompt functions are widely considered to be obtrusive as UI elements and should be replaced by a more appropriate custom UI implementation. Furthermore, alert is often used while debugging code, which should be removed before deployment to production.

          alert("here!");

          Rule Details

          This rule is aimed at catching debugging code that should be removed and popup UI elements that should be replaced with less obtrusive, custom UIs. As such, it will warn when it encounters alert, prompt, and confirm function calls which are not shadowed.

          Examples of incorrect code for this rule:

          /*eslint no-alert: "error"*/
          
          alert("here!");
          
          confirm("Are you sure?");
          
          prompt("What's your name?", "John Doe");

          Examples of correct code for this rule:

          /*eslint no-alert: "error"*/
          
          customAlert("Something happened!");
          
          customConfirm("Are you sure?");
          
          customPrompt("Who are you?");
          
          function foo() {
              var alert = myCustomLib.customAlert;
              alert();
          }

          Related Rules

          Unexpected prompt.
          Open

               var msg = prompt('Filename', '');
          Severity: Minor
          Found in www/enyo/js/mainpanel.js by eslint

          Disallow Use of Alert (no-alert)

          JavaScript's alert, confirm, and prompt functions are widely considered to be obtrusive as UI elements and should be replaced by a more appropriate custom UI implementation. Furthermore, alert is often used while debugging code, which should be removed before deployment to production.

          alert("here!");

          Rule Details

          This rule is aimed at catching debugging code that should be removed and popup UI elements that should be replaced with less obtrusive, custom UIs. As such, it will warn when it encounters alert, prompt, and confirm function calls which are not shadowed.

          Examples of incorrect code for this rule:

          /*eslint no-alert: "error"*/
          
          alert("here!");
          
          confirm("Are you sure?");
          
          prompt("What's your name?", "John Doe");

          Examples of correct code for this rule:

          /*eslint no-alert: "error"*/
          
          customAlert("Something happened!");
          
          customConfirm("Are you sure?");
          
          customPrompt("Who are you?");
          
          function foo() {
              var alert = myCustomLib.customAlert;
              alert();
          }

          Related Rules

          TODO found
          Open

                  // TODO: this is just a hack
          Severity: Minor
          Found in www/enyo/js/mainpanel.js by fixme

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      this.$.panels.createComponents([
                          {kind: 'Disassembler', name: 'pageDisassembler'},
                          {kind: 'Assembler', name: 'pageAssembler'},
                          {kind: 'Hexdump', name: 'pageHexdump'},
                          {kind: 'Graph', name: 'pageGraph'},
          Severity: Major
          Found in www/enyo/js/mainpanel.js and 1 other location - About 5 hrs to fix
          www/enyo/js/mainpanel.js on lines 222..234

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 152.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      this.$.panels.createComponents([
                          {kind: 'DisassemblerOld', name: 'pageDisassembler'},
                          {kind: 'Assembler', name: 'pageAssembler'},
                          {kind: 'Hexdump', name: 'pageHexdump'},
                          {kind: 'Graph', name: 'pageGraph'},
          Severity: Major
          Found in www/enyo/js/mainpanel.js and 1 other location - About 5 hrs to fix
          www/enyo/js/mainpanel.js on lines 238..250

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 152.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                              {kind: 'onyx.Picker', name: 'actionsPicker', components: [
                                  {content: 'Analyze', ontap: 'goAnalyze'},
                                  {content: 'Rename', ontap: 'goRename'},
                                  {content: 'Comment', ontap: 'goComment'},
                                  {content: 'Flag', ontap: 'goFlag'},
          Severity: Major
          Found in www/enyo/js/mainpanel.js and 1 other location - About 2 hrs to fix
          www/p/lib/js/panels/disasm_panel.js on lines 34..42

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 90.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              goRename: function() {
               var msg = prompt('New name?', '');
               if (msg)
                   r2.cmd('afr ' + msg, function() {
                       r2ui.seek('$$', false);
          Severity: Major
          Found in www/enyo/js/mainpanel.js and 2 other locations - About 1 hr to fix
          www/enyo/js/mainpanel.js on lines 77..83
          www/enyo/js/mainpanel.js on lines 106..112

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              coCode: function() {
               var msg = prompt('How many bytes?', '');
               if (msg)
               r2.cmd('y ' + msg, function() {
                   r2ui.seek('$$', false);
          Severity: Major
          Found in www/enyo/js/mainpanel.js and 2 other locations - About 1 hr to fix
          www/enyo/js/mainpanel.js on lines 30..36
          www/enyo/js/mainpanel.js on lines 77..83

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              wrString: function() {
               var msg = prompt('Text', '');
               if (msg)
               r2.cmd('w ' + msg, function() {
                   r2ui.seek('$$', false);
          Severity: Major
          Found in www/enyo/js/mainpanel.js and 2 other locations - About 1 hr to fix
          www/enyo/js/mainpanel.js on lines 30..36
          www/enyo/js/mainpanel.js on lines 106..112

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

              wrOpcode: function() {
               var msg = prompt('Opcode', '');
               if (msg)
               r2.cmd('wa ' + msg, function() {
                   r2ui.seek('$$', false);
          Severity: Major
          Found in www/enyo/js/mainpanel.js and 4 other locations - About 1 hr to fix
          www/enyo/js/mainpanel.js on lines 37..43
          www/enyo/js/mainpanel.js on lines 91..97
          www/enyo/js/mainpanel.js on lines 98..104
          www/enyo/js/mainpanel.js on lines 118..124

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

              goComment: function() {
               var msg = prompt('Comment?', '');
               if (msg)
                   r2.cmd('CC ' + msg, function() {
                       r2ui.seek('$$', false);
          Severity: Major
          Found in www/enyo/js/mainpanel.js and 4 other locations - About 1 hr to fix
          www/enyo/js/mainpanel.js on lines 84..90
          www/enyo/js/mainpanel.js on lines 91..97
          www/enyo/js/mainpanel.js on lines 98..104
          www/enyo/js/mainpanel.js on lines 118..124

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

              wrFile: function() {
               var msg = prompt('Filename', '');
               if (msg)
               r2.cmd('wf ' + msg, function() {
                   r2ui.seek('$$', false);
          Severity: Major
          Found in www/enyo/js/mainpanel.js and 4 other locations - About 1 hr to fix
          www/enyo/js/mainpanel.js on lines 37..43
          www/enyo/js/mainpanel.js on lines 84..90
          www/enyo/js/mainpanel.js on lines 98..104
          www/enyo/js/mainpanel.js on lines 118..124

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

              wrHex: function() {
               var msg = prompt('Hexpair', '');
               if (msg)
               r2.cmd('wx ' + msg, function() {
                   r2ui.seek('$$', false);
          Severity: Major
          Found in www/enyo/js/mainpanel.js and 4 other locations - About 1 hr to fix
          www/enyo/js/mainpanel.js on lines 37..43
          www/enyo/js/mainpanel.js on lines 84..90
          www/enyo/js/mainpanel.js on lines 91..97
          www/enyo/js/mainpanel.js on lines 118..124

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

              coData: function() {
               var msg = prompt('How many bytes?', '');
               if (msg)
               r2.cmd('Cd ' + msg, function() {
                   r2ui.seek('$$', false);
          Severity: Major
          Found in www/enyo/js/mainpanel.js and 4 other locations - About 1 hr to fix
          www/enyo/js/mainpanel.js on lines 37..43
          www/enyo/js/mainpanel.js on lines 84..90
          www/enyo/js/mainpanel.js on lines 91..97
          www/enyo/js/mainpanel.js on lines 98..104

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          {kind: 'onyx.Picker', components: [
                              {content: 'File', ontap: 'wrFile'},
                              {content: 'Hexpair', ontap: 'wrHex'},
                              {content: 'String', ontap: 'wrString'},
                              {content: 'Opcode', ontap: 'wrOpcode'}
          Severity: Minor
          Found in www/enyo/js/mainpanel.js and 1 other location - About 55 mins to fix
          www/enyo/js/disassembler.js on lines 32..37

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              goAnalyze: function() {
               r2.cmd('af', function() {
                      r2.update_flags();
                      r2ui.seek('$$', false);
               });
          Severity: Minor
          Found in www/enyo/js/mainpanel.js and 1 other location - About 40 mins to fix
          www/enyo/js/mainpanel.js on lines 52..57

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              goUnflag: function() {
               r2.cmd('f-$$', function() {
                   r2.update_flags();
                   r2ui.seek('$$', false);
               });
          Severity: Minor
          Found in www/enyo/js/mainpanel.js and 1 other location - About 40 mins to fix
          www/enyo/js/mainpanel.js on lines 58..63

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status