radare/radare2-webui

View on GitHub
www/m/js/helpers/ui.legacy.js

Summary

Maintainability
A
1 hr
Test Coverage

Function uiSelect has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function uiSelect(dom, name, list, defaultOffset, onChange) {
    var id = 'select-' + (++selectId);

    var div = document.createElement('div');
    div.className = 'mdl-selectfield mdl-js-selectfield mdl-selectfield--floating-label';
Severity: Minor
Found in www/m/js/helpers/ui.legacy.js - About 1 hr to fix

    Function uiSelect has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function uiSelect(dom, name, list, defaultOffset, onChange) {
    Severity: Minor
    Found in www/m/js/helpers/ui.legacy.js - About 35 mins to fix

      Missing JSDoc comment.
      Open

      function uiRoundButton(a, b, c) {
      Severity: Minor
      Found in www/m/js/helpers/ui.legacy.js by eslint

      require JSDoc comments (require-jsdoc)

      JSDoc is a JavaScript API documentation generator. It uses specially-formatted comments inside of code to generate API documentation automatically. For example, this is what a JSDoc comment looks like for a function:

      /**
       * Adds two numbers together.
       * @param {int} num1 The first number.
       * @param {int} num2 The second number.
       * @returns {int} The sum of the two numbers.
       */
      function sum(num1, num2) {
          return num1 + num2;
      }

      Some style guides require JSDoc comments for all functions as a way of explaining function behavior.

      Rule Details

      This rule requires JSDoc comments for specified nodes. Supported nodes:

      • "FunctionDeclaration"
      • "ClassDeclaration"
      • "MethodDefinition"
      • "ArrowFunctionExpression"

      Options

      This rule has a single object option:

      • "require" requires JSDoc comments for the specified nodes

      Default option settings are:

      {
          "require-jsdoc": ["error", {
              "require": {
                  "FunctionDeclaration": true,
                  "MethodDefinition": false,
                  "ClassDeclaration": false,
                  "ArrowFunctionExpression": false
              }
          }]
      }

      require

      Examples of incorrect code for this rule with the { "require": { "FunctionDeclaration": true, "MethodDefinition": true, "ClassDeclaration": true, "ArrowFunctionExpression": true } } option:

      /*eslint "require-jsdoc": ["error", {
          "require": {
              "FunctionDeclaration": true,
              "MethodDefinition": true,
              "ClassDeclaration": true
          }
      }]*/
      
      function foo() {
          return 10;
      }
      
      var foo = () => {
          return 10;
      }
      
      class Test{
          getDate(){}
      }

      Examples of correct code for this rule with the { "require": { "FunctionDeclaration": true, "MethodDefinition": true, "ClassDeclaration": true, "ArrowFunctionExpression": true } } option:

      /*eslint "require-jsdoc": ["error", {
          "require": {
              "FunctionDeclaration": true,
              "MethodDefinition": true,
              "ClassDeclaration": true
          }
      }]*/
      
      /**
       * It returns 10
       */
      function foo() {
          return 10;
      }
      
      /**
       * It returns test + 10
       * @params {int} test - some number
       * @returns {int} sum of test and 10
       */
      var foo = (test) => {
          return test + 10;
      }
      
      /**
       * It returns 10
       */
      var foo = () => {
          return 10;
      }
      
      /**
       * It returns 10
       */
      var foo = function() {
          return 10;
      }
      
      var array = [1,2,3];
      array.filter(function(item) {
          return item > 2;
      });
      
      /**
       * It returns 10
       */
      class Test{
          /**
          * returns the date
          */
          getDate(){}
      }
      
      setTimeout(() => {}, 10); // since it's an anonymous arrow function

      When Not To Use It

      If you do not require JSDoc for your functions, then you can leave this rule off.

      Related Rules

      Missing JSDoc comment.
      Open

      function uiCheckList(grp, id, label) {
      Severity: Minor
      Found in www/m/js/helpers/ui.legacy.js by eslint

      require JSDoc comments (require-jsdoc)

      JSDoc is a JavaScript API documentation generator. It uses specially-formatted comments inside of code to generate API documentation automatically. For example, this is what a JSDoc comment looks like for a function:

      /**
       * Adds two numbers together.
       * @param {int} num1 The first number.
       * @param {int} num2 The second number.
       * @returns {int} The sum of the two numbers.
       */
      function sum(num1, num2) {
          return num1 + num2;
      }

      Some style guides require JSDoc comments for all functions as a way of explaining function behavior.

      Rule Details

      This rule requires JSDoc comments for specified nodes. Supported nodes:

      • "FunctionDeclaration"
      • "ClassDeclaration"
      • "MethodDefinition"
      • "ArrowFunctionExpression"

      Options

      This rule has a single object option:

      • "require" requires JSDoc comments for the specified nodes

      Default option settings are:

      {
          "require-jsdoc": ["error", {
              "require": {
                  "FunctionDeclaration": true,
                  "MethodDefinition": false,
                  "ClassDeclaration": false,
                  "ArrowFunctionExpression": false
              }
          }]
      }

      require

      Examples of incorrect code for this rule with the { "require": { "FunctionDeclaration": true, "MethodDefinition": true, "ClassDeclaration": true, "ArrowFunctionExpression": true } } option:

      /*eslint "require-jsdoc": ["error", {
          "require": {
              "FunctionDeclaration": true,
              "MethodDefinition": true,
              "ClassDeclaration": true
          }
      }]*/
      
      function foo() {
          return 10;
      }
      
      var foo = () => {
          return 10;
      }
      
      class Test{
          getDate(){}
      }

      Examples of correct code for this rule with the { "require": { "FunctionDeclaration": true, "MethodDefinition": true, "ClassDeclaration": true, "ArrowFunctionExpression": true } } option:

      /*eslint "require-jsdoc": ["error", {
          "require": {
              "FunctionDeclaration": true,
              "MethodDefinition": true,
              "ClassDeclaration": true
          }
      }]*/
      
      /**
       * It returns 10
       */
      function foo() {
          return 10;
      }
      
      /**
       * It returns test + 10
       * @params {int} test - some number
       * @returns {int} sum of test and 10
       */
      var foo = (test) => {
          return test + 10;
      }
      
      /**
       * It returns 10
       */
      var foo = () => {
          return 10;
      }
      
      /**
       * It returns 10
       */
      var foo = function() {
          return 10;
      }
      
      var array = [1,2,3];
      array.filter(function(item) {
          return item > 2;
      });
      
      /**
       * It returns 10
       */
      class Test{
          /**
          * returns the date
          */
          getDate(){}
      }
      
      setTimeout(() => {}, 10); // since it's an anonymous arrow function

      When Not To Use It

      If you do not require JSDoc for your functions, then you can leave this rule off.

      Related Rules

      Missing JSDoc comment.
      Open

      function uiButton(href, label, type) {
      Severity: Minor
      Found in www/m/js/helpers/ui.legacy.js by eslint

      require JSDoc comments (require-jsdoc)

      JSDoc is a JavaScript API documentation generator. It uses specially-formatted comments inside of code to generate API documentation automatically. For example, this is what a JSDoc comment looks like for a function:

      /**
       * Adds two numbers together.
       * @param {int} num1 The first number.
       * @param {int} num2 The second number.
       * @returns {int} The sum of the two numbers.
       */
      function sum(num1, num2) {
          return num1 + num2;
      }

      Some style guides require JSDoc comments for all functions as a way of explaining function behavior.

      Rule Details

      This rule requires JSDoc comments for specified nodes. Supported nodes:

      • "FunctionDeclaration"
      • "ClassDeclaration"
      • "MethodDefinition"
      • "ArrowFunctionExpression"

      Options

      This rule has a single object option:

      • "require" requires JSDoc comments for the specified nodes

      Default option settings are:

      {
          "require-jsdoc": ["error", {
              "require": {
                  "FunctionDeclaration": true,
                  "MethodDefinition": false,
                  "ClassDeclaration": false,
                  "ArrowFunctionExpression": false
              }
          }]
      }

      require

      Examples of incorrect code for this rule with the { "require": { "FunctionDeclaration": true, "MethodDefinition": true, "ClassDeclaration": true, "ArrowFunctionExpression": true } } option:

      /*eslint "require-jsdoc": ["error", {
          "require": {
              "FunctionDeclaration": true,
              "MethodDefinition": true,
              "ClassDeclaration": true
          }
      }]*/
      
      function foo() {
          return 10;
      }
      
      var foo = () => {
          return 10;
      }
      
      class Test{
          getDate(){}
      }

      Examples of correct code for this rule with the { "require": { "FunctionDeclaration": true, "MethodDefinition": true, "ClassDeclaration": true, "ArrowFunctionExpression": true } } option:

      /*eslint "require-jsdoc": ["error", {
          "require": {
              "FunctionDeclaration": true,
              "MethodDefinition": true,
              "ClassDeclaration": true
          }
      }]*/
      
      /**
       * It returns 10
       */
      function foo() {
          return 10;
      }
      
      /**
       * It returns test + 10
       * @params {int} test - some number
       * @returns {int} sum of test and 10
       */
      var foo = (test) => {
          return test + 10;
      }
      
      /**
       * It returns 10
       */
      var foo = () => {
          return 10;
      }
      
      /**
       * It returns 10
       */
      var foo = function() {
          return 10;
      }
      
      var array = [1,2,3];
      array.filter(function(item) {
          return item > 2;
      });
      
      /**
       * It returns 10
       */
      class Test{
          /**
          * returns the date
          */
          getDate(){}
      }
      
      setTimeout(() => {}, 10); // since it's an anonymous arrow function

      When Not To Use It

      If you do not require JSDoc for your functions, then you can leave this rule off.

      Related Rules

      Missing JSDoc comment.
      Open

      function uiBlock(d) {
      Severity: Minor
      Found in www/m/js/helpers/ui.legacy.js by eslint

      require JSDoc comments (require-jsdoc)

      JSDoc is a JavaScript API documentation generator. It uses specially-formatted comments inside of code to generate API documentation automatically. For example, this is what a JSDoc comment looks like for a function:

      /**
       * Adds two numbers together.
       * @param {int} num1 The first number.
       * @param {int} num2 The second number.
       * @returns {int} The sum of the two numbers.
       */
      function sum(num1, num2) {
          return num1 + num2;
      }

      Some style guides require JSDoc comments for all functions as a way of explaining function behavior.

      Rule Details

      This rule requires JSDoc comments for specified nodes. Supported nodes:

      • "FunctionDeclaration"
      • "ClassDeclaration"
      • "MethodDefinition"
      • "ArrowFunctionExpression"

      Options

      This rule has a single object option:

      • "require" requires JSDoc comments for the specified nodes

      Default option settings are:

      {
          "require-jsdoc": ["error", {
              "require": {
                  "FunctionDeclaration": true,
                  "MethodDefinition": false,
                  "ClassDeclaration": false,
                  "ArrowFunctionExpression": false
              }
          }]
      }

      require

      Examples of incorrect code for this rule with the { "require": { "FunctionDeclaration": true, "MethodDefinition": true, "ClassDeclaration": true, "ArrowFunctionExpression": true } } option:

      /*eslint "require-jsdoc": ["error", {
          "require": {
              "FunctionDeclaration": true,
              "MethodDefinition": true,
              "ClassDeclaration": true
          }
      }]*/
      
      function foo() {
          return 10;
      }
      
      var foo = () => {
          return 10;
      }
      
      class Test{
          getDate(){}
      }

      Examples of correct code for this rule with the { "require": { "FunctionDeclaration": true, "MethodDefinition": true, "ClassDeclaration": true, "ArrowFunctionExpression": true } } option:

      /*eslint "require-jsdoc": ["error", {
          "require": {
              "FunctionDeclaration": true,
              "MethodDefinition": true,
              "ClassDeclaration": true
          }
      }]*/
      
      /**
       * It returns 10
       */
      function foo() {
          return 10;
      }
      
      /**
       * It returns test + 10
       * @params {int} test - some number
       * @returns {int} sum of test and 10
       */
      var foo = (test) => {
          return test + 10;
      }
      
      /**
       * It returns 10
       */
      var foo = () => {
          return 10;
      }
      
      /**
       * It returns 10
       */
      var foo = function() {
          return 10;
      }
      
      var array = [1,2,3];
      array.filter(function(item) {
          return item > 2;
      });
      
      /**
       * It returns 10
       */
      class Test{
          /**
          * returns the date
          */
          getDate(){}
      }
      
      setTimeout(() => {}, 10); // since it's an anonymous arrow function

      When Not To Use It

      If you do not require JSDoc for your functions, then you can leave this rule off.

      Related Rules

      Missing JSDoc comment.
      Open

      function uiCombo(d) {
      Severity: Minor
      Found in www/m/js/helpers/ui.legacy.js by eslint

      require JSDoc comments (require-jsdoc)

      JSDoc is a JavaScript API documentation generator. It uses specially-formatted comments inside of code to generate API documentation automatically. For example, this is what a JSDoc comment looks like for a function:

      /**
       * Adds two numbers together.
       * @param {int} num1 The first number.
       * @param {int} num2 The second number.
       * @returns {int} The sum of the two numbers.
       */
      function sum(num1, num2) {
          return num1 + num2;
      }

      Some style guides require JSDoc comments for all functions as a way of explaining function behavior.

      Rule Details

      This rule requires JSDoc comments for specified nodes. Supported nodes:

      • "FunctionDeclaration"
      • "ClassDeclaration"
      • "MethodDefinition"
      • "ArrowFunctionExpression"

      Options

      This rule has a single object option:

      • "require" requires JSDoc comments for the specified nodes

      Default option settings are:

      {
          "require-jsdoc": ["error", {
              "require": {
                  "FunctionDeclaration": true,
                  "MethodDefinition": false,
                  "ClassDeclaration": false,
                  "ArrowFunctionExpression": false
              }
          }]
      }

      require

      Examples of incorrect code for this rule with the { "require": { "FunctionDeclaration": true, "MethodDefinition": true, "ClassDeclaration": true, "ArrowFunctionExpression": true } } option:

      /*eslint "require-jsdoc": ["error", {
          "require": {
              "FunctionDeclaration": true,
              "MethodDefinition": true,
              "ClassDeclaration": true
          }
      }]*/
      
      function foo() {
          return 10;
      }
      
      var foo = () => {
          return 10;
      }
      
      class Test{
          getDate(){}
      }

      Examples of correct code for this rule with the { "require": { "FunctionDeclaration": true, "MethodDefinition": true, "ClassDeclaration": true, "ArrowFunctionExpression": true } } option:

      /*eslint "require-jsdoc": ["error", {
          "require": {
              "FunctionDeclaration": true,
              "MethodDefinition": true,
              "ClassDeclaration": true
          }
      }]*/
      
      /**
       * It returns 10
       */
      function foo() {
          return 10;
      }
      
      /**
       * It returns test + 10
       * @params {int} test - some number
       * @returns {int} sum of test and 10
       */
      var foo = (test) => {
          return test + 10;
      }
      
      /**
       * It returns 10
       */
      var foo = () => {
          return 10;
      }
      
      /**
       * It returns 10
       */
      var foo = function() {
          return 10;
      }
      
      var array = [1,2,3];
      array.filter(function(item) {
          return item > 2;
      });
      
      /**
       * It returns 10
       */
      class Test{
          /**
          * returns the date
          */
          getDate(){}
      }
      
      setTimeout(() => {}, 10); // since it's an anonymous arrow function

      When Not To Use It

      If you do not require JSDoc for your functions, then you can leave this rule off.

      Related Rules

      Missing JSDoc comment.
      Open

      function uiSelect(dom, name, list, defaultOffset, onChange) {
      Severity: Minor
      Found in www/m/js/helpers/ui.legacy.js by eslint

      require JSDoc comments (require-jsdoc)

      JSDoc is a JavaScript API documentation generator. It uses specially-formatted comments inside of code to generate API documentation automatically. For example, this is what a JSDoc comment looks like for a function:

      /**
       * Adds two numbers together.
       * @param {int} num1 The first number.
       * @param {int} num2 The second number.
       * @returns {int} The sum of the two numbers.
       */
      function sum(num1, num2) {
          return num1 + num2;
      }

      Some style guides require JSDoc comments for all functions as a way of explaining function behavior.

      Rule Details

      This rule requires JSDoc comments for specified nodes. Supported nodes:

      • "FunctionDeclaration"
      • "ClassDeclaration"
      • "MethodDefinition"
      • "ArrowFunctionExpression"

      Options

      This rule has a single object option:

      • "require" requires JSDoc comments for the specified nodes

      Default option settings are:

      {
          "require-jsdoc": ["error", {
              "require": {
                  "FunctionDeclaration": true,
                  "MethodDefinition": false,
                  "ClassDeclaration": false,
                  "ArrowFunctionExpression": false
              }
          }]
      }

      require

      Examples of incorrect code for this rule with the { "require": { "FunctionDeclaration": true, "MethodDefinition": true, "ClassDeclaration": true, "ArrowFunctionExpression": true } } option:

      /*eslint "require-jsdoc": ["error", {
          "require": {
              "FunctionDeclaration": true,
              "MethodDefinition": true,
              "ClassDeclaration": true
          }
      }]*/
      
      function foo() {
          return 10;
      }
      
      var foo = () => {
          return 10;
      }
      
      class Test{
          getDate(){}
      }

      Examples of correct code for this rule with the { "require": { "FunctionDeclaration": true, "MethodDefinition": true, "ClassDeclaration": true, "ArrowFunctionExpression": true } } option:

      /*eslint "require-jsdoc": ["error", {
          "require": {
              "FunctionDeclaration": true,
              "MethodDefinition": true,
              "ClassDeclaration": true
          }
      }]*/
      
      /**
       * It returns 10
       */
      function foo() {
          return 10;
      }
      
      /**
       * It returns test + 10
       * @params {int} test - some number
       * @returns {int} sum of test and 10
       */
      var foo = (test) => {
          return test + 10;
      }
      
      /**
       * It returns 10
       */
      var foo = () => {
          return 10;
      }
      
      /**
       * It returns 10
       */
      var foo = function() {
          return 10;
      }
      
      var array = [1,2,3];
      array.filter(function(item) {
          return item > 2;
      });
      
      /**
       * It returns 10
       */
      class Test{
          /**
          * returns the date
          */
          getDate(){}
      }
      
      setTimeout(() => {}, 10); // since it's an anonymous arrow function

      When Not To Use It

      If you do not require JSDoc for your functions, then you can leave this rule off.

      Related Rules

      Missing JSDoc comment.
      Open

      function uiActionButton(dom, action, label) {
      Severity: Minor
      Found in www/m/js/helpers/ui.legacy.js by eslint

      require JSDoc comments (require-jsdoc)

      JSDoc is a JavaScript API documentation generator. It uses specially-formatted comments inside of code to generate API documentation automatically. For example, this is what a JSDoc comment looks like for a function:

      /**
       * Adds two numbers together.
       * @param {int} num1 The first number.
       * @param {int} num2 The second number.
       * @returns {int} The sum of the two numbers.
       */
      function sum(num1, num2) {
          return num1 + num2;
      }

      Some style guides require JSDoc comments for all functions as a way of explaining function behavior.

      Rule Details

      This rule requires JSDoc comments for specified nodes. Supported nodes:

      • "FunctionDeclaration"
      • "ClassDeclaration"
      • "MethodDefinition"
      • "ArrowFunctionExpression"

      Options

      This rule has a single object option:

      • "require" requires JSDoc comments for the specified nodes

      Default option settings are:

      {
          "require-jsdoc": ["error", {
              "require": {
                  "FunctionDeclaration": true,
                  "MethodDefinition": false,
                  "ClassDeclaration": false,
                  "ArrowFunctionExpression": false
              }
          }]
      }

      require

      Examples of incorrect code for this rule with the { "require": { "FunctionDeclaration": true, "MethodDefinition": true, "ClassDeclaration": true, "ArrowFunctionExpression": true } } option:

      /*eslint "require-jsdoc": ["error", {
          "require": {
              "FunctionDeclaration": true,
              "MethodDefinition": true,
              "ClassDeclaration": true
          }
      }]*/
      
      function foo() {
          return 10;
      }
      
      var foo = () => {
          return 10;
      }
      
      class Test{
          getDate(){}
      }

      Examples of correct code for this rule with the { "require": { "FunctionDeclaration": true, "MethodDefinition": true, "ClassDeclaration": true, "ArrowFunctionExpression": true } } option:

      /*eslint "require-jsdoc": ["error", {
          "require": {
              "FunctionDeclaration": true,
              "MethodDefinition": true,
              "ClassDeclaration": true
          }
      }]*/
      
      /**
       * It returns 10
       */
      function foo() {
          return 10;
      }
      
      /**
       * It returns test + 10
       * @params {int} test - some number
       * @returns {int} sum of test and 10
       */
      var foo = (test) => {
          return test + 10;
      }
      
      /**
       * It returns 10
       */
      var foo = () => {
          return 10;
      }
      
      /**
       * It returns 10
       */
      var foo = function() {
          return 10;
      }
      
      var array = [1,2,3];
      array.filter(function(item) {
          return item > 2;
      });
      
      /**
       * It returns 10
       */
      class Test{
          /**
          * returns the date
          */
          getDate(){}
      }
      
      setTimeout(() => {}, 10); // since it's an anonymous arrow function

      When Not To Use It

      If you do not require JSDoc for your functions, then you can leave this rule off.

      Related Rules

      Missing JSDoc comment.
      Open

      function uiSwitch(dom, name, isChecked, onChange) {
      Severity: Minor
      Found in www/m/js/helpers/ui.legacy.js by eslint

      require JSDoc comments (require-jsdoc)

      JSDoc is a JavaScript API documentation generator. It uses specially-formatted comments inside of code to generate API documentation automatically. For example, this is what a JSDoc comment looks like for a function:

      /**
       * Adds two numbers together.
       * @param {int} num1 The first number.
       * @param {int} num2 The second number.
       * @returns {int} The sum of the two numbers.
       */
      function sum(num1, num2) {
          return num1 + num2;
      }

      Some style guides require JSDoc comments for all functions as a way of explaining function behavior.

      Rule Details

      This rule requires JSDoc comments for specified nodes. Supported nodes:

      • "FunctionDeclaration"
      • "ClassDeclaration"
      • "MethodDefinition"
      • "ArrowFunctionExpression"

      Options

      This rule has a single object option:

      • "require" requires JSDoc comments for the specified nodes

      Default option settings are:

      {
          "require-jsdoc": ["error", {
              "require": {
                  "FunctionDeclaration": true,
                  "MethodDefinition": false,
                  "ClassDeclaration": false,
                  "ArrowFunctionExpression": false
              }
          }]
      }

      require

      Examples of incorrect code for this rule with the { "require": { "FunctionDeclaration": true, "MethodDefinition": true, "ClassDeclaration": true, "ArrowFunctionExpression": true } } option:

      /*eslint "require-jsdoc": ["error", {
          "require": {
              "FunctionDeclaration": true,
              "MethodDefinition": true,
              "ClassDeclaration": true
          }
      }]*/
      
      function foo() {
          return 10;
      }
      
      var foo = () => {
          return 10;
      }
      
      class Test{
          getDate(){}
      }

      Examples of correct code for this rule with the { "require": { "FunctionDeclaration": true, "MethodDefinition": true, "ClassDeclaration": true, "ArrowFunctionExpression": true } } option:

      /*eslint "require-jsdoc": ["error", {
          "require": {
              "FunctionDeclaration": true,
              "MethodDefinition": true,
              "ClassDeclaration": true
          }
      }]*/
      
      /**
       * It returns 10
       */
      function foo() {
          return 10;
      }
      
      /**
       * It returns test + 10
       * @params {int} test - some number
       * @returns {int} sum of test and 10
       */
      var foo = (test) => {
          return test + 10;
      }
      
      /**
       * It returns 10
       */
      var foo = () => {
          return 10;
      }
      
      /**
       * It returns 10
       */
      var foo = function() {
          return 10;
      }
      
      var array = [1,2,3];
      array.filter(function(item) {
          return item > 2;
      });
      
      /**
       * It returns 10
       */
      class Test{
          /**
          * returns the date
          */
          getDate(){}
      }
      
      setTimeout(() => {}, 10); // since it's an anonymous arrow function

      When Not To Use It

      If you do not require JSDoc for your functions, then you can leave this rule off.

      Related Rules

      TODO found
      Open

      //     // TODO: not yet done
      Severity: Minor
      Found in www/m/js/helpers/ui.legacy.js by fixme

      There are no issues that match your filters.

      Category
      Status