Sign upLogin

radare/radare2-webui

View on GitHub
Star
www/p/lib/js/panels/projects_panel.js

Summary

Maintainability
A
1 hr
Test Coverage

Function render has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

ProjectsPanel.prototype.render = function() {
    $('#projects_tab').html('<div><div style="color: white;">Open Project:</div><div id="projects" style="color:rgb(127,127,127);"></div><div id="button"><br/><input id="submit" type="submit" value="Save Project" /></div></div>');
    r2.cmdj('Plj', function(projects) {
        var data = [];
        for (var i in projects) {
Severity: Minor
Found in www/p/lib/js/panels/projects_panel.js - About 1 hr to fix

    Unexpected alert.
    Open

                    alert('Enter a valid name');
    Severity: Minor
    Found in www/p/lib/js/panels/projects_panel.js by eslint

    Disallow Use of Alert (no-alert)

    JavaScript's alert, confirm, and prompt functions are widely considered to be obtrusive as UI elements and should be replaced by a more appropriate custom UI implementation. Furthermore, alert is often used while debugging code, which should be removed before deployment to production.

    alert("here!");

    Rule Details

    This rule is aimed at catching debugging code that should be removed and popup UI elements that should be replaced with less obtrusive, custom UIs. As such, it will warn when it encounters alert, prompt, and confirm function calls which are not shadowed.

    Examples of incorrect code for this rule:

    /*eslint no-alert: "error"*/

alert("here!");

confirm("Are you sure?");

prompt("What's your name?", "John Doe");

    Examples of correct code for this rule:

    /*eslint no-alert: "error"*/

customAlert("Something happened!");

customConfirm("Are you sure?");

customPrompt("Who are you?");

function foo() {
    var alert = myCustomLib.customAlert;
    alert();
}

    Related Rules

    The body of a for-in should be wrapped in an if statement to filter unwanted properties from the prototype.
    Open

            for (var i in projects) {
    Severity: Minor
    Found in www/p/lib/js/panels/projects_panel.js by eslint

    Require Guarding for-in (guard-for-in)

    Looping over objects with a for in loop will include properties that are inherited through the prototype chain. This behavior can lead to unexpected items in your for loop.

    for (key in foo) {
    doSomething(key);
}

    Note that simply checking foo.hasOwnProperty(key) is likely to cause an error in some cases; see [no-prototype-builtins](no-prototype-builtins.md).

    Rule Details

    This rule is aimed at preventing unexpected behavior that could arise from using a for in loop without filtering the results in the loop. As such, it will warn when for in loops do not filter their results with an if statement.

    Examples of incorrect code for this rule:

    /*eslint guard-for-in: "error"*/

for (key in foo) {
    doSomething(key);
}

    Examples of correct code for this rule:

    /*eslint guard-for-in: "error"*/

for (key in foo) {
    if (Object.prototype.hasOwnProperty.call(foo, key)) {
        doSomething(key);
    }
    if ({}.hasOwnProperty.call(foo, key)) {
        doSomething(key);
    }
}

    Related Rules

    • [no-prototype-builtins](no-prototype-builtins.md)

    Further Reading

    Unexpected prompt.
    Open

                var project_name = prompt('Project Name:', r2.project_name);
    Severity: Minor
    Found in www/p/lib/js/panels/projects_panel.js by eslint

    Disallow Use of Alert (no-alert)

    JavaScript's alert, confirm, and prompt functions are widely considered to be obtrusive as UI elements and should be replaced by a more appropriate custom UI implementation. Furthermore, alert is often used while debugging code, which should be removed before deployment to production.

    alert("here!");

    Rule Details

    This rule is aimed at catching debugging code that should be removed and popup UI elements that should be replaced with less obtrusive, custom UIs. As such, it will warn when it encounters alert, prompt, and confirm function calls which are not shadowed.

    Examples of incorrect code for this rule:

    /*eslint no-alert: "error"*/

alert("here!");

confirm("Are you sure?");

prompt("What's your name?", "John Doe");

    Examples of correct code for this rule:

    /*eslint no-alert: "error"*/

customAlert("Something happened!");

customConfirm("Are you sure?");

customPrompt("Who are you?");

function foo() {
    var alert = myCustomLib.customAlert;
    alert();
}

    Related Rules

    There are no issues that match your filters.

    Category
    Status