radare/radare2-webui

View on GitHub
www/p/lib/js/panels/types_panel.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function insertData has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

TypesPanel.prototype.insertData = function(k, v, array) {
    if (typeof array === 'undefined') { array = this.data; };
    var kt = k[0].trim();

    if (k.length == 1) {
Severity: Minor
Found in www/p/lib/js/panels/types_panel.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function has a complexity of 9.
Open

TypesPanel.prototype.insertData = function(k, v, array) {
Severity: Minor
Found in www/p/lib/js/panels/types_panel.js by eslint

Limit Cyclomatic Complexity (complexity)

Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

function a(x) {
    if (true) {
        return x; // 1st path
    } else if (false) {
        return x+1; // 2nd path
    } else {
        return 4; // 3rd path
    }
}

Rule Details

This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

Examples of incorrect code for a maximum of 2:

/*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else if (false) {
        return x+1;
    } else {
        return 4; // 3rd path
    }
}

Examples of correct code for a maximum of 2:

/*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else {
        return 4;
    }
}

Options

Optionally, you may specify a max object property:

"complexity": ["error", 2]

is equivalent to

"complexity": ["error", { "max": 2 }]

Deprecated: the object property maximum is deprecated. Please use the property max instead.

When Not To Use It

If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

Further Reading

Related Rules

  • [max-depth](max-depth.md)
  • [max-len](max-len.md)
  • [max-nested-callbacks](max-nested-callbacks.md)
  • [max-params](max-params.md)
  • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

Function insertData has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

TypesPanel.prototype.insertData = function(k, v, array) {
    if (typeof array === 'undefined') { array = this.data; };
    var kt = k[0].trim();

    if (k.length == 1) {
Severity: Minor
Found in www/p/lib/js/panels/types_panel.js - About 1 hr to fix

    Function createTree has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    TypesPanel.prototype.createTree = function() {
        var $tree = $('#types');
        $tree.tree({
            data: this.data,
            slide: false,
    Severity: Minor
    Found in www/p/lib/js/panels/types_panel.js - About 1 hr to fix

      Function createTree has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      TypesPanel.prototype.createTree = function() {
          var $tree = $('#types');
          $tree.tree({
              data: this.data,
              slide: false,
      Severity: Minor
      Found in www/p/lib/js/panels/types_panel.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Unnecessary semicolon.
      Open

          if (typeof array === 'undefined') { array = this.data; };
      Severity: Minor
      Found in www/p/lib/js/panels/types_panel.js by eslint

      disallow unnecessary semicolons (no-extra-semi)

      Typing mistakes and misunderstandings about where semicolons are required can lead to semicolons that are unnecessary. While not technically an error, extra semicolons can cause confusion when reading code.

      Rule Details

      This rule disallows unnecessary semicolons.

      Examples of incorrect code for this rule:

      /*eslint no-extra-semi: "error"*/
      
      var x = 5;;
      
      function foo() {
          // code
      };

      Examples of correct code for this rule:

      /*eslint no-extra-semi: "error"*/
      
      var x = 5;
      
      var foo = function() {
          // code
      };

      When Not To Use It

      If you intentionally use extra semicolons then you can disable this rule.

      Related Rules

      The body of a for-in should be wrapped in an if statement to filter unwanted properties from the prototype.
      Open

              for (var i in strings) {
      Severity: Minor
      Found in www/p/lib/js/panels/types_panel.js by eslint

      Require Guarding for-in (guard-for-in)

      Looping over objects with a for in loop will include properties that are inherited through the prototype chain. This behavior can lead to unexpected items in your for loop.

      for (key in foo) {
          doSomething(key);
      }

      Note that simply checking foo.hasOwnProperty(key) is likely to cause an error in some cases; see [no-prototype-builtins](no-prototype-builtins.md).

      Rule Details

      This rule is aimed at preventing unexpected behavior that could arise from using a for in loop without filtering the results in the loop. As such, it will warn when for in loops do not filter their results with an if statement.

      Examples of incorrect code for this rule:

      /*eslint guard-for-in: "error"*/
      
      for (key in foo) {
          doSomething(key);
      }

      Examples of correct code for this rule:

      /*eslint guard-for-in: "error"*/
      
      for (key in foo) {
          if (Object.prototype.hasOwnProperty.call(foo, key)) {
              doSomething(key);
          }
          if ({}.hasOwnProperty.call(foo, key)) {
              doSomething(key);
          }
      }

      Related Rules

      • [no-prototype-builtins](no-prototype-builtins.md)

      Further Reading

      Unexpected prompt.
      Open

              var str = prompt('Enter C string:');
      Severity: Minor
      Found in www/p/lib/js/panels/types_panel.js by eslint

      Disallow Use of Alert (no-alert)

      JavaScript's alert, confirm, and prompt functions are widely considered to be obtrusive as UI elements and should be replaced by a more appropriate custom UI implementation. Furthermore, alert is often used while debugging code, which should be removed before deployment to production.

      alert("here!");

      Rule Details

      This rule is aimed at catching debugging code that should be removed and popup UI elements that should be replaced with less obtrusive, custom UIs. As such, it will warn when it encounters alert, prompt, and confirm function calls which are not shadowed.

      Examples of incorrect code for this rule:

      /*eslint no-alert: "error"*/
      
      alert("here!");
      
      confirm("Are you sure?");
      
      prompt("What's your name?", "John Doe");

      Examples of correct code for this rule:

      /*eslint no-alert: "error"*/
      
      customAlert("Something happened!");
      
      customConfirm("Are you sure?");
      
      customPrompt("Who are you?");
      
      function foo() {
          var alert = myCustomLib.customAlert;
          alert();
      }

      Related Rules

      Expected '===' and instead saw '=='.
      Open

                      if (node.getLevel() == 2) {
      Severity: Minor
      Found in www/p/lib/js/panels/types_panel.js by eslint

      Require === and !== (eqeqeq)

      It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

      The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

      • [] == false
      • [] == ![]
      • 3 == "03"

      If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

      Rule Details

      This rule is aimed at eliminating the type-unsafe equality operators.

      Examples of incorrect code for this rule:

      /*eslint eqeqeq: "error"*/
      
      if (x == 42) { }
      
      if ("" == text) { }
      
      if (obj.getStuff() != undefined) { }

      The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

      Options

      always

      The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

      Examples of incorrect code for the "always" option:

      /*eslint eqeqeq: ["error", "always"]*/
      
      a == b
      foo == true
      bananas != 1
      value == undefined
      typeof foo == 'undefined'
      'hello' != 'world'
      0 == 0
      true == true
      foo == null

      Examples of correct code for the "always" option:

      /*eslint eqeqeq: ["error", "always"]*/
      
      a === b
      foo === true
      bananas !== 1
      value === undefined
      typeof foo === 'undefined'
      'hello' !== 'world'
      0 === 0
      true === true
      foo === null

      This rule optionally takes a second argument, which should be an object with the following supported properties:

      • "null": Customize how this rule treats null literals. Possible values:
        • always (default) - Always use === or !==.
        • never - Never use === or !== with null.
        • ignore - Do not apply this rule to null.

      smart

      The "smart" option enforces the use of === and !== except for these cases:

      • Comparing two literal values
      • Evaluating the value of typeof
      • Comparing against null

      Examples of incorrect code for the "smart" option:

      /*eslint eqeqeq: ["error", "smart"]*/
      
      // comparing two variables requires ===
      a == b
      
      // only one side is a literal
      foo == true
      bananas != 1
      
      // comparing to undefined requires ===
      value == undefined

      Examples of correct code for the "smart" option:

      /*eslint eqeqeq: ["error", "smart"]*/
      
      typeof foo == 'undefined'
      'hello' != 'world'
      0 == 0
      true == true
      foo == null

      allow-null

      Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

      ["error", "always", {"null": "ignore"}]

      When Not To Use It

      If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

      Expected '===' and instead saw '=='.
      Open

          if (k.length == 1) {
      Severity: Minor
      Found in www/p/lib/js/panels/types_panel.js by eslint

      Require === and !== (eqeqeq)

      It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

      The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

      • [] == false
      • [] == ![]
      • 3 == "03"

      If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

      Rule Details

      This rule is aimed at eliminating the type-unsafe equality operators.

      Examples of incorrect code for this rule:

      /*eslint eqeqeq: "error"*/
      
      if (x == 42) { }
      
      if ("" == text) { }
      
      if (obj.getStuff() != undefined) { }

      The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

      Options

      always

      The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

      Examples of incorrect code for the "always" option:

      /*eslint eqeqeq: ["error", "always"]*/
      
      a == b
      foo == true
      bananas != 1
      value == undefined
      typeof foo == 'undefined'
      'hello' != 'world'
      0 == 0
      true == true
      foo == null

      Examples of correct code for the "always" option:

      /*eslint eqeqeq: ["error", "always"]*/
      
      a === b
      foo === true
      bananas !== 1
      value === undefined
      typeof foo === 'undefined'
      'hello' !== 'world'
      0 === 0
      true === true
      foo === null

      This rule optionally takes a second argument, which should be an object with the following supported properties:

      • "null": Customize how this rule treats null literals. Possible values:
        • always (default) - Always use === or !==.
        • never - Never use === or !== with null.
        • ignore - Do not apply this rule to null.

      smart

      The "smart" option enforces the use of === and !== except for these cases:

      • Comparing two literal values
      • Evaluating the value of typeof
      • Comparing against null

      Examples of incorrect code for the "smart" option:

      /*eslint eqeqeq: ["error", "smart"]*/
      
      // comparing two variables requires ===
      a == b
      
      // only one side is a literal
      foo == true
      bananas != 1
      
      // comparing to undefined requires ===
      value == undefined

      Examples of correct code for the "smart" option:

      /*eslint eqeqeq: ["error", "smart"]*/
      
      typeof foo == 'undefined'
      'hello' != 'world'
      0 == 0
      true == true
      foo == null

      allow-null

      Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

      ["error", "always", {"null": "ignore"}]

      When Not To Use It

      If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

      Expected '!==' and instead saw '!='.
      Open

                          if (node.children && node.children.length != 0) {
      Severity: Minor
      Found in www/p/lib/js/panels/types_panel.js by eslint

      Require === and !== (eqeqeq)

      It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

      The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

      • [] == false
      • [] == ![]
      • 3 == "03"

      If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

      Rule Details

      This rule is aimed at eliminating the type-unsafe equality operators.

      Examples of incorrect code for this rule:

      /*eslint eqeqeq: "error"*/
      
      if (x == 42) { }
      
      if ("" == text) { }
      
      if (obj.getStuff() != undefined) { }

      The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

      Options

      always

      The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

      Examples of incorrect code for the "always" option:

      /*eslint eqeqeq: ["error", "always"]*/
      
      a == b
      foo == true
      bananas != 1
      value == undefined
      typeof foo == 'undefined'
      'hello' != 'world'
      0 == 0
      true == true
      foo == null

      Examples of correct code for the "always" option:

      /*eslint eqeqeq: ["error", "always"]*/
      
      a === b
      foo === true
      bananas !== 1
      value === undefined
      typeof foo === 'undefined'
      'hello' !== 'world'
      0 === 0
      true === true
      foo === null

      This rule optionally takes a second argument, which should be an object with the following supported properties:

      • "null": Customize how this rule treats null literals. Possible values:
        • always (default) - Always use === or !==.
        • never - Never use === or !== with null.
        • ignore - Do not apply this rule to null.

      smart

      The "smart" option enforces the use of === and !== except for these cases:

      • Comparing two literal values
      • Evaluating the value of typeof
      • Comparing against null

      Examples of incorrect code for the "smart" option:

      /*eslint eqeqeq: ["error", "smart"]*/
      
      // comparing two variables requires ===
      a == b
      
      // only one side is a literal
      foo == true
      bananas != 1
      
      // comparing to undefined requires ===
      value == undefined

      Examples of correct code for the "smart" option:

      /*eslint eqeqeq: ["error", "smart"]*/
      
      typeof foo == 'undefined'
      'hello' != 'world'
      0 == 0
      true == true
      foo == null

      allow-null

      Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

      ["error", "always", {"null": "ignore"}]

      When Not To Use It

      If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

      Unexpected string concatenation of literals.
      Open

                               '"' + 'data-node-name="' + node.name + '">[-]</i>';
      Severity: Minor
      Found in www/p/lib/js/panels/types_panel.js by eslint

      Disallow unnecessary concatenation of strings (no-useless-concat)

      It's unnecessary to concatenate two strings together, such as:

      var foo = "a" + "b";

      This code is likely the result of refactoring where a variable was removed from the concatenation (such as "a" + b + "b"). In such a case, the concatenation isn't important and the code can be rewritten as:

      var foo = "ab";

      Rule Details

      This rule aims to flag the concatenation of 2 literals when they could be combined into a single literal. Literals can be strings or template literals.

      Examples of incorrect code for this rule:

      /*eslint no-useless-concat: "error"*/
      /*eslint-env es6*/
      
      // these are the same as "10"
      var a = `some` + `string`;
      var a = '1' + '0';
      var a = '1' + `0`;
      var a = `1` + '0';
      var a = `1` + `0`;

      Examples of correct code for this rule:

      /*eslint no-useless-concat: "error"*/
      
      // when a non string is included
      var c = a + b;
      var c = '1' + a;
      var a = 1 + '1';
      var c = 1 - 2;
      // when the string concatenation is multiline
      var c = "foo" +
          "bar";

      When Not To Use It

      If you don't want to be notified about unnecessary string concatenation, you can safely disable this rule. Source: http://eslint.org/docs/rules/

      TODO found
      Open

              useContextMenu: false, //TODO custom context menu for add/remove/edit?
      Severity: Minor
      Found in www/p/lib/js/panels/types_panel.js by fixme

      There are no issues that match your filters.

      Category
      Status