Sign upLogin

rafspiny/jsondiff

View on GitHub
Star
data/js/jsondiff.js

Summary

Maintainability
D
1 day
Test Coverage

Function populateDiff has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    populateDiff: function(origin, copy, diff) {
        // This method populate the diff object with all the differences between the two JSON objects
        // What are we?
        var typeOrigin = this.typeOf(origin);
        var typeCopy   = this.typeOf(copy);
Severity: Minor
Found in data/js/jsondiff.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function populateDiff has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    populateDiff: function(origin, copy, diff) {
        // This method populate the diff object with all the differences between the two JSON objects
        // What are we?
        var typeOrigin = this.typeOf(origin);
        var typeCopy   = this.typeOf(copy);
Severity: Minor
Found in data/js/jsondiff.js - About 1 hr to fix

    Function handle_object has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        handle_object: function(origin, copy, diff, label, selector) {
        // Inspect each element between two JSON objects
        var source = copy;
        var destination = origin;
    Severity: Minor
    Found in data/js/jsondiff.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function handle_object has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        handle_object: function(origin, copy, diff, label, selector) {
    Severity: Minor
    Found in data/js/jsondiff.js - About 35 mins to fix

      Function stringify has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          stringify: function(value) {
        return this.typeOf(value) === "object" || this.typeOf(value) === "array"?this.typeOf(value):undefined === value?undefined:value.valueOf();
    },
      Severity: Minor
      Found in data/js/jsondiff.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function process_array has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          process_array: function(origin, copy, diff) {
        var minLength = Math.min(origin.length, copy.length);
        for (var common_index = 0; common_index < minLength; common_index++) {
            var common_object = origin[common_index];
            var valueOfCopy = copy[common_index];
      Severity: Minor
      Found in data/js/jsondiff.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function recursivelyFillDiffObj has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          recursivelyFillDiffObj: function(obj, diff) {
        var typeObj = this.typeOf(obj);
        if (typeObj == 'object' || typeObj == 'array') {
            for (var key in obj) {
                diff.values[key] = this.getFilledTemplateDiffObject({"key":key, "value":obj[key], "status":diff.status});
      Severity: Minor
      Found in data/js/jsondiff.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              for (var source_index = minLength; source_index < origin.length; source_index++) {
            var source_object = origin[source_index];
            diff.values[source_index] = this.getFilledTemplateDiffObject({"key":source_index, "value":source_object, "status":"untouched"});
            diff.values[source_index].status = "removed";
            this.recursivelyFillDiffObj(origin[source_index], diff.values[source_index]);
      Severity: Major
      Found in data/js/jsondiff.js and 1 other location - About 4 hrs to fix
      data/js/jsondiff.js on lines 125..130

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 120.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              for (var destination_index = minLength; destination_index < copy.length; destination_index++) {
            var destination_object = copy[destination_index];
            diff.values[destination_index] = this.getFilledTemplateDiffObject({"key":destination_index, "value":destination_object, "status":"untouched"});
            diff.values[destination_index].status = "added";
            this.recursivelyFillDiffObj(copy[destination_index], diff.values[destination_index]);
      Severity: Major
      Found in data/js/jsondiff.js and 1 other location - About 4 hrs to fix
      data/js/jsondiff.js on lines 119..124

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 120.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status