Sign upLogin

rafspiny/jsondiff

View on GitHub
Star

Showing 10 of 14 total issues

Function populateDiff has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    populateDiff: function(origin, copy, diff) {
        // This method populate the diff object with all the differences between the two JSON objects
        // What are we?
        var typeOrigin = this.typeOf(origin);
        var typeCopy   = this.typeOf(copy);
Severity: Minor
Found in data/js/jsondiff.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function printSingleDiff has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function printSingleDiff(diff, div) {
    var ul = document.createElement("ul");

    var singleLine = document.createElement("span");
    singleLine.setAttribute('class', 'jsonline jsondiff'+diff.status);
Severity: Minor
Found in data/js/ui.js - About 1 hr to fix

    Function exports has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function(config) {
  config.set({

    // base path that will be used to resolve all patterns (eg. files, exclude)
    basePath: '',
    Severity: Minor
    Found in karma.conf.js - About 1 hr to fix

      Function populateDiff has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          populateDiff: function(origin, copy, diff) {
        // This method populate the diff object with all the differences between the two JSON objects
        // What are we?
        var typeOrigin = this.typeOf(origin);
        var typeCopy   = this.typeOf(copy);
      Severity: Minor
      Found in data/js/jsondiff.js - About 1 hr to fix

        Function printSingleDiff has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

        function printSingleDiff(diff, div) {
    var ul = document.createElement("ul");

    var singleLine = document.createElement("span");
    singleLine.setAttribute('class', 'jsonline jsondiff'+diff.status);
        Severity: Minor
        Found in data/js/ui.js - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function handle_object has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            handle_object: function(origin, copy, diff, label, selector) {
        // Inspect each element between two JSON objects
        var source = copy;
        var destination = origin;
        Severity: Minor
        Found in data/js/jsondiff.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function handle_object has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            handle_object: function(origin, copy, diff, label, selector) {
        Severity: Minor
        Found in data/js/jsondiff.js - About 35 mins to fix

          Function stringify has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              stringify: function(value) {
        return this.typeOf(value) === "object" || this.typeOf(value) === "array"?this.typeOf(value):undefined === value?undefined:value.valueOf();
    },
          Severity: Minor
          Found in data/js/jsondiff.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function recursivelyFillDiffObj has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              recursivelyFillDiffObj: function(obj, diff) {
        var typeObj = this.typeOf(obj);
        if (typeObj == 'object' || typeObj == 'array') {
            for (var key in obj) {
                diff.values[key] = this.getFilledTemplateDiffObject({"key":key, "value":obj[key], "status":diff.status});
          Severity: Minor
          Found in data/js/jsondiff.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function process_array has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              process_array: function(origin, copy, diff) {
        var minLength = Math.min(origin.length, copy.length);
        for (var common_index = 0; common_index < minLength; common_index++) {
            var common_object = origin[common_index];
            var valueOfCopy = copy[common_index];
          Severity: Minor
          Found in data/js/jsondiff.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language