Sign upLogin

railsdog/spree_shipping_labels

View on GitHub
Star

Showing 1 of 288 total issues

Method generate_label! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def generate_label!
    raise Spree::ShippingLabels::Error, 'Cannot generate a label without a package type' unless package_type
    raise Spree::ShippingLabels::Error, 'Cannot generate a label without a label-able selected shipping method' unless calculator
    # Restrict to just 5 seconds to get response to avoid appearing slow
    timeout 10 do
Severity: Minor
Found in app/models/spree/shipment_decorator.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language