Showing 10 of 10 total issues
Method bootGrammar
has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function bootGrammar(): GrammarInterface
{
return new Grammar([
new Repetition(0, 0, -1, '__definition', null),
(new Concatenation('Grammar', [0], 'Grammar'))->setDefaultId('Grammar'),
Method repetition
has 52 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function repetition(LookaheadIterator $tokens, &$pNodeId)
{
[$min, $max] = [null, null];
// simple() …
Function repetition
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
protected function repetition(LookaheadIterator $tokens, &$pNodeId)
{
[$min, $max] = [null, null];
// simple() …
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method choice
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function choice(LookaheadIterator $tokens, &$pNodeId)
{
$children = [];
// concatenation() …
Method analyze
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function analyze(): iterable
{
if (\count($this->rules) === 0) {
throw new GrammarException('No rules specified');
}
Function addGrammar
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
private function addGrammar(Readable $file): void
{
$ast = $this->pp->parse($file);
foreach ($ast->getChildren() as $child) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function choice
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
protected function choice(LookaheadIterator $tokens, &$pNodeId)
{
$children = [];
// concatenation() …
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method __construct
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function __construct($name, int $min, int $max, $children, string $nodeId = null)
Function analyze
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function analyze(): iterable
{
if (\count($this->rules) === 0) {
throw new GrammarException('No rules specified');
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
return null;