Sign upLogin

randytarampi/me

View on GitHub
Star
packages/service/src/lib/postSearchParams.js

Summary

Maintainability
D
2 days
Test Coverage
A
99%

File postSearchParams.js has 545 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

import {
    castDatePropertyToDateTime,
    compositeKeySeparator,
    convertLatLongToGeohash,
    Gallery,
Severity: Major
Found in packages/service/src/lib/postSearchParams.js - About 1 day to fix

Function Dynamoose has 179 lines of code (exceeds 100 allowed). Consider refactoring.
Wontfix

    get Dynamoose() {
        const options = {
            descending: true,
            all: this.all
        };
Severity: Major
Found in packages/service/src/lib/postSearchParams.js - About 4 hrs to fix

Function Dynamoose has a Cognitive Complexity of 32 (exceeds 10 allowed). Consider refactoring.
Wontfix

    get Dynamoose() {
        const options = {
            descending: true,
            all: this.all
        };
Severity: Minor
Found in packages/service/src/lib/postSearchParams.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

                return {
                    _query: {
                        status: {eq: this.status},
                        geohash: {begins_with: this.geohash}
                    },
Severity: Major
Found in packages/service/src/lib/postSearchParams.js - About 30 mins to fix

Avoid too many return statements within this function.
Invalid

        return { // NOTE-RT: Just scan the entire table until we know enough of what we'd want to scan (instead of query) for
            _filter: filters,
            _options: options
        };
Severity: Major
Found in packages/service/src/lib/postSearchParams.js - About 30 mins to fix

Avoid too many return statements within this function.
Open

            return {
                _query: {
                    status: {eq: this.status}
                },
                _options: options,
Severity: Major
Found in packages/service/src/lib/postSearchParams.js - About 30 mins to fix

Avoid too many return statements within this function.
Open

                return this.geohashQueries.map(geohashQuery => {
                    return {
                        _query: {
                            status: {eq: this.status},
                            geohash: {begins_with: geohashQuery}
Severity: Major
Found in packages/service/src/lib/postSearchParams.js - About 30 mins to fix

Avoid too many return statements within this function.
Open

                return {
                    _query: {
                        type: {eq: this.type},
                        [this.orderBy]: {[this.orderOperator]: castOrderComparator}
                    },
Severity: Major
Found in packages/service/src/lib/postSearchParams.js - About 30 mins to fix

Avoid too many return statements within this function.
Open

            return {
                _query: {
                    type: {eq: this.type}
                },
                _options: {
Severity: Major
Found in packages/service/src/lib/postSearchParams.js - About 30 mins to fix

Avoid too many return statements within this function.
Open

                return {
                    _query: {
                        status: {eq: this.status},
                        [this.orderBy]: {[this.orderOperator]: castOrderComparator}
                    },
Severity: Major
Found in packages/service/src/lib/postSearchParams.js - About 30 mins to fix

FIXME found
Invalid

        if (this.tags) { // FIXME-RT: Ideally this would do a filtered query on an index, but let's save that for when I blow this up and move the logic into db/models/post
Severity: Minor
Found in packages/service/src/lib/postSearchParams.js by fixme

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if (this.geohashQueries) {
                return this.geohashQueries.map(geohashQuery => {
                    return {
                        _query: {
                            type: {eq: this.type},
Severity: Major
Found in packages/service/src/lib/postSearchParams.js and 1 other location - About 2 hrs to fix
packages/service/src/lib/postSearchParams.js on lines 339..353

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if (this.geohashQueries) {
                return this.geohashQueries.map(geohashQuery => {
                    return {
                        _query: {
                            status: {eq: this.status},
Severity: Major
Found in packages/service/src/lib/postSearchParams.js and 1 other location - About 2 hrs to fix
packages/service/src/lib/postSearchParams.js on lines 279..293

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if (typeIndiciesRangeKeys.includes(this.orderBy) && this.hasOrderingConditions) {
                return {
                    _query: {
                        type: {eq: this.type},
                        [this.orderBy]: {[this.orderOperator]: castOrderComparator}
Severity: Major
Found in packages/service/src/lib/postSearchParams.js and 1 other location - About 2 hrs to fix
packages/service/src/lib/postSearchParams.js on lines 369..378

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 81.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if (statusIndiciesRangeKeys.includes(this.orderBy) && this.hasOrderingConditions) {
                return {
                    _query: {
                        status: {eq: this.status},
                        [this.orderBy]: {[this.orderOperator]: castOrderComparator}
Severity: Major
Found in packages/service/src/lib/postSearchParams.js and 1 other location - About 2 hrs to fix
packages/service/src/lib/postSearchParams.js on lines 309..318

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 81.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if (this.geohash) {
                return {
                    _query: {
                        status: {eq: this.status},
                        geohash: {begins_with: this.geohash}
Severity: Major
Found in packages/service/src/lib/postSearchParams.js and 1 other location - About 1 hr to fix
packages/service/src/lib/postSearchParams.js on lines 295..307

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if (this.geohash) {
                return {
                    _query: {
                        type: {eq: this.type},
                        geohash: {begins_with: this.geohash}
Severity: Major
Found in packages/service/src/lib/postSearchParams.js and 1 other location - About 1 hr to fix
packages/service/src/lib/postSearchParams.js on lines 355..367

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Invalid

        if (this.beforeDate) {
            filterRequest.before = Math.round(this.beforeDate.toSeconds()) - 1;
        }
Severity: Minor
Found in packages/service/src/lib/postSearchParams.js and 1 other location - About 30 mins to fix
packages/service/src/lib/postSearchParams.js on lines 479..481

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Invalid

        if (this.beforeDate) {
            facebookQuery.until = Math.round(this.beforeDate.toSeconds()) - 1;
        }
Severity: Minor
Found in packages/service/src/lib/postSearchParams.js and 1 other location - About 30 mins to fix
packages/service/src/lib/postSearchParams.js on lines 178..180

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status