Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star

Showing 6,027 of 21,757 total issues

Similar blocks of code found in 22 locations. Consider refactoring.
Open

          [ 'BID', '102525' ],
          [ 'CVE', '2018-1000001' ],
          [ 'EDB', '43775' ],
          [ 'URL', 'https://www.halfdog.net/Security/2017/LibcRealpathBufferUnderflow/' ],
          [ 'URL', 'http://www.openwall.com/lists/oss-security/2018/01/11/5' ],
Severity: Major
Found in modules/exploits/linux/local/glibc_realpath_priv_esc.rb and 21 other locations - About 20 mins to fix
modules/auxiliary/dos/http/hashcollision_dos.rb on lines 36..44
modules/auxiliary/scanner/http/wp_woocommerce_payments_add_user.rb on lines 61..69
modules/exploits/android/browser/webview_addjavascriptinterface.rb on lines 58..66
modules/exploits/freebsd/local/rtld_execl_priv_esc.rb on lines 57..65
modules/exploits/linux/http/apache_superset_cookie_sig_rce.rb on lines 32..40
modules/exploits/linux/http/zimbra_cpio_cve_2022_41352.rb on lines 44..52
modules/exploits/linux/local/bpf_priv_esc.rb on lines 48..56
modules/exploits/linux/local/cve_2021_3490_ebpf_alu32_bounds_check_lpe.rb on lines 53..61
modules/exploits/linux/local/systemtap_modprobe_options_priv_esc.rb on lines 43..51
modules/exploits/linux/misc/cisco_ios_xe_rce.rb on lines 52..65
modules/exploits/linux/misc/lprng_format_string.rb on lines 26..34
modules/exploits/linux/upnp/dlink_upnp_msearch_exec.rb on lines 70..78
modules/exploits/multi/browser/java_jre17_exec.rb on lines 43..51
modules/exploits/multi/http/git_client_command_exec.rb on lines 47..55
modules/exploits/multi/http/vtiger_soap_upload.rb on lines 33..41
modules/exploits/windows/browser/ms13_022_silverlight_script_object.rb on lines 40..48
modules/exploits/windows/browser/webex_ucf_newobject.rb on lines 40..48
modules/exploits/windows/fileformat/allplayer_m3u_bof.rb on lines 31..39
modules/exploits/windows/http/exchange_chainedserializationbinder_rce.rb on lines 45..54
modules/exploits/windows/http/exchange_ecp_dlp_policy.rb on lines 49..57
modules/exploits/windows/http/netgear_nms_rce.rb on lines 32..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

  def import_nmap_xml_file(args={})
    filename = args[:filename]

    data = ""
    ::File.open(filename, 'rb') do |f|
Severity: Major
Found in lib/msf/core/db_manager/import/nmap.rb and 10 other locations - About 20 mins to fix
lib/msf/core/db_manager/import/ip360/v3.rb on lines 6..13
lib/msf/core/db_manager/import/ip_list.rb on lines 18..25
lib/msf/core/db_manager/import/metasploit_framework/xml.rb on lines 57..64
lib/msf/core/db_manager/import/nessus/nbe.rb on lines 84..91
lib/msf/core/db_manager/import/netsparker.rb on lines 161..168
lib/msf/core/db_manager/import/nexpose/raw.rb on lines 74..81
lib/msf/core/db_manager/import/nexpose/simple.rb on lines 155..162
lib/msf/core/db_manager/import/qualys/scan.rb on lines 92..99
lib/msf/core/db_manager/import/retina.rb on lines 87..94
lib/msf/core/db_manager/import/wapiti.rb on lines 13..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  def run_host(ip)
    res = send_request_cgi({
      'uri'      => normalize_uri(datastore['URI']),
      'method'   => 'GET'
    }, 25)
Severity: Major
Found in modules/auxiliary/scanner/sap/sap_mgmt_con_getaccesspoints.rb and 9 other locations - About 20 mins to fix
modules/auxiliary/scanner/sap/sap_mgmt_con_abaplog.rb on lines 32..43
modules/auxiliary/scanner/sap/sap_mgmt_con_extractusers.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_getenv.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_getprocesslist.rb on lines 38..49
modules/auxiliary/scanner/sap/sap_mgmt_con_instanceproperties.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_listconfigfiles.rb on lines 40..51
modules/auxiliary/scanner/sap/sap_mgmt_con_listlogfiles.rb on lines 37..48
modules/auxiliary/scanner/sap/sap_mgmt_con_startprofile.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_version.rb on lines 35..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  def run_host(ip)
    res = send_request_cgi({
      'uri'      => normalize_uri(datastore['URI']),
      'method'   => 'GET'
    }, 25)
Severity: Major
Found in modules/auxiliary/scanner/sap/sap_mgmt_con_listlogfiles.rb and 9 other locations - About 20 mins to fix
modules/auxiliary/scanner/sap/sap_mgmt_con_abaplog.rb on lines 32..43
modules/auxiliary/scanner/sap/sap_mgmt_con_extractusers.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_getaccesspoints.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_getenv.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_getprocesslist.rb on lines 38..49
modules/auxiliary/scanner/sap/sap_mgmt_con_instanceproperties.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_listconfigfiles.rb on lines 40..51
modules/auxiliary/scanner/sap/sap_mgmt_con_startprofile.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_version.rb on lines 35..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

  def import_retina_xml_file(args={})
    filename = args[:filename]

    data = ""
    ::File.open(filename, 'rb') do |f|
Severity: Major
Found in lib/msf/core/db_manager/import/retina.rb and 10 other locations - About 20 mins to fix
lib/msf/core/db_manager/import/ip360/v3.rb on lines 6..13
lib/msf/core/db_manager/import/ip_list.rb on lines 18..25
lib/msf/core/db_manager/import/metasploit_framework/xml.rb on lines 57..64
lib/msf/core/db_manager/import/nessus/nbe.rb on lines 84..91
lib/msf/core/db_manager/import/netsparker.rb on lines 161..168
lib/msf/core/db_manager/import/nexpose/raw.rb on lines 74..81
lib/msf/core/db_manager/import/nexpose/simple.rb on lines 155..162
lib/msf/core/db_manager/import/nmap.rb on lines 241..248
lib/msf/core/db_manager/import/qualys/scan.rb on lines 92..99
lib/msf/core/db_manager/import/wapiti.rb on lines 13..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  def run_host(ip)
    res = send_request_cgi({
      'uri'     => normalize_uri(datastore['URI']),
      'method'  => 'GET'
    }, 25)
Severity: Major
Found in modules/auxiliary/scanner/sap/sap_mgmt_con_version.rb and 9 other locations - About 20 mins to fix
modules/auxiliary/scanner/sap/sap_mgmt_con_abaplog.rb on lines 32..43
modules/auxiliary/scanner/sap/sap_mgmt_con_extractusers.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_getaccesspoints.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_getenv.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_getprocesslist.rb on lines 38..49
modules/auxiliary/scanner/sap/sap_mgmt_con_instanceproperties.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_listconfigfiles.rb on lines 40..51
modules/auxiliary/scanner/sap/sap_mgmt_con_listlogfiles.rb on lines 37..48
modules/auxiliary/scanner/sap/sap_mgmt_con_startprofile.rb on lines 35..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

  def import_wapiti_xml_file(args={})
    filename = args[:filename]

    data = ""
    ::File.open(filename, 'rb') do |f|
Severity: Major
Found in lib/msf/core/db_manager/import/wapiti.rb and 10 other locations - About 20 mins to fix
lib/msf/core/db_manager/import/ip360/v3.rb on lines 6..13
lib/msf/core/db_manager/import/ip_list.rb on lines 18..25
lib/msf/core/db_manager/import/metasploit_framework/xml.rb on lines 57..64
lib/msf/core/db_manager/import/nessus/nbe.rb on lines 84..91
lib/msf/core/db_manager/import/netsparker.rb on lines 161..168
lib/msf/core/db_manager/import/nexpose/raw.rb on lines 74..81
lib/msf/core/db_manager/import/nexpose/simple.rb on lines 155..162
lib/msf/core/db_manager/import/nmap.rb on lines 241..248
lib/msf/core/db_manager/import/qualys/scan.rb on lines 92..99
lib/msf/core/db_manager/import/retina.rb on lines 87..94

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

  def import_nexpose_rawxml_file(args={})
    filename = args[:filename]

    data = ""
    ::File.open(filename, 'rb') do |f|
Severity: Major
Found in lib/msf/core/db_manager/import/nexpose/raw.rb and 10 other locations - About 20 mins to fix
lib/msf/core/db_manager/import/ip360/v3.rb on lines 6..13
lib/msf/core/db_manager/import/ip_list.rb on lines 18..25
lib/msf/core/db_manager/import/metasploit_framework/xml.rb on lines 57..64
lib/msf/core/db_manager/import/nessus/nbe.rb on lines 84..91
lib/msf/core/db_manager/import/netsparker.rb on lines 161..168
lib/msf/core/db_manager/import/nexpose/simple.rb on lines 155..162
lib/msf/core/db_manager/import/nmap.rb on lines 241..248
lib/msf/core/db_manager/import/qualys/scan.rb on lines 92..99
lib/msf/core/db_manager/import/retina.rb on lines 87..94
lib/msf/core/db_manager/import/wapiti.rb on lines 13..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  def run_host(ip)
    res = send_request_cgi({
      'uri'      => normalize_uri(datastore['URI']),
      'method'   => 'GET'
    }, 25)
Severity: Major
Found in modules/auxiliary/scanner/sap/sap_mgmt_con_startprofile.rb and 9 other locations - About 20 mins to fix
modules/auxiliary/scanner/sap/sap_mgmt_con_abaplog.rb on lines 32..43
modules/auxiliary/scanner/sap/sap_mgmt_con_extractusers.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_getaccesspoints.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_getenv.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_getprocesslist.rb on lines 38..49
modules/auxiliary/scanner/sap/sap_mgmt_con_instanceproperties.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_listconfigfiles.rb on lines 40..51
modules/auxiliary/scanner/sap/sap_mgmt_con_listlogfiles.rb on lines 37..48
modules/auxiliary/scanner/sap/sap_mgmt_con_version.rb on lines 35..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

  def import_ip_list_file(args={})
    filename = args[:filename]

    data = ""
    ::File.open(filename, 'rb') do |f|
Severity: Major
Found in lib/msf/core/db_manager/import/ip_list.rb and 10 other locations - About 20 mins to fix
lib/msf/core/db_manager/import/ip360/v3.rb on lines 6..13
lib/msf/core/db_manager/import/metasploit_framework/xml.rb on lines 57..64
lib/msf/core/db_manager/import/nessus/nbe.rb on lines 84..91
lib/msf/core/db_manager/import/netsparker.rb on lines 161..168
lib/msf/core/db_manager/import/nexpose/raw.rb on lines 74..81
lib/msf/core/db_manager/import/nexpose/simple.rb on lines 155..162
lib/msf/core/db_manager/import/nmap.rb on lines 241..248
lib/msf/core/db_manager/import/qualys/scan.rb on lines 92..99
lib/msf/core/db_manager/import/retina.rb on lines 87..94
lib/msf/core/db_manager/import/wapiti.rb on lines 13..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  def run_host(ip)
    res = send_request_cgi({
      'uri'      => normalize_uri(datastore['URI']),
      'method'   => 'GET'
    }, 25)
Severity: Major
Found in modules/auxiliary/scanner/sap/sap_mgmt_con_getprocesslist.rb and 9 other locations - About 20 mins to fix
modules/auxiliary/scanner/sap/sap_mgmt_con_abaplog.rb on lines 32..43
modules/auxiliary/scanner/sap/sap_mgmt_con_extractusers.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_getaccesspoints.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_getenv.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_instanceproperties.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_listconfigfiles.rb on lines 40..51
modules/auxiliary/scanner/sap/sap_mgmt_con_listlogfiles.rb on lines 37..48
modules/auxiliary/scanner/sap/sap_mgmt_con_startprofile.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_version.rb on lines 35..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

  def import_msf_file(args={})
    filename = args[:filename]

    data = ""
    ::File.open(filename, 'rb') do |f|
Severity: Major
Found in lib/msf/core/db_manager/import/metasploit_framework/xml.rb and 10 other locations - About 20 mins to fix
lib/msf/core/db_manager/import/ip360/v3.rb on lines 6..13
lib/msf/core/db_manager/import/ip_list.rb on lines 18..25
lib/msf/core/db_manager/import/nessus/nbe.rb on lines 84..91
lib/msf/core/db_manager/import/netsparker.rb on lines 161..168
lib/msf/core/db_manager/import/nexpose/raw.rb on lines 74..81
lib/msf/core/db_manager/import/nexpose/simple.rb on lines 155..162
lib/msf/core/db_manager/import/nmap.rb on lines 241..248
lib/msf/core/db_manager/import/qualys/scan.rb on lines 92..99
lib/msf/core/db_manager/import/retina.rb on lines 87..94
lib/msf/core/db_manager/import/wapiti.rb on lines 13..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

  def import_nessus_nbe_file(args={})
    filename = args[:filename]

    data = ""
    ::File.open(filename, 'rb') do |f|
Severity: Major
Found in lib/msf/core/db_manager/import/nessus/nbe.rb and 10 other locations - About 20 mins to fix
lib/msf/core/db_manager/import/ip360/v3.rb on lines 6..13
lib/msf/core/db_manager/import/ip_list.rb on lines 18..25
lib/msf/core/db_manager/import/metasploit_framework/xml.rb on lines 57..64
lib/msf/core/db_manager/import/netsparker.rb on lines 161..168
lib/msf/core/db_manager/import/nexpose/raw.rb on lines 74..81
lib/msf/core/db_manager/import/nexpose/simple.rb on lines 155..162
lib/msf/core/db_manager/import/nmap.rb on lines 241..248
lib/msf/core/db_manager/import/qualys/scan.rb on lines 92..99
lib/msf/core/db_manager/import/retina.rb on lines 87..94
lib/msf/core/db_manager/import/wapiti.rb on lines 13..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  def run_host(ip)
    res = send_request_cgi({
      'uri'     => normalize_uri(datastore['URI']),
      'method'  => 'GET'
    }, 25)
Severity: Major
Found in modules/auxiliary/scanner/sap/sap_mgmt_con_abaplog.rb and 9 other locations - About 20 mins to fix
modules/auxiliary/scanner/sap/sap_mgmt_con_extractusers.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_getaccesspoints.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_getenv.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_getprocesslist.rb on lines 38..49
modules/auxiliary/scanner/sap/sap_mgmt_con_instanceproperties.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_listconfigfiles.rb on lines 40..51
modules/auxiliary/scanner/sap/sap_mgmt_con_listlogfiles.rb on lines 37..48
modules/auxiliary/scanner/sap/sap_mgmt_con_startprofile.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_version.rb on lines 35..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

  def import_ip360_xml_file(args={})
    filename = args[:filename]

    data = ""
    ::File.open(filename, 'rb') do |f|
Severity: Major
Found in lib/msf/core/db_manager/import/ip360/v3.rb and 10 other locations - About 20 mins to fix
lib/msf/core/db_manager/import/ip_list.rb on lines 18..25
lib/msf/core/db_manager/import/metasploit_framework/xml.rb on lines 57..64
lib/msf/core/db_manager/import/nessus/nbe.rb on lines 84..91
lib/msf/core/db_manager/import/netsparker.rb on lines 161..168
lib/msf/core/db_manager/import/nexpose/raw.rb on lines 74..81
lib/msf/core/db_manager/import/nexpose/simple.rb on lines 155..162
lib/msf/core/db_manager/import/nmap.rb on lines 241..248
lib/msf/core/db_manager/import/qualys/scan.rb on lines 92..99
lib/msf/core/db_manager/import/retina.rb on lines 87..94
lib/msf/core/db_manager/import/wapiti.rb on lines 13..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  def run_host(ip)
    res = send_request_cgi({
      'uri'     => normalize_uri(datastore['URI']),
      'method'  => 'GET'
    }, 25)
Severity: Major
Found in modules/auxiliary/scanner/sap/sap_mgmt_con_extractusers.rb and 9 other locations - About 20 mins to fix
modules/auxiliary/scanner/sap/sap_mgmt_con_abaplog.rb on lines 32..43
modules/auxiliary/scanner/sap/sap_mgmt_con_getaccesspoints.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_getenv.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_getprocesslist.rb on lines 38..49
modules/auxiliary/scanner/sap/sap_mgmt_con_instanceproperties.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_listconfigfiles.rb on lines 40..51
modules/auxiliary/scanner/sap/sap_mgmt_con_listlogfiles.rb on lines 37..48
modules/auxiliary/scanner/sap/sap_mgmt_con_startprofile.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_version.rb on lines 35..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  def run_host(ip)
    res = send_request_cgi({
      'uri'      => normalize_uri(datastore['URI']),
      'method'   => 'GET'
    }, 25)
Severity: Major
Found in modules/auxiliary/scanner/sap/sap_mgmt_con_listconfigfiles.rb and 9 other locations - About 20 mins to fix
modules/auxiliary/scanner/sap/sap_mgmt_con_abaplog.rb on lines 32..43
modules/auxiliary/scanner/sap/sap_mgmt_con_extractusers.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_getaccesspoints.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_getenv.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_getprocesslist.rb on lines 38..49
modules/auxiliary/scanner/sap/sap_mgmt_con_instanceproperties.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_listlogfiles.rb on lines 37..48
modules/auxiliary/scanner/sap/sap_mgmt_con_startprofile.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_version.rb on lines 35..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  def run_host(ip)
    res = send_request_cgi({
      'uri'      => normalize_uri(datastore['URI']),
      'method'   => 'GET'
    }, 25)
Severity: Major
Found in modules/auxiliary/scanner/sap/sap_mgmt_con_getenv.rb and 9 other locations - About 20 mins to fix
modules/auxiliary/scanner/sap/sap_mgmt_con_abaplog.rb on lines 32..43
modules/auxiliary/scanner/sap/sap_mgmt_con_extractusers.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_getaccesspoints.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_getprocesslist.rb on lines 38..49
modules/auxiliary/scanner/sap/sap_mgmt_con_instanceproperties.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_listconfigfiles.rb on lines 40..51
modules/auxiliary/scanner/sap/sap_mgmt_con_listlogfiles.rb on lines 37..48
modules/auxiliary/scanner/sap/sap_mgmt_con_startprofile.rb on lines 35..46
modules/auxiliary/scanner/sap/sap_mgmt_con_version.rb on lines 35..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

  def import_nexpose_simplexml_file(args={})
    filename = args[:filename]

    data = ""
    ::File.open(filename, 'rb') do |f|
Severity: Major
Found in lib/msf/core/db_manager/import/nexpose/simple.rb and 10 other locations - About 20 mins to fix
lib/msf/core/db_manager/import/ip360/v3.rb on lines 6..13
lib/msf/core/db_manager/import/ip_list.rb on lines 18..25
lib/msf/core/db_manager/import/metasploit_framework/xml.rb on lines 57..64
lib/msf/core/db_manager/import/nessus/nbe.rb on lines 84..91
lib/msf/core/db_manager/import/netsparker.rb on lines 161..168
lib/msf/core/db_manager/import/nexpose/raw.rb on lines 74..81
lib/msf/core/db_manager/import/nmap.rb on lines 241..248
lib/msf/core/db_manager/import/qualys/scan.rb on lines 92..99
lib/msf/core/db_manager/import/retina.rb on lines 87..94
lib/msf/core/db_manager/import/wapiti.rb on lines 13..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

  def import_netsparker_xml_file(args={})
    filename = args[:filename]

    data = ""
    ::File.open(filename, 'rb') do |f|
Severity: Major
Found in lib/msf/core/db_manager/import/netsparker.rb and 10 other locations - About 20 mins to fix
lib/msf/core/db_manager/import/ip360/v3.rb on lines 6..13
lib/msf/core/db_manager/import/ip_list.rb on lines 18..25
lib/msf/core/db_manager/import/metasploit_framework/xml.rb on lines 57..64
lib/msf/core/db_manager/import/nessus/nbe.rb on lines 84..91
lib/msf/core/db_manager/import/nexpose/raw.rb on lines 74..81
lib/msf/core/db_manager/import/nexpose/simple.rb on lines 155..162
lib/msf/core/db_manager/import/nmap.rb on lines 241..248
lib/msf/core/db_manager/import/qualys/scan.rb on lines 92..99
lib/msf/core/db_manager/import/retina.rb on lines 87..94
lib/msf/core/db_manager/import/wapiti.rb on lines 13..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language