rapid7/metasploit-framework

View on GitHub

Showing 15,730 of 21,757 total issues

Method ntlmv2_response has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.ntlmv2_response(arg, opt = {})
    raise RuntimeError, "No OpenSSL support" if not @@loaded_openssl

    key, chal = arg[:ntlmv2_hash], arg[:challenge]
    if not (key and chal)
Severity: Minor
Found in lib/rex/proto/ntlm/crypt.rb - About 1 hr to fix

    Method send_text_to_phones has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def send_text_to_phones(phone_numbers, subject, message)
              carrier     = Rex::Proto::Sms::Model::GATEWAYS[self.carrier]
              recipients  = phone_numbers.collect { |p| "#{p}@#{carrier}" }
              address     = self.smtp_server.address
              port        = self.smtp_server.port
    Severity: Minor
    Found in lib/rex/proto/sms/client.rb - About 1 hr to fix

      Method decode_asn1 has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def decode_asn1(input)
            input.value[0].value.each do |val|
              case val.tag
              when 0  # flags               [0] TicketFlags
                self.flags = decode_flags(val)
      Severity: Minor
      Found in lib/rex/proto/kerberos/model/ticket_enc_part.rb - About 1 hr to fix

        Method startservice has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def startservice(svc_handle, args=[])
            svc_status = nil
        
            if args.empty?
              stubdata = svc_handle + NDR.long(0) + NDR.long(0)
        Severity: Minor
        Found in lib/rex/proto/dcerpc/svcctl/client.rb - About 1 hr to fix

          Method decode_asn1 has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                    def decode_asn1(input)
                      input.value.each do |val|
                        case val.tag
                        when 0
                          self.key = decode_key(val)
          Severity: Minor
          Found in lib/rex/proto/kerberos/model/krb_cred_info.rb - About 1 hr to fix

            Method calculate_checksums! has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def calculate_checksums!(service_key: nil, krbtgt_key: nil)
                  server_checksum = nil
                  priv_server_checksum = nil
                  full_pac_checksum = nil
                  pac_info_buffers.each do |info_buffer|
            Severity: Minor
            Found in lib/rex/proto/kerberos/pac/krb5_pac.rb - About 1 hr to fix

              Method file_search has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def file_search(current_path, regex, depth)
                  depth -= 1
                  return [] if depth < 0
              
                  results = find_first(current_path + "*")
              Severity: Minor
              Found in lib/rex/proto/smb/client.rb - About 1 hr to fix

                Method recv_response_tcp has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        def recv_response_tcp
                          remaining = timeout
                          length_raw, elapsed_time = Rex::Stopwatch.elapsed_time do
                            connection.get_once(4, remaining)
                          end
                Severity: Minor
                Found in lib/rex/proto/kerberos/client.rb - About 1 hr to fix

                  Method read has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    def read(file_id = self.last_file_id, offset = 0, data_length = 64000, do_recv = true)
                  
                      pkt = CONST::SMB_READ_PKT.make_struct
                      self.smb_defaults(pkt['Payload']['SMB'])
                  
                  
                  Severity: Minor
                  Found in lib/rex/proto/smb/client.rb - About 1 hr to fix

                    Method print_bin_data_model has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        def print_bin_data_model(model, bit_length: nil)
                          rows = []
                    
                          # i.e. [[:field_name_1,  1], [:field_name_2, 0]]
                          fields_and_values = model.to_enum(:each_pair).to_a
                    Severity: Minor
                    Found in lib/rex/proto/kerberos/credential_cache/krb5_ccache_presenter.rb - About 1 hr to fix

                      Method resolve_via_dns_server has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          def resolve_via_dns_server(upstream_resolver, packet, type, _cls)
                            method = self.use_tcp? ? :send_tcp : :send_udp
                      
                            # Store packet_data for performance improvements,
                            # so methods don't keep on calling Packet#encode
                      Severity: Minor
                      Found in lib/rex/proto/dns/resolver.rb - About 1 hr to fix

                        Method simple_name_lookup has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            def simple_name_lookup(upstream_resolver, packet, type, cls, &block)
                              return nil unless cls == Dnsruby::Classes::IN
                        
                              # todo: make sure this will work if the packet has multiple questions, figure out how that's handled
                              name = packet.question.first.qname.to_s
                        Severity: Minor
                        Found in lib/rex/proto/dns/resolver.rb - About 1 hr to fix

                          Method end_element has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              def end_element(name=nil)
                                block = @block
                                case name
                                when "SecScan" # Wrap it up
                                  collect_host_data
                          Severity: Minor
                          Found in lib/rex/parser/mbsa_document.rb - About 1 hr to fix

                            Method generate_command_id_map_csharp has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                            def self.generate_command_id_map_csharp
                              id_map = CommandMapper.get_commands(*%w{
                                core
                                stdapi
                                priv
                            Severity: Minor
                            Found in lib/rex/post/meterpreter/packet.rb - About 1 hr to fix

                              Method cmd_channel_bw has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                def cmd_channel_bw(*args)
                                  self.idx ||= 0
                                  bandwidth = -1
                                  mhz = nil
                                  arg = {}

                                Method cmd_deviation has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                  def cmd_deviation(*args)
                                    self.idx ||= 0
                                    deviat = -1
                                    mhz = nil
                                    arg = {}

                                  Method cmd_wakelock has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                    def cmd_wakelock(*args)
                                      wakelock_opts = Rex::Parser::Arguments.new(
                                        '-h' => [ false, 'Help Banner' ],
                                        '-r' => [ false, 'Release wakelock' ],
                                        '-w' => [ false, 'Turn screen on' ],
                                  Severity: Minor
                                  Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/android.rb - About 1 hr to fix

                                    Method cmd_baud has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                                    Open

                                      def cmd_baud(*args)
                                        self.idx ||= 0
                                        baud = -1
                                        mhz = nil
                                        arg = {}

                                      Method cmd_freq has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                                      Open

                                        def cmd_freq(*args)
                                          self.idx ||= 0
                                          freq = -1
                                          mhz = nil
                                          arg = {}

                                        Method cmd_load has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                                        Open

                                          def cmd_load(*args)
                                            if args.length.zero?
                                              args.unshift("-h")
                                            end
                                        
                                        
                                        Severity: Minor
                                        Found in lib/rex/post/hwbridge/ui/console/command_dispatcher/core.rb - About 1 hr to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language