Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star

Showing 7,361 of 22,177 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            for root, dirs, files in os.walk('./src/single/'):
                for name in files:
                    if name[-4:] == '.asm':
                        build(name[:-4])
Severity: Major
Found in external/source/shellcode/windows/x64/build.py and 3 other locations - About 2 hrs to fix
external/source/shellcode/windows/x64/build.py on lines 91..94
external/source/shellcode/windows/x64/build.py on lines 99..102
external/source/shellcode/windows/x64/build.py on lines 103..106

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            for root, dirs, files in os.walk('./src/stage/'):
                for name in files:
                    if name[-4:] == '.asm':
                        build(name[:-4])
Severity: Major
Found in external/source/shellcode/windows/x64/build.py and 3 other locations - About 2 hrs to fix
external/source/shellcode/windows/x64/build.py on lines 91..94
external/source/shellcode/windows/x64/build.py on lines 95..98
external/source/shellcode/windows/x64/build.py on lines 103..106

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            for root, dirs, files in os.walk('./src/migrate/'):
                for name in files:
                    if name[-4:] == '.asm':
                        build(name[:-4])
Severity: Major
Found in external/source/shellcode/windows/x64/build.py and 3 other locations - About 2 hrs to fix
external/source/shellcode/windows/x64/build.py on lines 95..98
external/source/shellcode/windows/x64/build.py on lines 99..102
external/source/shellcode/windows/x64/build.py on lines 103..106

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  def get_target(agent)
    #If the user is already specified by the user, we'll just use that
    return target if target.name != 'Automatic'

    nt = agent.scan(/Windows NT (\d\.\d)/).flatten[0] || ''
Severity: Major
Found in modules/exploits/windows/browser/quickr_qp2_bof.rb and 8 other locations - About 2 hrs to fix
modules/exploits/windows/browser/crystal_reports_printcontrol.rb on lines 109..134
modules/exploits/windows/browser/hp_loadrunner_writefilebinary.rb on lines 82..107
modules/exploits/windows/browser/ie_execcommand_uaf.rb on lines 84..109
modules/exploits/windows/browser/indusoft_issymbol_internationalseparator.rb on lines 83..108
modules/exploits/windows/browser/inotes_dwa85w_bof.rb on lines 88..113
modules/exploits/windows/browser/ms11_081_option.rb on lines 64..89
modules/exploits/windows/browser/novell_groupwise_gwcls1_actvx.rb on lines 83..108
modules/exploits/windows/browser/siemens_solid_edge_selistctrlx.rb on lines 85..110

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  def get_target(agent)
    #If the user is already specified by the user, we'll just use that
    return target if target.name != 'Automatic'

    nt = agent.scan(/Windows NT (\d\.\d)/).flatten[0] || ''
Severity: Major
Found in modules/exploits/windows/browser/inotes_dwa85w_bof.rb and 8 other locations - About 2 hrs to fix
modules/exploits/windows/browser/crystal_reports_printcontrol.rb on lines 109..134
modules/exploits/windows/browser/hp_loadrunner_writefilebinary.rb on lines 82..107
modules/exploits/windows/browser/ie_execcommand_uaf.rb on lines 84..109
modules/exploits/windows/browser/indusoft_issymbol_internationalseparator.rb on lines 83..108
modules/exploits/windows/browser/ms11_081_option.rb on lines 64..89
modules/exploits/windows/browser/novell_groupwise_gwcls1_actvx.rb on lines 83..108
modules/exploits/windows/browser/quickr_qp2_bof.rb on lines 86..111
modules/exploits/windows/browser/siemens_solid_edge_selistctrlx.rb on lines 85..110

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  def get_target(agent)
    #If the user is already specified by the user, we'll just use that
    return target if target.name != 'Automatic'

    nt = agent.scan(/Windows NT (\d\.\d)/).flatten[0] || ''
Severity: Major
Found in modules/exploits/windows/browser/ie_execcommand_uaf.rb and 8 other locations - About 2 hrs to fix
modules/exploits/windows/browser/crystal_reports_printcontrol.rb on lines 109..134
modules/exploits/windows/browser/hp_loadrunner_writefilebinary.rb on lines 82..107
modules/exploits/windows/browser/indusoft_issymbol_internationalseparator.rb on lines 83..108
modules/exploits/windows/browser/inotes_dwa85w_bof.rb on lines 88..113
modules/exploits/windows/browser/ms11_081_option.rb on lines 64..89
modules/exploits/windows/browser/novell_groupwise_gwcls1_actvx.rb on lines 83..108
modules/exploits/windows/browser/quickr_qp2_bof.rb on lines 86..111
modules/exploits/windows/browser/siemens_solid_edge_selistctrlx.rb on lines 85..110

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  def get_target(agent)
    #If the user is already specified by the user, we'll just use that
    return target if target.name != 'Automatic'

    nt = agent.scan(/Windows NT (\d\.\d)/).flatten[0] || ''
Severity: Major
Found in modules/exploits/windows/browser/novell_groupwise_gwcls1_actvx.rb and 8 other locations - About 2 hrs to fix
modules/exploits/windows/browser/crystal_reports_printcontrol.rb on lines 109..134
modules/exploits/windows/browser/hp_loadrunner_writefilebinary.rb on lines 82..107
modules/exploits/windows/browser/ie_execcommand_uaf.rb on lines 84..109
modules/exploits/windows/browser/indusoft_issymbol_internationalseparator.rb on lines 83..108
modules/exploits/windows/browser/inotes_dwa85w_bof.rb on lines 88..113
modules/exploits/windows/browser/ms11_081_option.rb on lines 64..89
modules/exploits/windows/browser/quickr_qp2_bof.rb on lines 86..111
modules/exploits/windows/browser/siemens_solid_edge_selistctrlx.rb on lines 85..110

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  def get_target(agent)
    #If the user is already specified by the user, we'll just use that
    return target if target.name != 'Automatic'

    nt = agent.scan(/Windows NT (\d\.\d)/).flatten[0] || ''
Severity: Major
Found in modules/exploits/windows/browser/ms11_081_option.rb and 8 other locations - About 2 hrs to fix
modules/exploits/windows/browser/crystal_reports_printcontrol.rb on lines 109..134
modules/exploits/windows/browser/hp_loadrunner_writefilebinary.rb on lines 82..107
modules/exploits/windows/browser/ie_execcommand_uaf.rb on lines 84..109
modules/exploits/windows/browser/indusoft_issymbol_internationalseparator.rb on lines 83..108
modules/exploits/windows/browser/inotes_dwa85w_bof.rb on lines 88..113
modules/exploits/windows/browser/novell_groupwise_gwcls1_actvx.rb on lines 83..108
modules/exploits/windows/browser/quickr_qp2_bof.rb on lines 86..111
modules/exploits/windows/browser/siemens_solid_edge_selistctrlx.rb on lines 85..110

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  def get_target(agent)
    #If the user is already specified by the user, we'll just use that
    return target if target.name != 'Automatic'

    nt = agent.scan(/Windows NT (\d\.\d)/).flatten[0] || ''
Severity: Major
Found in modules/exploits/windows/browser/hp_loadrunner_writefilebinary.rb and 8 other locations - About 2 hrs to fix
modules/exploits/windows/browser/crystal_reports_printcontrol.rb on lines 109..134
modules/exploits/windows/browser/ie_execcommand_uaf.rb on lines 84..109
modules/exploits/windows/browser/indusoft_issymbol_internationalseparator.rb on lines 83..108
modules/exploits/windows/browser/inotes_dwa85w_bof.rb on lines 88..113
modules/exploits/windows/browser/ms11_081_option.rb on lines 64..89
modules/exploits/windows/browser/novell_groupwise_gwcls1_actvx.rb on lines 83..108
modules/exploits/windows/browser/quickr_qp2_bof.rb on lines 86..111
modules/exploits/windows/browser/siemens_solid_edge_selistctrlx.rb on lines 85..110

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  def get_target(agent)
    #If the user is already specified by the user, we'll just use that
    return target if target.name != 'Automatic'

    nt = agent.scan(/Windows NT (\d\.\d)/).flatten[0] || ''
Severity: Major
Found in modules/exploits/windows/browser/indusoft_issymbol_internationalseparator.rb and 8 other locations - About 2 hrs to fix
modules/exploits/windows/browser/crystal_reports_printcontrol.rb on lines 109..134
modules/exploits/windows/browser/hp_loadrunner_writefilebinary.rb on lines 82..107
modules/exploits/windows/browser/ie_execcommand_uaf.rb on lines 84..109
modules/exploits/windows/browser/inotes_dwa85w_bof.rb on lines 88..113
modules/exploits/windows/browser/ms11_081_option.rb on lines 64..89
modules/exploits/windows/browser/novell_groupwise_gwcls1_actvx.rb on lines 83..108
modules/exploits/windows/browser/quickr_qp2_bof.rb on lines 86..111
modules/exploits/windows/browser/siemens_solid_edge_selistctrlx.rb on lines 85..110

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  def get_target(agent)
    #If the user is already specified by the user, we'll just use that
    return target if target.name != 'Automatic'

    nt = agent.scan(/Windows NT (\d\.\d)/).flatten[0] || ''
Severity: Major
Found in modules/exploits/windows/browser/siemens_solid_edge_selistctrlx.rb and 8 other locations - About 2 hrs to fix
modules/exploits/windows/browser/crystal_reports_printcontrol.rb on lines 109..134
modules/exploits/windows/browser/hp_loadrunner_writefilebinary.rb on lines 82..107
modules/exploits/windows/browser/ie_execcommand_uaf.rb on lines 84..109
modules/exploits/windows/browser/indusoft_issymbol_internationalseparator.rb on lines 83..108
modules/exploits/windows/browser/inotes_dwa85w_bof.rb on lines 88..113
modules/exploits/windows/browser/ms11_081_option.rb on lines 64..89
modules/exploits/windows/browser/novell_groupwise_gwcls1_actvx.rb on lines 83..108
modules/exploits/windows/browser/quickr_qp2_bof.rb on lines 86..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  def get_target(agent)
    #If the user is already specified by the user, we'll just use that
    return target if target.name != 'Automatic'

    nt = agent.scan(/Windows NT (\d\.\d)/).flatten[0] || ''
Severity: Major
Found in modules/exploits/windows/browser/crystal_reports_printcontrol.rb and 8 other locations - About 2 hrs to fix
modules/exploits/windows/browser/hp_loadrunner_writefilebinary.rb on lines 82..107
modules/exploits/windows/browser/ie_execcommand_uaf.rb on lines 84..109
modules/exploits/windows/browser/indusoft_issymbol_internationalseparator.rb on lines 83..108
modules/exploits/windows/browser/inotes_dwa85w_bof.rb on lines 88..113
modules/exploits/windows/browser/ms11_081_option.rb on lines 64..89
modules/exploits/windows/browser/novell_groupwise_gwcls1_actvx.rb on lines 83..108
modules/exploits/windows/browser/quickr_qp2_bof.rb on lines 86..111
modules/exploits/windows/browser/siemens_solid_edge_selistctrlx.rb on lines 85..110

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

      when action.name == 'LISTAPPSSDCARD'
        res = http_post('listAppsSdcard')
        unless res
          print_error("#{peer}- Error Connecting")
          return
Severity: Major
Found in modules/auxiliary/scanner/http/es_file_explorer_open_port.rb and 4 other locations - About 2 hrs to fix
modules/auxiliary/scanner/http/es_file_explorer_open_port.rb on lines 148..165
modules/auxiliary/scanner/http/es_file_explorer_open_port.rb on lines 166..183
modules/auxiliary/scanner/http/es_file_explorer_open_port.rb on lines 184..201
modules/auxiliary/scanner/http/es_file_explorer_open_port.rb on lines 220..237

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

      when action.name == 'LISTAPPS'
        res = http_post('listApps')
        unless res
          print_error("#{peer}- Error Connecting")
          return
Severity: Major
Found in modules/auxiliary/scanner/http/es_file_explorer_open_port.rb and 4 other locations - About 2 hrs to fix
modules/auxiliary/scanner/http/es_file_explorer_open_port.rb on lines 166..183
modules/auxiliary/scanner/http/es_file_explorer_open_port.rb on lines 184..201
modules/auxiliary/scanner/http/es_file_explorer_open_port.rb on lines 202..219
modules/auxiliary/scanner/http/es_file_explorer_open_port.rb on lines 220..237

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

      when action.name == 'LISTAPPSPHONE'
        res = http_post('listAppsPhone')
        unless res
          print_error("#{peer}- Error Connecting")
          return
Severity: Major
Found in modules/auxiliary/scanner/http/es_file_explorer_open_port.rb and 4 other locations - About 2 hrs to fix
modules/auxiliary/scanner/http/es_file_explorer_open_port.rb on lines 148..165
modules/auxiliary/scanner/http/es_file_explorer_open_port.rb on lines 166..183
modules/auxiliary/scanner/http/es_file_explorer_open_port.rb on lines 202..219
modules/auxiliary/scanner/http/es_file_explorer_open_port.rb on lines 220..237

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

      when action.name == 'LISTAPPSALL'
        res = http_post('listAppsAll')
        unless res
          print_error("#{peer}- Error Connecting")
          return
Severity: Major
Found in modules/auxiliary/scanner/http/es_file_explorer_open_port.rb and 4 other locations - About 2 hrs to fix
modules/auxiliary/scanner/http/es_file_explorer_open_port.rb on lines 148..165
modules/auxiliary/scanner/http/es_file_explorer_open_port.rb on lines 166..183
modules/auxiliary/scanner/http/es_file_explorer_open_port.rb on lines 184..201
modules/auxiliary/scanner/http/es_file_explorer_open_port.rb on lines 202..219

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

      when action.name == 'LISTAPPSSYSTEM'
        res = http_post('listAppsSystem')
        unless res
          print_error("#{peer}- Error Connecting")
          return
Severity: Major
Found in modules/auxiliary/scanner/http/es_file_explorer_open_port.rb and 4 other locations - About 2 hrs to fix
modules/auxiliary/scanner/http/es_file_explorer_open_port.rb on lines 148..165
modules/auxiliary/scanner/http/es_file_explorer_open_port.rb on lines 184..201
modules/auxiliary/scanner/http/es_file_explorer_open_port.rb on lines 202..219
modules/auxiliary/scanner/http/es_file_explorer_open_port.rb on lines 220..237

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  def cmd_channel_bw(*args)
    self.idx ||= 0
    bandwidth = -1
    mhz = nil
    arg = {}
Severity: Major
Found in lib/rex/post/hwbridge/ui/console/command_dispatcher/rftransceiver.rb and 2 other locations - About 2 hrs to fix
lib/rex/post/hwbridge/ui/console/command_dispatcher/rftransceiver.rb on lines 404..432
lib/rex/post/hwbridge/ui/console/command_dispatcher/rftransceiver.rb on lines 438..466

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  def cmd_deviation(*args)
    self.idx ||= 0
    deviat = -1
    mhz = nil
    arg = {}
Severity: Major
Found in lib/rex/post/hwbridge/ui/console/command_dispatcher/rftransceiver.rb and 2 other locations - About 2 hrs to fix
lib/rex/post/hwbridge/ui/console/command_dispatcher/rftransceiver.rb on lines 370..398
lib/rex/post/hwbridge/ui/console/command_dispatcher/rftransceiver.rb on lines 404..432

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  def cmd_baud(*args)
    self.idx ||= 0
    baud = -1
    mhz = nil
    arg = {}
Severity: Major
Found in lib/rex/post/hwbridge/ui/console/command_dispatcher/rftransceiver.rb and 2 other locations - About 2 hrs to fix
lib/rex/post/hwbridge/ui/console/command_dispatcher/rftransceiver.rb on lines 370..398
lib/rex/post/hwbridge/ui/console/command_dispatcher/rftransceiver.rb on lines 438..466

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language