Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star

Showing 7,361 of 22,177 total issues

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def report_cred(opts)
    service_data = {
      address: opts[:ip],
      port: opts[:port],
      service_name: opts[:service_name],
Severity: Major
Found in modules/auxiliary/scanner/msf/msf_rpc_login.rb and 24 other locations - About 1 hr to fix
lib/msf/core/auxiliary/cnpilot.rb on lines 15..39
lib/msf/core/auxiliary/epmp.rb on lines 15..39
modules/auxiliary/admin/scada/modicon_password_recovery.rb on lines 91..115
modules/auxiliary/scanner/http/binom3_login_config_pass_dump.rb on lines 55..79
modules/auxiliary/scanner/http/gavazzi_em_login_loot.rb on lines 86..110
modules/auxiliary/scanner/http/meteocontrol_weblog_extractadmin.rb on lines 107..131
modules/auxiliary/scanner/http/oracle_ilom_login.rb on lines 70..94
modules/auxiliary/scanner/http/pocketpad_login.rb on lines 65..89
modules/auxiliary/scanner/http/rfcode_reader_enum.rb on lines 144..168
modules/auxiliary/scanner/http/sap_businessobjects_user_brute_web.rb on lines 44..68
modules/auxiliary/scanner/http/sentry_cdu_enum.rb on lines 70..94
modules/auxiliary/scanner/http/sevone_enum.rb on lines 66..90
modules/auxiliary/scanner/http/typo3_bruteforce.rb on lines 39..63
modules/auxiliary/scanner/lotus/lotus_domino_login.rb on lines 31..55
modules/auxiliary/scanner/misc/oki_scanner.rb on lines 38..62
modules/auxiliary/scanner/mongodb/mongodb_login.rb on lines 132..156
modules/auxiliary/scanner/msf/msf_web_login.rb on lines 140..164
modules/auxiliary/scanner/nessus/nessus_ntp_login.rb on lines 59..83
modules/auxiliary/scanner/nexpose/nexpose_api_login.rb on lines 58..82
modules/auxiliary/scanner/nntp/nntp_login.rb on lines 167..185
modules/auxiliary/scanner/openvas/openvas_omp_login.rb on lines 56..80
modules/auxiliary/scanner/openvas/openvas_otp_login.rb on lines 56..80
modules/auxiliary/scanner/sap/sap_soap_rfc_brute_login.rb on lines 103..127
modules/auxiliary/scanner/sap/sap_web_gui_brute_login.rb on lines 107..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def report_cred(opts)
    service_data = {
      address: opts[:ip],
      port: opts[:port],
      service_name: opts[:service_name],
Severity: Major
Found in modules/auxiliary/scanner/lotus/lotus_domino_login.rb and 24 other locations - About 1 hr to fix
lib/msf/core/auxiliary/cnpilot.rb on lines 15..39
lib/msf/core/auxiliary/epmp.rb on lines 15..39
modules/auxiliary/admin/scada/modicon_password_recovery.rb on lines 91..115
modules/auxiliary/scanner/http/binom3_login_config_pass_dump.rb on lines 55..79
modules/auxiliary/scanner/http/gavazzi_em_login_loot.rb on lines 86..110
modules/auxiliary/scanner/http/meteocontrol_weblog_extractadmin.rb on lines 107..131
modules/auxiliary/scanner/http/oracle_ilom_login.rb on lines 70..94
modules/auxiliary/scanner/http/pocketpad_login.rb on lines 65..89
modules/auxiliary/scanner/http/rfcode_reader_enum.rb on lines 144..168
modules/auxiliary/scanner/http/sap_businessobjects_user_brute_web.rb on lines 44..68
modules/auxiliary/scanner/http/sentry_cdu_enum.rb on lines 70..94
modules/auxiliary/scanner/http/sevone_enum.rb on lines 66..90
modules/auxiliary/scanner/http/typo3_bruteforce.rb on lines 39..63
modules/auxiliary/scanner/misc/oki_scanner.rb on lines 38..62
modules/auxiliary/scanner/mongodb/mongodb_login.rb on lines 132..156
modules/auxiliary/scanner/msf/msf_rpc_login.rb on lines 55..79
modules/auxiliary/scanner/msf/msf_web_login.rb on lines 140..164
modules/auxiliary/scanner/nessus/nessus_ntp_login.rb on lines 59..83
modules/auxiliary/scanner/nexpose/nexpose_api_login.rb on lines 58..82
modules/auxiliary/scanner/nntp/nntp_login.rb on lines 167..185
modules/auxiliary/scanner/openvas/openvas_omp_login.rb on lines 56..80
modules/auxiliary/scanner/openvas/openvas_otp_login.rb on lines 56..80
modules/auxiliary/scanner/sap/sap_soap_rfc_brute_login.rb on lines 103..127
modules/auxiliary/scanner/sap/sap_web_gui_brute_login.rb on lines 107..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def report_cred(opts)
    service_data = {
      address: opts[:ip],
      port: opts[:port],
      service_name: opts[:service_name],
Severity: Major
Found in modules/auxiliary/scanner/sap/sap_soap_rfc_brute_login.rb and 24 other locations - About 1 hr to fix
lib/msf/core/auxiliary/cnpilot.rb on lines 15..39
lib/msf/core/auxiliary/epmp.rb on lines 15..39
modules/auxiliary/admin/scada/modicon_password_recovery.rb on lines 91..115
modules/auxiliary/scanner/http/binom3_login_config_pass_dump.rb on lines 55..79
modules/auxiliary/scanner/http/gavazzi_em_login_loot.rb on lines 86..110
modules/auxiliary/scanner/http/meteocontrol_weblog_extractadmin.rb on lines 107..131
modules/auxiliary/scanner/http/oracle_ilom_login.rb on lines 70..94
modules/auxiliary/scanner/http/pocketpad_login.rb on lines 65..89
modules/auxiliary/scanner/http/rfcode_reader_enum.rb on lines 144..168
modules/auxiliary/scanner/http/sap_businessobjects_user_brute_web.rb on lines 44..68
modules/auxiliary/scanner/http/sentry_cdu_enum.rb on lines 70..94
modules/auxiliary/scanner/http/sevone_enum.rb on lines 66..90
modules/auxiliary/scanner/http/typo3_bruteforce.rb on lines 39..63
modules/auxiliary/scanner/lotus/lotus_domino_login.rb on lines 31..55
modules/auxiliary/scanner/misc/oki_scanner.rb on lines 38..62
modules/auxiliary/scanner/mongodb/mongodb_login.rb on lines 132..156
modules/auxiliary/scanner/msf/msf_rpc_login.rb on lines 55..79
modules/auxiliary/scanner/msf/msf_web_login.rb on lines 140..164
modules/auxiliary/scanner/nessus/nessus_ntp_login.rb on lines 59..83
modules/auxiliary/scanner/nexpose/nexpose_api_login.rb on lines 58..82
modules/auxiliary/scanner/nntp/nntp_login.rb on lines 167..185
modules/auxiliary/scanner/openvas/openvas_omp_login.rb on lines 56..80
modules/auxiliary/scanner/openvas/openvas_otp_login.rb on lines 56..80
modules/auxiliary/scanner/sap/sap_web_gui_brute_login.rb on lines 107..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def report_cred(opts)
    service_data = {
      address: opts[:ip],
      port: opts[:port],
      service_name: opts[:service_name],
Severity: Major
Found in modules/auxiliary/scanner/msf/msf_web_login.rb and 24 other locations - About 1 hr to fix
lib/msf/core/auxiliary/cnpilot.rb on lines 15..39
lib/msf/core/auxiliary/epmp.rb on lines 15..39
modules/auxiliary/admin/scada/modicon_password_recovery.rb on lines 91..115
modules/auxiliary/scanner/http/binom3_login_config_pass_dump.rb on lines 55..79
modules/auxiliary/scanner/http/gavazzi_em_login_loot.rb on lines 86..110
modules/auxiliary/scanner/http/meteocontrol_weblog_extractadmin.rb on lines 107..131
modules/auxiliary/scanner/http/oracle_ilom_login.rb on lines 70..94
modules/auxiliary/scanner/http/pocketpad_login.rb on lines 65..89
modules/auxiliary/scanner/http/rfcode_reader_enum.rb on lines 144..168
modules/auxiliary/scanner/http/sap_businessobjects_user_brute_web.rb on lines 44..68
modules/auxiliary/scanner/http/sentry_cdu_enum.rb on lines 70..94
modules/auxiliary/scanner/http/sevone_enum.rb on lines 66..90
modules/auxiliary/scanner/http/typo3_bruteforce.rb on lines 39..63
modules/auxiliary/scanner/lotus/lotus_domino_login.rb on lines 31..55
modules/auxiliary/scanner/misc/oki_scanner.rb on lines 38..62
modules/auxiliary/scanner/mongodb/mongodb_login.rb on lines 132..156
modules/auxiliary/scanner/msf/msf_rpc_login.rb on lines 55..79
modules/auxiliary/scanner/nessus/nessus_ntp_login.rb on lines 59..83
modules/auxiliary/scanner/nexpose/nexpose_api_login.rb on lines 58..82
modules/auxiliary/scanner/nntp/nntp_login.rb on lines 167..185
modules/auxiliary/scanner/openvas/openvas_omp_login.rb on lines 56..80
modules/auxiliary/scanner/openvas/openvas_otp_login.rb on lines 56..80
modules/auxiliary/scanner/sap/sap_soap_rfc_brute_login.rb on lines 103..127
modules/auxiliary/scanner/sap/sap_web_gui_brute_login.rb on lines 107..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def report_cred(opts)
    service_data = {
      address: opts[:ip],
      port: opts[:port],
      service_name: opts[:service_name],
Severity: Major
Found in modules/auxiliary/scanner/openvas/openvas_omp_login.rb and 24 other locations - About 1 hr to fix
lib/msf/core/auxiliary/cnpilot.rb on lines 15..39
lib/msf/core/auxiliary/epmp.rb on lines 15..39
modules/auxiliary/admin/scada/modicon_password_recovery.rb on lines 91..115
modules/auxiliary/scanner/http/binom3_login_config_pass_dump.rb on lines 55..79
modules/auxiliary/scanner/http/gavazzi_em_login_loot.rb on lines 86..110
modules/auxiliary/scanner/http/meteocontrol_weblog_extractadmin.rb on lines 107..131
modules/auxiliary/scanner/http/oracle_ilom_login.rb on lines 70..94
modules/auxiliary/scanner/http/pocketpad_login.rb on lines 65..89
modules/auxiliary/scanner/http/rfcode_reader_enum.rb on lines 144..168
modules/auxiliary/scanner/http/sap_businessobjects_user_brute_web.rb on lines 44..68
modules/auxiliary/scanner/http/sentry_cdu_enum.rb on lines 70..94
modules/auxiliary/scanner/http/sevone_enum.rb on lines 66..90
modules/auxiliary/scanner/http/typo3_bruteforce.rb on lines 39..63
modules/auxiliary/scanner/lotus/lotus_domino_login.rb on lines 31..55
modules/auxiliary/scanner/misc/oki_scanner.rb on lines 38..62
modules/auxiliary/scanner/mongodb/mongodb_login.rb on lines 132..156
modules/auxiliary/scanner/msf/msf_rpc_login.rb on lines 55..79
modules/auxiliary/scanner/msf/msf_web_login.rb on lines 140..164
modules/auxiliary/scanner/nessus/nessus_ntp_login.rb on lines 59..83
modules/auxiliary/scanner/nexpose/nexpose_api_login.rb on lines 58..82
modules/auxiliary/scanner/nntp/nntp_login.rb on lines 167..185
modules/auxiliary/scanner/openvas/openvas_otp_login.rb on lines 56..80
modules/auxiliary/scanner/sap/sap_soap_rfc_brute_login.rb on lines 103..127
modules/auxiliary/scanner/sap/sap_web_gui_brute_login.rb on lines 107..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def report_cred(opts)
    service_data = {
      address: opts[:ip],
      port: opts[:port],
      service_name: opts[:service_name],
Severity: Major
Found in modules/auxiliary/scanner/http/binom3_login_config_pass_dump.rb and 24 other locations - About 1 hr to fix
lib/msf/core/auxiliary/cnpilot.rb on lines 15..39
lib/msf/core/auxiliary/epmp.rb on lines 15..39
modules/auxiliary/admin/scada/modicon_password_recovery.rb on lines 91..115
modules/auxiliary/scanner/http/gavazzi_em_login_loot.rb on lines 86..110
modules/auxiliary/scanner/http/meteocontrol_weblog_extractadmin.rb on lines 107..131
modules/auxiliary/scanner/http/oracle_ilom_login.rb on lines 70..94
modules/auxiliary/scanner/http/pocketpad_login.rb on lines 65..89
modules/auxiliary/scanner/http/rfcode_reader_enum.rb on lines 144..168
modules/auxiliary/scanner/http/sap_businessobjects_user_brute_web.rb on lines 44..68
modules/auxiliary/scanner/http/sentry_cdu_enum.rb on lines 70..94
modules/auxiliary/scanner/http/sevone_enum.rb on lines 66..90
modules/auxiliary/scanner/http/typo3_bruteforce.rb on lines 39..63
modules/auxiliary/scanner/lotus/lotus_domino_login.rb on lines 31..55
modules/auxiliary/scanner/misc/oki_scanner.rb on lines 38..62
modules/auxiliary/scanner/mongodb/mongodb_login.rb on lines 132..156
modules/auxiliary/scanner/msf/msf_rpc_login.rb on lines 55..79
modules/auxiliary/scanner/msf/msf_web_login.rb on lines 140..164
modules/auxiliary/scanner/nessus/nessus_ntp_login.rb on lines 59..83
modules/auxiliary/scanner/nexpose/nexpose_api_login.rb on lines 58..82
modules/auxiliary/scanner/nntp/nntp_login.rb on lines 167..185
modules/auxiliary/scanner/openvas/openvas_omp_login.rb on lines 56..80
modules/auxiliary/scanner/openvas/openvas_otp_login.rb on lines 56..80
modules/auxiliary/scanner/sap/sap_soap_rfc_brute_login.rb on lines 103..127
modules/auxiliary/scanner/sap/sap_web_gui_brute_login.rb on lines 107..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def report_cred(opts)
    service_data = {
      address: opts[:ip],
      port: opts[:port],
      service_name: opts[:service_name],
Severity: Major
Found in modules/auxiliary/scanner/http/typo3_bruteforce.rb and 24 other locations - About 1 hr to fix
lib/msf/core/auxiliary/cnpilot.rb on lines 15..39
lib/msf/core/auxiliary/epmp.rb on lines 15..39
modules/auxiliary/admin/scada/modicon_password_recovery.rb on lines 91..115
modules/auxiliary/scanner/http/binom3_login_config_pass_dump.rb on lines 55..79
modules/auxiliary/scanner/http/gavazzi_em_login_loot.rb on lines 86..110
modules/auxiliary/scanner/http/meteocontrol_weblog_extractadmin.rb on lines 107..131
modules/auxiliary/scanner/http/oracle_ilom_login.rb on lines 70..94
modules/auxiliary/scanner/http/pocketpad_login.rb on lines 65..89
modules/auxiliary/scanner/http/rfcode_reader_enum.rb on lines 144..168
modules/auxiliary/scanner/http/sap_businessobjects_user_brute_web.rb on lines 44..68
modules/auxiliary/scanner/http/sentry_cdu_enum.rb on lines 70..94
modules/auxiliary/scanner/http/sevone_enum.rb on lines 66..90
modules/auxiliary/scanner/lotus/lotus_domino_login.rb on lines 31..55
modules/auxiliary/scanner/misc/oki_scanner.rb on lines 38..62
modules/auxiliary/scanner/mongodb/mongodb_login.rb on lines 132..156
modules/auxiliary/scanner/msf/msf_rpc_login.rb on lines 55..79
modules/auxiliary/scanner/msf/msf_web_login.rb on lines 140..164
modules/auxiliary/scanner/nessus/nessus_ntp_login.rb on lines 59..83
modules/auxiliary/scanner/nexpose/nexpose_api_login.rb on lines 58..82
modules/auxiliary/scanner/nntp/nntp_login.rb on lines 167..185
modules/auxiliary/scanner/openvas/openvas_omp_login.rb on lines 56..80
modules/auxiliary/scanner/openvas/openvas_otp_login.rb on lines 56..80
modules/auxiliary/scanner/sap/sap_soap_rfc_brute_login.rb on lines 103..127
modules/auxiliary/scanner/sap/sap_web_gui_brute_login.rb on lines 107..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def report_cred(opts)
    service_data = {
      address: opts[:ip],
      port: opts[:port],
      service_name: opts[:service_name],
Severity: Major
Found in modules/auxiliary/scanner/misc/oki_scanner.rb and 24 other locations - About 1 hr to fix
lib/msf/core/auxiliary/cnpilot.rb on lines 15..39
lib/msf/core/auxiliary/epmp.rb on lines 15..39
modules/auxiliary/admin/scada/modicon_password_recovery.rb on lines 91..115
modules/auxiliary/scanner/http/binom3_login_config_pass_dump.rb on lines 55..79
modules/auxiliary/scanner/http/gavazzi_em_login_loot.rb on lines 86..110
modules/auxiliary/scanner/http/meteocontrol_weblog_extractadmin.rb on lines 107..131
modules/auxiliary/scanner/http/oracle_ilom_login.rb on lines 70..94
modules/auxiliary/scanner/http/pocketpad_login.rb on lines 65..89
modules/auxiliary/scanner/http/rfcode_reader_enum.rb on lines 144..168
modules/auxiliary/scanner/http/sap_businessobjects_user_brute_web.rb on lines 44..68
modules/auxiliary/scanner/http/sentry_cdu_enum.rb on lines 70..94
modules/auxiliary/scanner/http/sevone_enum.rb on lines 66..90
modules/auxiliary/scanner/http/typo3_bruteforce.rb on lines 39..63
modules/auxiliary/scanner/lotus/lotus_domino_login.rb on lines 31..55
modules/auxiliary/scanner/mongodb/mongodb_login.rb on lines 132..156
modules/auxiliary/scanner/msf/msf_rpc_login.rb on lines 55..79
modules/auxiliary/scanner/msf/msf_web_login.rb on lines 140..164
modules/auxiliary/scanner/nessus/nessus_ntp_login.rb on lines 59..83
modules/auxiliary/scanner/nexpose/nexpose_api_login.rb on lines 58..82
modules/auxiliary/scanner/nntp/nntp_login.rb on lines 167..185
modules/auxiliary/scanner/openvas/openvas_omp_login.rb on lines 56..80
modules/auxiliary/scanner/openvas/openvas_otp_login.rb on lines 56..80
modules/auxiliary/scanner/sap/sap_soap_rfc_brute_login.rb on lines 103..127
modules/auxiliary/scanner/sap/sap_web_gui_brute_login.rb on lines 107..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def report_cred(opts)
    service_data = { address: opts[:ip],
                     port: opts[:port],
                     service_name: opts[:service_name],
                     protocol: 'tcp',
Severity: Major
Found in modules/auxiliary/scanner/nntp/nntp_login.rb and 24 other locations - About 1 hr to fix
lib/msf/core/auxiliary/cnpilot.rb on lines 15..39
lib/msf/core/auxiliary/epmp.rb on lines 15..39
modules/auxiliary/admin/scada/modicon_password_recovery.rb on lines 91..115
modules/auxiliary/scanner/http/binom3_login_config_pass_dump.rb on lines 55..79
modules/auxiliary/scanner/http/gavazzi_em_login_loot.rb on lines 86..110
modules/auxiliary/scanner/http/meteocontrol_weblog_extractadmin.rb on lines 107..131
modules/auxiliary/scanner/http/oracle_ilom_login.rb on lines 70..94
modules/auxiliary/scanner/http/pocketpad_login.rb on lines 65..89
modules/auxiliary/scanner/http/rfcode_reader_enum.rb on lines 144..168
modules/auxiliary/scanner/http/sap_businessobjects_user_brute_web.rb on lines 44..68
modules/auxiliary/scanner/http/sentry_cdu_enum.rb on lines 70..94
modules/auxiliary/scanner/http/sevone_enum.rb on lines 66..90
modules/auxiliary/scanner/http/typo3_bruteforce.rb on lines 39..63
modules/auxiliary/scanner/lotus/lotus_domino_login.rb on lines 31..55
modules/auxiliary/scanner/misc/oki_scanner.rb on lines 38..62
modules/auxiliary/scanner/mongodb/mongodb_login.rb on lines 132..156
modules/auxiliary/scanner/msf/msf_rpc_login.rb on lines 55..79
modules/auxiliary/scanner/msf/msf_web_login.rb on lines 140..164
modules/auxiliary/scanner/nessus/nessus_ntp_login.rb on lines 59..83
modules/auxiliary/scanner/nexpose/nexpose_api_login.rb on lines 58..82
modules/auxiliary/scanner/openvas/openvas_omp_login.rb on lines 56..80
modules/auxiliary/scanner/openvas/openvas_otp_login.rb on lines 56..80
modules/auxiliary/scanner/sap/sap_soap_rfc_brute_login.rb on lines 103..127
modules/auxiliary/scanner/sap/sap_web_gui_brute_login.rb on lines 107..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def report_cred(opts)
    service_data = {
      address: opts[:ip],
      port: opts[:port],
      service_name: opts[:service_name],
Severity: Major
Found in modules/auxiliary/scanner/openvas/openvas_otp_login.rb and 24 other locations - About 1 hr to fix
lib/msf/core/auxiliary/cnpilot.rb on lines 15..39
lib/msf/core/auxiliary/epmp.rb on lines 15..39
modules/auxiliary/admin/scada/modicon_password_recovery.rb on lines 91..115
modules/auxiliary/scanner/http/binom3_login_config_pass_dump.rb on lines 55..79
modules/auxiliary/scanner/http/gavazzi_em_login_loot.rb on lines 86..110
modules/auxiliary/scanner/http/meteocontrol_weblog_extractadmin.rb on lines 107..131
modules/auxiliary/scanner/http/oracle_ilom_login.rb on lines 70..94
modules/auxiliary/scanner/http/pocketpad_login.rb on lines 65..89
modules/auxiliary/scanner/http/rfcode_reader_enum.rb on lines 144..168
modules/auxiliary/scanner/http/sap_businessobjects_user_brute_web.rb on lines 44..68
modules/auxiliary/scanner/http/sentry_cdu_enum.rb on lines 70..94
modules/auxiliary/scanner/http/sevone_enum.rb on lines 66..90
modules/auxiliary/scanner/http/typo3_bruteforce.rb on lines 39..63
modules/auxiliary/scanner/lotus/lotus_domino_login.rb on lines 31..55
modules/auxiliary/scanner/misc/oki_scanner.rb on lines 38..62
modules/auxiliary/scanner/mongodb/mongodb_login.rb on lines 132..156
modules/auxiliary/scanner/msf/msf_rpc_login.rb on lines 55..79
modules/auxiliary/scanner/msf/msf_web_login.rb on lines 140..164
modules/auxiliary/scanner/nessus/nessus_ntp_login.rb on lines 59..83
modules/auxiliary/scanner/nexpose/nexpose_api_login.rb on lines 58..82
modules/auxiliary/scanner/nntp/nntp_login.rb on lines 167..185
modules/auxiliary/scanner/openvas/openvas_omp_login.rb on lines 56..80
modules/auxiliary/scanner/sap/sap_soap_rfc_brute_login.rb on lines 103..127
modules/auxiliary/scanner/sap/sap_web_gui_brute_login.rb on lines 107..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def report_cred(opts)
    service_data = {
      address: opts[:ip],
      port: opts[:port],
      service_name: opts[:service_name],
Severity: Major
Found in modules/auxiliary/scanner/http/rfcode_reader_enum.rb and 24 other locations - About 1 hr to fix
lib/msf/core/auxiliary/cnpilot.rb on lines 15..39
lib/msf/core/auxiliary/epmp.rb on lines 15..39
modules/auxiliary/admin/scada/modicon_password_recovery.rb on lines 91..115
modules/auxiliary/scanner/http/binom3_login_config_pass_dump.rb on lines 55..79
modules/auxiliary/scanner/http/gavazzi_em_login_loot.rb on lines 86..110
modules/auxiliary/scanner/http/meteocontrol_weblog_extractadmin.rb on lines 107..131
modules/auxiliary/scanner/http/oracle_ilom_login.rb on lines 70..94
modules/auxiliary/scanner/http/pocketpad_login.rb on lines 65..89
modules/auxiliary/scanner/http/sap_businessobjects_user_brute_web.rb on lines 44..68
modules/auxiliary/scanner/http/sentry_cdu_enum.rb on lines 70..94
modules/auxiliary/scanner/http/sevone_enum.rb on lines 66..90
modules/auxiliary/scanner/http/typo3_bruteforce.rb on lines 39..63
modules/auxiliary/scanner/lotus/lotus_domino_login.rb on lines 31..55
modules/auxiliary/scanner/misc/oki_scanner.rb on lines 38..62
modules/auxiliary/scanner/mongodb/mongodb_login.rb on lines 132..156
modules/auxiliary/scanner/msf/msf_rpc_login.rb on lines 55..79
modules/auxiliary/scanner/msf/msf_web_login.rb on lines 140..164
modules/auxiliary/scanner/nessus/nessus_ntp_login.rb on lines 59..83
modules/auxiliary/scanner/nexpose/nexpose_api_login.rb on lines 58..82
modules/auxiliary/scanner/nntp/nntp_login.rb on lines 167..185
modules/auxiliary/scanner/openvas/openvas_omp_login.rb on lines 56..80
modules/auxiliary/scanner/openvas/openvas_otp_login.rb on lines 56..80
modules/auxiliary/scanner/sap/sap_soap_rfc_brute_login.rb on lines 103..127
modules/auxiliary/scanner/sap/sap_web_gui_brute_login.rb on lines 107..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def report_cred(opts)
    service_data = {
      address: opts[:ip],
      port: opts[:port],
      service_name: opts[:service_name],
Severity: Major
Found in lib/msf/core/auxiliary/epmp.rb and 24 other locations - About 1 hr to fix
lib/msf/core/auxiliary/cnpilot.rb on lines 15..39
modules/auxiliary/admin/scada/modicon_password_recovery.rb on lines 91..115
modules/auxiliary/scanner/http/binom3_login_config_pass_dump.rb on lines 55..79
modules/auxiliary/scanner/http/gavazzi_em_login_loot.rb on lines 86..110
modules/auxiliary/scanner/http/meteocontrol_weblog_extractadmin.rb on lines 107..131
modules/auxiliary/scanner/http/oracle_ilom_login.rb on lines 70..94
modules/auxiliary/scanner/http/pocketpad_login.rb on lines 65..89
modules/auxiliary/scanner/http/rfcode_reader_enum.rb on lines 144..168
modules/auxiliary/scanner/http/sap_businessobjects_user_brute_web.rb on lines 44..68
modules/auxiliary/scanner/http/sentry_cdu_enum.rb on lines 70..94
modules/auxiliary/scanner/http/sevone_enum.rb on lines 66..90
modules/auxiliary/scanner/http/typo3_bruteforce.rb on lines 39..63
modules/auxiliary/scanner/lotus/lotus_domino_login.rb on lines 31..55
modules/auxiliary/scanner/misc/oki_scanner.rb on lines 38..62
modules/auxiliary/scanner/mongodb/mongodb_login.rb on lines 132..156
modules/auxiliary/scanner/msf/msf_rpc_login.rb on lines 55..79
modules/auxiliary/scanner/msf/msf_web_login.rb on lines 140..164
modules/auxiliary/scanner/nessus/nessus_ntp_login.rb on lines 59..83
modules/auxiliary/scanner/nexpose/nexpose_api_login.rb on lines 58..82
modules/auxiliary/scanner/nntp/nntp_login.rb on lines 167..185
modules/auxiliary/scanner/openvas/openvas_omp_login.rb on lines 56..80
modules/auxiliary/scanner/openvas/openvas_otp_login.rb on lines 56..80
modules/auxiliary/scanner/sap/sap_soap_rfc_brute_login.rb on lines 103..127
modules/auxiliary/scanner/sap/sap_web_gui_brute_login.rb on lines 107..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def report_cred(opts)
    service_data = {
      address: opts[:ip],
      port: opts[:port],
      service_name: opts[:service_name],
Severity: Major
Found in lib/msf/core/auxiliary/cnpilot.rb and 24 other locations - About 1 hr to fix
lib/msf/core/auxiliary/epmp.rb on lines 15..39
modules/auxiliary/admin/scada/modicon_password_recovery.rb on lines 91..115
modules/auxiliary/scanner/http/binom3_login_config_pass_dump.rb on lines 55..79
modules/auxiliary/scanner/http/gavazzi_em_login_loot.rb on lines 86..110
modules/auxiliary/scanner/http/meteocontrol_weblog_extractadmin.rb on lines 107..131
modules/auxiliary/scanner/http/oracle_ilom_login.rb on lines 70..94
modules/auxiliary/scanner/http/pocketpad_login.rb on lines 65..89
modules/auxiliary/scanner/http/rfcode_reader_enum.rb on lines 144..168
modules/auxiliary/scanner/http/sap_businessobjects_user_brute_web.rb on lines 44..68
modules/auxiliary/scanner/http/sentry_cdu_enum.rb on lines 70..94
modules/auxiliary/scanner/http/sevone_enum.rb on lines 66..90
modules/auxiliary/scanner/http/typo3_bruteforce.rb on lines 39..63
modules/auxiliary/scanner/lotus/lotus_domino_login.rb on lines 31..55
modules/auxiliary/scanner/misc/oki_scanner.rb on lines 38..62
modules/auxiliary/scanner/mongodb/mongodb_login.rb on lines 132..156
modules/auxiliary/scanner/msf/msf_rpc_login.rb on lines 55..79
modules/auxiliary/scanner/msf/msf_web_login.rb on lines 140..164
modules/auxiliary/scanner/nessus/nessus_ntp_login.rb on lines 59..83
modules/auxiliary/scanner/nexpose/nexpose_api_login.rb on lines 58..82
modules/auxiliary/scanner/nntp/nntp_login.rb on lines 167..185
modules/auxiliary/scanner/openvas/openvas_omp_login.rb on lines 56..80
modules/auxiliary/scanner/openvas/openvas_otp_login.rb on lines 56..80
modules/auxiliary/scanner/sap/sap_soap_rfc_brute_login.rb on lines 103..127
modules/auxiliary/scanner/sap/sap_web_gui_brute_login.rb on lines 107..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

  def report_cred(opts)
    service_data = {
      address: opts[:ip],
      port: opts[:port],
      service_name: opts[:service_name],
Severity: Major
Found in modules/auxiliary/scanner/http/dell_idrac.rb and 2 other locations - About 1 hr to fix
modules/auxiliary/scanner/http/apache_nifi_login.rb on lines 48..72
modules/exploits/windows/misc/unified_remote_rce.rb on lines 460..484

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

  def report_cred(opts)
    service_data = {
      address: opts[:ip],
      port: opts[:port],
      service_name: opts[:service_name],
Severity: Major
Found in modules/auxiliary/scanner/http/apache_nifi_login.rb and 2 other locations - About 1 hr to fix
modules/auxiliary/scanner/http/dell_idrac.rb on lines 156..180
modules/exploits/windows/misc/unified_remote_rce.rb on lines 460..484

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

      address: opts[:ip],
      port: opts[:port],
      service_name: opts[:service_name],
      protocol: 'tcp',
      workspace_id: myworkspace_id
Severity: Major
Found in modules/exploits/windows/misc/unified_remote_rce.rb and 2 other locations - About 1 hr to fix
modules/auxiliary/scanner/http/apache_nifi_login.rb on lines 48..72
modules/auxiliary/scanner/http/dell_idrac.rb on lines 156..180

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    if pids.include? 0x80
      packets = get_current_data(bus, src_id, dst_id, 0x80, opt)
      if (packets.key? "Packets") && !packets["Packets"].empty?
        hexpids = packets["Packets"][0]["DATA"][3, 6]
        hexpids = hexpids.join.hex.to_s(2).rjust(32, '0').split('') # Array of 1s and 0s
Severity: Major
Found in lib/msf/core/post/hardware/automotive/uds.rb and 5 other locations - About 1 hr to fix
lib/msf/core/post/hardware/automotive/uds.rb on lines 118..126
lib/msf/core/post/hardware/automotive/uds.rb on lines 128..136
lib/msf/core/post/hardware/automotive/uds.rb on lines 138..146
lib/msf/core/post/hardware/automotive/uds.rb on lines 158..166
lib/msf/core/post/hardware/automotive/uds.rb on lines 168..176

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    if pids.include? 0xA0
      packets = get_current_data(bus, src_id, dst_id, 0xA0, opt)
      if (packets.key? "Packets") && !packets["Packets"].empty?
        hexpids = packets["Packets"][0]["DATA"][3, 6]
        hexpids = hexpids.join.hex.to_s(2).rjust(32, '0').split('') # Array of 1s and 0s
Severity: Major
Found in lib/msf/core/post/hardware/automotive/uds.rb and 5 other locations - About 1 hr to fix
lib/msf/core/post/hardware/automotive/uds.rb on lines 118..126
lib/msf/core/post/hardware/automotive/uds.rb on lines 128..136
lib/msf/core/post/hardware/automotive/uds.rb on lines 138..146
lib/msf/core/post/hardware/automotive/uds.rb on lines 148..156
lib/msf/core/post/hardware/automotive/uds.rb on lines 168..176

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    if pids.include? 0x60
      packets = get_current_data(bus, src_id, dst_id, 0x60, opt)
      if (packets.key? "Packets") && !packets["Packets"].empty?
        hexpids = packets["Packets"][0]["DATA"][3, 6]
        hexpids = hexpids.join.hex.to_s(2).rjust(32, '0').split('') # Array of 1s and 0s
Severity: Major
Found in lib/msf/core/post/hardware/automotive/uds.rb and 5 other locations - About 1 hr to fix
lib/msf/core/post/hardware/automotive/uds.rb on lines 118..126
lib/msf/core/post/hardware/automotive/uds.rb on lines 128..136
lib/msf/core/post/hardware/automotive/uds.rb on lines 148..156
lib/msf/core/post/hardware/automotive/uds.rb on lines 158..166
lib/msf/core/post/hardware/automotive/uds.rb on lines 168..176

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    if pids.include? 0x20
      packets = get_current_data(bus, src_id, dst_id, 0x20, opt)
      if (packets.key? "Packets") && !packets["Packets"].empty?
        hexpids = packets["Packets"][0]["DATA"][3, 6]
        hexpids = hexpids.join.hex.to_s(2).rjust(32, '0').split('') # Array of 1s and 0s
Severity: Major
Found in lib/msf/core/post/hardware/automotive/uds.rb and 5 other locations - About 1 hr to fix
lib/msf/core/post/hardware/automotive/uds.rb on lines 128..136
lib/msf/core/post/hardware/automotive/uds.rb on lines 138..146
lib/msf/core/post/hardware/automotive/uds.rb on lines 148..156
lib/msf/core/post/hardware/automotive/uds.rb on lines 158..166
lib/msf/core/post/hardware/automotive/uds.rb on lines 168..176

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language