Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star

Showing 7,230 of 21,757 total issues

File constants.rb has 1171 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module Rex
module Proto
module SMB
class Constants
Severity: Major
Found in lib/rex/proto/smb/constants.rb - About 3 days to fix

    Method run has 602 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run
    return if not check_dependencies

    begin
      # Get all values from v$parameter
    Severity: Major
    Found in modules/auxiliary/admin/oracle/oraenum.rb - About 3 days to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        def make_pdf(ttf, js)

    #swf_name = rand_text_alpha(8 + rand(8)) + ".swf"

    xref = []
      Severity: Major
      Found in modules/exploits/windows/browser/adobe_cooltype_sing.rb and 1 other location - About 2 days to fix
      modules/exploits/windows/fileformat/adobe_cooltype_sing.rb on lines 375..560

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 716.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        def make_pdf(ttf, js)

    #swf_name = rand_text_alpha(8 + rand(8)) + ".swf"

    xref = []
      Severity: Major
      Found in modules/exploits/windows/fileformat/adobe_cooltype_sing.rb and 1 other location - About 2 days to fix
      modules/exploits/windows/browser/adobe_cooltype_sing.rb on lines 388..573

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 716.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      File rdp.rb has 1073 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      module Msf

###
#
# This module exposes methods for interacting with a remote RDP service
      Severity: Major
      Found in lib/msf/core/exploit/remote/rdp.rb - About 2 days to fix

        Method cmd_wmap_run has 541 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def cmd_wmap_run(*args)
        # Stop everything
        self.masstop = false
        self.killwhenstop = true
        Severity: Major
        Found in plugins/wmap.rb - About 2 days to fix

          File windows_secrets_dump.rb has 1041 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          require 'ruby_smb/dcerpc/client'

class MetasploitModule < Msf::Auxiliary
  include Msf::Exploit::Remote::SMB::Client::Authenticated
  include Msf::Exploit::Remote::DCERPC
          Severity: Major
          Found in modules/auxiliary/gather/windows_secrets_dump.rb - About 2 days to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              @@target_uuids = [
    [ '00000131-0000-0000-c000-000000000046', '0.0' ],
    [ '00000134-0000-0000-c000-000000000046', '0.0' ],
    [ '00000136-0000-0000-c000-000000000046', '0.0' ],
    [ '00000143-0000-0000-c000-000000000046', '0.0' ],
            Severity: Major
            Found in modules/auxiliary/scanner/smb/pipe_dcerpc_auditor.rb and 1 other location - About 2 days to fix
            modules/auxiliary/scanner/dcerpc/tcp_dcerpc_auditor.rb on lines 30..248

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 647.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              @@target_uuids = [
    [ '00000131-0000-0000-c000-000000000046', '0.0' ],
    [ '00000134-0000-0000-c000-000000000046', '0.0' ],
    [ '00000136-0000-0000-c000-000000000046', '0.0' ],
    [ '00000143-0000-0000-c000-000000000046', '0.0' ],
            Severity: Major
            Found in modules/auxiliary/scanner/dcerpc/tcp_dcerpc_auditor.rb and 1 other location - About 2 days to fix
            modules/auxiliary/scanner/smb/pipe_dcerpc_auditor.rb on lines 34..252

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 647.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            File rpc_db.rb has 1013 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            module Msf
module RPC
class RPC_Db < RPC_Base

private
            Severity: Major
            Found in lib/msf/core/rpc/v10/rpc_db.rb - About 2 days to fix

              File sys.rb has 1012 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              require 'rex/post/meterpreter'
require 'rex/post/meterpreter/extensions/stdapi/command_ids'

module Rex
module Post
              Severity: Major
              Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/sys.rb - About 2 days to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                  def t3_send(payload_obj)
    print_status('Sending object...')

    request_obj = '000009f3' # Original packet length
    request_obj << '016501' # CMD_IDENTIFY_REQUEST, flags
                Severity: Major
                Found in modules/exploits/multi/misc/weblogic_deserialize_badattrval.rb and 1 other location - About 2 days to fix
                modules/exploits/multi/misc/weblogic_deserialize_badattr_extcomp.rb on lines 370..578

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 620.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                  def t3_send(payload_obj)
    print_status('Sending object...')

    request_obj = '000009f3' # Original packet length
    request_obj << '016501' # CMD_IDENTIFY_REQUEST, flags
                Severity: Major
                Found in modules/exploits/multi/misc/weblogic_deserialize_badattr_extcomp.rb and 1 other location - About 2 days to fix
                modules/exploits/multi/misc/weblogic_deserialize_badattrval.rb on lines 566..774

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 620.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Method create_library has 501 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  def self.create_library(constant_manager, library_path = 'ws2_32')
    dll = Library.new(library_path, constant_manager)

    dll.add_function('getaddrinfo', 'DWORD',[
      ["PCHAR","pNodeName","in"],
                Severity: Major
                Found in lib/rex/post/meterpreter/extensions/stdapi/railgun/def/windows/def_ws2_32.rb - About 2 days to fix

                  File error.rb has 970 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  class RbMysql
  class Error < StandardError
    ERRNO = 0

    def self.define_error_class(prefix_re)
                  Severity: Major
                  Found in lib/rbmysql/error.rb - About 2 days to fix

                    File navigation.rb has 955 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    def without_prefix(prefix)
  proc { |value| value.sub(/^#{prefix}/, '') }
end

=begin
                    Severity: Major
                    Found in docs/navigation.rb - About 2 days to fix

                      File webkit_createthis.rb has 934 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      class MetasploitModule < Msf::Exploit::Remote
  Rank = ManualRanking

  include Msf::Post::File
  include Msf::Exploit::EXE
                      Severity: Major
                      Found in modules/exploits/apple_ios/browser/webkit_createthis.rb - About 2 days to fix

                        Method asm_reverse_winhttp has 458 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          def asm_reverse_winhttp(opts={})

    retry_count       = [opts[:retry_count].to_i, 1].max
    verify_ssl        = nil
    encoded_cert_hash = nil
                        Severity: Major
                        Found in lib/msf/core/payload/windows/reverse_win_http.rb - About 2 days to fix

                          Method asm_reverse_winhttp has 456 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                            def asm_reverse_winhttp(opts={})

    retry_count       = [opts[:retry_count].to_i, 1].max
    verify_ssl        = nil
    encoded_cert_hash = nil
                          Severity: Major
                          Found in lib/msf/core/payload/windows/x64/reverse_win_http_x64.rb - About 2 days to fix

                            Method description has 442 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                              def self.description(code)

    case code
    when SUCCESS
      "The operation completed successfully."
                            Severity: Major
                            Found in lib/msf/windows_error.rb - About 2 days to fix
                              Severity
                              Category
                              Status
                              Source
                              Language