Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star

Showing 7,361 of 22,177 total issues

Identical blocks of code found in 4 locations. Consider refactoring.
Open

    def truncated_query(query)
      result = [ ]
      offset = 1
      loop do
        slice = run_sql(query.sub(/\^OFFSET\^/, offset.to_s))
Severity: Major
Found in lib/msf/core/exploit/sqli/sqlitei/common.rb and 3 other locations - About 1 hr to fix
lib/msf/core/exploit/sqli/mssqli/common.rb on lines 224..235
lib/msf/core/exploit/sqli/mysqli/common.rb on lines 234..245
lib/msf/core/exploit/sqli/postgresqli/common.rb on lines 232..243

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

    def truncated_query(query)
      result = [ ]
      offset = 1
      loop do
        slice = run_sql(query.sub(/\^OFFSET\^/, offset.to_s))
Severity: Major
Found in lib/msf/core/exploit/sqli/mssqli/common.rb and 3 other locations - About 1 hr to fix
lib/msf/core/exploit/sqli/mysqli/common.rb on lines 234..245
lib/msf/core/exploit/sqli/postgresqli/common.rb on lines 232..243
lib/msf/core/exploit/sqli/sqlitei/common.rb on lines 161..172

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

    def truncated_query(query)
      result = [ ]
      offset = 1
      loop do
        slice = run_sql(query.sub(/\^OFFSET\^/, offset.to_s))
Severity: Major
Found in lib/msf/core/exploit/sqli/mysqli/common.rb and 3 other locations - About 1 hr to fix
lib/msf/core/exploit/sqli/mssqli/common.rb on lines 224..235
lib/msf/core/exploit/sqli/postgresqli/common.rb on lines 232..243
lib/msf/core/exploit/sqli/sqlitei/common.rb on lines 161..172

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

    def truncated_query(query)
      result = [ ]
      offset = 1
      loop do
        slice = run_sql(query.sub(/\^OFFSET\^/, offset.to_s))
Severity: Major
Found in lib/msf/core/exploit/sqli/postgresqli/common.rb and 3 other locations - About 1 hr to fix
lib/msf/core/exploit/sqli/mssqli/common.rb on lines 224..235
lib/msf/core/exploit/sqli/mysqli/common.rb on lines 234..245
lib/msf/core/exploit/sqli/sqlitei/common.rb on lines 161..172

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    begin
      # LsarLookupSids
      dcerpc.call(0x0f, stub)
    rescue Rex::Proto::DCERPC::Exceptions::NoResponse, Rex::Proto::SMB::Exceptions::NoReply, ::EOFError
      print_status('Server did not respond, this is expected')
Severity: Major
Found in modules/exploits/solaris/samba/lsa_transnames_heap.rb and 2 other locations - About 1 hr to fix
modules/exploits/linux/samba/lsa_transnames_heap.rb on lines 303..316
modules/exploits/osx/samba/lsa_transnames_heap.rb on lines 293..306

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    begin
      # LsarLookupSids
      dcerpc.call(0x0f, stub)
    rescue Rex::Proto::DCERPC::Exceptions::NoResponse, Rex::Proto::SMB::Exceptions::NoReply, ::EOFError
      print_status('Server did not respond, this is expected')
Severity: Major
Found in modules/exploits/osx/samba/lsa_transnames_heap.rb and 2 other locations - About 1 hr to fix
modules/exploits/linux/samba/lsa_transnames_heap.rb on lines 303..316
modules/exploits/solaris/samba/lsa_transnames_heap.rb on lines 168..181

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    begin
      # LsarLookupSids
      dcerpc.call(0x0f, stub)
    rescue Rex::Proto::DCERPC::Exceptions::NoResponse, Rex::Proto::SMB::Exceptions::NoReply, ::EOFError
      print_status('Server did not respond, this is expected')
Severity: Major
Found in modules/exploits/linux/samba/lsa_transnames_heap.rb and 2 other locations - About 1 hr to fix
modules/exploits/osx/samba/lsa_transnames_heap.rb on lines 293..306
modules/exploits/solaris/samba/lsa_transnames_heap.rb on lines 168..181

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  def initialize(info = {})
    super(merge_info(info,
     'Name'        => 'Unix Command Shell, Bind TCP (via R)',
     'Description' => 'Continually listen for a connection and spawn a command shell via R',
     'Author'      => [ 'RageLtMan <rageltman[at]sempervictus>' ],
Severity: Major
Found in modules/payloads/singles/cmd/unix/bind_r.rb and 6 other locations - About 1 hr to fix
modules/payloads/singles/cmd/unix/bind_lua.rb on lines 14..38
modules/payloads/singles/cmd/unix/reverse_lua.rb on lines 14..38
modules/payloads/singles/cmd/unix/reverse_r.rb on lines 15..32
modules/payloads/singles/cmd/unix/reverse_tclsh.rb on lines 12..35
modules/payloads/singles/cmd/windows/bind_lua.rb on lines 14..38
modules/payloads/singles/cmd/windows/reverse_lua.rb on lines 14..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  def on_request_uri(cli, request)
    case request.method
    when 'OPTIONS'
      process_options(cli, request)
    when 'PROPFIND'
Severity: Major
Found in modules/exploits/windows/misc/wireshark_lua.rb and 6 other locations - About 1 hr to fix
modules/exploits/windows/browser/webdav_dll_hijacker.rb on lines 64..78
modules/exploits/windows/fileformat/mcafee_showreport_exec.rb on lines 67..80
modules/exploits/windows/http/cogent_datahub_command.rb on lines 64..77
modules/exploits/windows/http/sap_host_control_cmd_exec.rb on lines 61..74
modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb on lines 59..72
modules/exploits/windows/scada/ge_proficy_cimplicity_gefebt.rb on lines 58..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  def initialize(info = {})
    super(merge_info(info,
     'Name'          => 'Unix Command Shell, Reverse TCP (via Lua)',
     'Description'   => 'Creates an interactive shell via Lua',
     'Author'        =>
Severity: Major
Found in modules/payloads/singles/cmd/unix/reverse_lua.rb and 6 other locations - About 1 hr to fix
modules/payloads/singles/cmd/unix/bind_lua.rb on lines 14..38
modules/payloads/singles/cmd/unix/bind_r.rb on lines 15..32
modules/payloads/singles/cmd/unix/reverse_r.rb on lines 15..32
modules/payloads/singles/cmd/unix/reverse_tclsh.rb on lines 12..35
modules/payloads/singles/cmd/windows/bind_lua.rb on lines 14..38
modules/payloads/singles/cmd/windows/reverse_lua.rb on lines 14..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  def initialize(info = {})
    super(merge_info(info,
     'Name'          => 'Unix Command Shell, Bind TCP (via Lua)',
     'Description'   => 'Listen for a connection and spawn a command shell via Lua',
     'Author'        =>
Severity: Major
Found in modules/payloads/singles/cmd/unix/bind_lua.rb and 6 other locations - About 1 hr to fix
modules/payloads/singles/cmd/unix/bind_r.rb on lines 15..32
modules/payloads/singles/cmd/unix/reverse_lua.rb on lines 14..38
modules/payloads/singles/cmd/unix/reverse_r.rb on lines 15..32
modules/payloads/singles/cmd/unix/reverse_tclsh.rb on lines 12..35
modules/payloads/singles/cmd/windows/bind_lua.rb on lines 14..38
modules/payloads/singles/cmd/windows/reverse_lua.rb on lines 14..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  def on_request_uri(cli, request)
    case request.method
    when 'OPTIONS'
      process_options(cli, request)
    when 'PROPFIND'
Severity: Major
Found in modules/exploits/windows/fileformat/mcafee_showreport_exec.rb and 6 other locations - About 1 hr to fix
modules/exploits/windows/browser/webdav_dll_hijacker.rb on lines 64..78
modules/exploits/windows/http/cogent_datahub_command.rb on lines 64..77
modules/exploits/windows/http/sap_host_control_cmd_exec.rb on lines 61..74
modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb on lines 59..72
modules/exploits/windows/misc/wireshark_lua.rb on lines 62..75
modules/exploits/windows/scada/ge_proficy_cimplicity_gefebt.rb on lines 58..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  def on_request_uri(cli, request)

    case request.method
    when 'OPTIONS'
      process_options(cli, request)
Severity: Major
Found in modules/exploits/windows/browser/webdav_dll_hijacker.rb and 6 other locations - About 1 hr to fix
modules/exploits/windows/fileformat/mcafee_showreport_exec.rb on lines 67..80
modules/exploits/windows/http/cogent_datahub_command.rb on lines 64..77
modules/exploits/windows/http/sap_host_control_cmd_exec.rb on lines 61..74
modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb on lines 59..72
modules/exploits/windows/misc/wireshark_lua.rb on lines 62..75
modules/exploits/windows/scada/ge_proficy_cimplicity_gefebt.rb on lines 58..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  def initialize(info = {})
    super(merge_info(info,
     'Name'          => 'Windows Command Shell, Bind TCP (via Lua)',
     'Description'   => 'Listen for a connection and spawn a command shell via Lua',
     'Author'        =>
Severity: Major
Found in modules/payloads/singles/cmd/windows/bind_lua.rb and 6 other locations - About 1 hr to fix
modules/payloads/singles/cmd/unix/bind_lua.rb on lines 14..38
modules/payloads/singles/cmd/unix/bind_r.rb on lines 15..32
modules/payloads/singles/cmd/unix/reverse_lua.rb on lines 14..38
modules/payloads/singles/cmd/unix/reverse_r.rb on lines 15..32
modules/payloads/singles/cmd/unix/reverse_tclsh.rb on lines 12..35
modules/payloads/singles/cmd/windows/reverse_lua.rb on lines 14..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  def on_request_uri(cli, request)
    case request.method
      when 'OPTIONS'
        process_options(cli, request)
      when 'PROPFIND'
Severity: Major
Found in modules/exploits/windows/http/sap_host_control_cmd_exec.rb and 6 other locations - About 1 hr to fix
modules/exploits/windows/browser/webdav_dll_hijacker.rb on lines 64..78
modules/exploits/windows/fileformat/mcafee_showreport_exec.rb on lines 67..80
modules/exploits/windows/http/cogent_datahub_command.rb on lines 64..77
modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb on lines 59..72
modules/exploits/windows/misc/wireshark_lua.rb on lines 62..75
modules/exploits/windows/scada/ge_proficy_cimplicity_gefebt.rb on lines 58..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  def on_request_uri(cli, request)
    case request.method
    when 'OPTIONS'
      process_options(cli, request)
    when 'PROPFIND'
Severity: Major
Found in modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb and 6 other locations - About 1 hr to fix
modules/exploits/windows/browser/webdav_dll_hijacker.rb on lines 64..78
modules/exploits/windows/fileformat/mcafee_showreport_exec.rb on lines 67..80
modules/exploits/windows/http/cogent_datahub_command.rb on lines 64..77
modules/exploits/windows/http/sap_host_control_cmd_exec.rb on lines 61..74
modules/exploits/windows/misc/wireshark_lua.rb on lines 62..75
modules/exploits/windows/scada/ge_proficy_cimplicity_gefebt.rb on lines 58..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  def on_request_uri(cli, request)
    case request.method
      when 'OPTIONS'
        process_options(cli, request)
      when 'PROPFIND'
Severity: Major
Found in modules/exploits/windows/scada/ge_proficy_cimplicity_gefebt.rb and 6 other locations - About 1 hr to fix
modules/exploits/windows/browser/webdav_dll_hijacker.rb on lines 64..78
modules/exploits/windows/fileformat/mcafee_showreport_exec.rb on lines 67..80
modules/exploits/windows/http/cogent_datahub_command.rb on lines 64..77
modules/exploits/windows/http/sap_host_control_cmd_exec.rb on lines 61..74
modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb on lines 59..72
modules/exploits/windows/misc/wireshark_lua.rb on lines 62..75

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  def on_request_uri(cli, request)
    case request.method
      when 'OPTIONS'
        process_options(cli, request)
      when 'PROPFIND'
Severity: Major
Found in modules/exploits/windows/http/cogent_datahub_command.rb and 6 other locations - About 1 hr to fix
modules/exploits/windows/browser/webdav_dll_hijacker.rb on lines 64..78
modules/exploits/windows/fileformat/mcafee_showreport_exec.rb on lines 67..80
modules/exploits/windows/http/sap_host_control_cmd_exec.rb on lines 61..74
modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb on lines 59..72
modules/exploits/windows/misc/wireshark_lua.rb on lines 62..75
modules/exploits/windows/scada/ge_proficy_cimplicity_gefebt.rb on lines 58..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  def initialize(info = {})
    super(merge_info(info,
     'Name'        => 'Unix Command Shell, Reverse TCP (via R)',
     'Description' => 'Connect back and create a command shell via R',
     'Author'      => [ 'RageLtMan <rageltman[at]sempervictus>' ],
Severity: Major
Found in modules/payloads/singles/cmd/unix/reverse_r.rb and 6 other locations - About 1 hr to fix
modules/payloads/singles/cmd/unix/bind_lua.rb on lines 14..38
modules/payloads/singles/cmd/unix/bind_r.rb on lines 15..32
modules/payloads/singles/cmd/unix/reverse_lua.rb on lines 14..38
modules/payloads/singles/cmd/unix/reverse_tclsh.rb on lines 12..35
modules/payloads/singles/cmd/windows/bind_lua.rb on lines 14..38
modules/payloads/singles/cmd/windows/reverse_lua.rb on lines 14..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  def initialize(info = {})
    super(
      merge_info(
        info,
        'Name' => 'Unix Command Shell, Reverse TCP (via Tclsh)',
Severity: Major
Found in modules/payloads/singles/cmd/unix/reverse_tclsh.rb and 6 other locations - About 1 hr to fix
modules/payloads/singles/cmd/unix/bind_lua.rb on lines 14..38
modules/payloads/singles/cmd/unix/bind_r.rb on lines 15..32
modules/payloads/singles/cmd/unix/reverse_lua.rb on lines 14..38
modules/payloads/singles/cmd/unix/reverse_r.rb on lines 15..32
modules/payloads/singles/cmd/windows/bind_lua.rb on lines 14..38
modules/payloads/singles/cmd/windows/reverse_lua.rb on lines 14..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language