rapid7/metasploit-framework

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  list = ['123456','password','12345678','qwerty','abc123','111111','letmein','trustno1','superman',
    'iloveyou','sunshine','1234','princess','starwars','princess','nintendo','computer','Password',
    'passw0rd','michael','football','whatever','shadow','pokemon','666666','forgetyou','blahblah',
    'cowboys','yankees','ravens','orioles','pirates','dabears','tiger','fairies','sushi','money',
    'killzone','sandbox','rotflmao','subway','knicks','lakers','chargers','kermit','pigskin','baseball']

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    super(update_info(info,
      'Name'           => 'rc.local Persistence',
      'Description'    => %q(
        This module will edit /etc/rc.local in order to persist a payload.
        The payload will be executed on the next reboot.

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      users.keys.sort { |a, b| a <=> b }.each do |rid|
        # If we have a hint then print it
        if !users[rid][:UserPasswordHint].nil? && !users[rid][:UserPasswordHint].empty?
          print_good("\t#{users[rid][:Name]}:\"#{users[rid][:UserPasswordHint]}\"")
          hint_count += 1

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  def check
    get_terramaster_info
    return CheckCode::Safe if @terramaster.empty?

    if Rex::Version.new(@terramaster['tos_version']) <= Rex::Version.new('4.2.29')

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    privs_enable.each do |priv|
      items.each do |item|
       request_parameters = {
        'method'    => 'POST',
        'uri'       => normalize_uri(@uri.path, "/command/#{targetdb}/sql/-/20"),

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'D-Link DIR-600 / DIR-300 Unauthenticated Remote Command Execution',

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    while (Time.now.to_f < etime)
      while(reply = getreply())
        next if not reply.is_arp?
        if @dhosts.include? reply.arp_saddr_ip
          print_good("#{reply.arp_saddr_ip} appears to be up.")

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

module Rex
  module Post
    module LDAP
      module Ui
        ###

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    super(update_info(info,
      'Name'           => 'Autostart Desktop Item Persistence',
      'Description'    => %q(
        This module will create an autostart entry to execute a payload.
        The payload will be executed when the users logs in.

• Read up
  Read up

Function check_logins has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

def check_logins(rhost, rport, targeturi, domain, usernames, passwords, timeout, user_agent):

Function __init__ has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

    def __init__(self, command='', username='', password='', domain='', hashes=None, share=None,

Function check_login has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

def check_login(rhost, rport, targeturi, domain, username, password, timeout, user_agent):

Function _encdec has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

    def _encdec(self, data, K, s, S, L1, L2, L3, L4):

Consider simplifying this complex logical expression.

Open

                    if ((node.is_leaf? && !strpath.include?('.')) || node.is_root? || !node.is_leaf?) && (!usinginipath || (usinginipath && strpath.match(inipathname)))

                      modopts['PATH'] = strpath
                      print_status("Path: #{strpath}")

Method scheduleremote has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

def scheduleremote(session,schtype,cmd,tmmod,cmdopt,targetsys,username,password)

Consider simplifying this complex logical expression.

Open

    return CheckCode::Safe("Detected Magento #{edition} edition version #{version} which is not vulnerable") unless
      version <= (Rex::Version.new('2.4.7')) ||
      version <= (Rex::Version.new('2.4.6-p5')) ||
      version <= (Rex::Version.new('2.4.5-p7')) ||
      version <= (Rex::Version.new('2.4.4-p8')) ||

Consider simplifying this complex logical expression.

Open

    if res && res.code == 200 && res.body &&
       res.body.to_s =~ /ManageEngine Password Manager Pro/ &&
       (
         res.body.to_s =~ /login\.css\?([0-9]+)/ ||                            # PMP v6
         res.body.to_s =~ /login\.css\?version=([0-9]+)/ ||                    # PMP v6

Consider simplifying this complex logical expression.

Open

    if xmlResponse.include?('NET5501') || xmlResponse.include?('NET5501-I') || xmlResponse.include?('NET5501-XT') || xmlResponse.include?('NET5504') || xmlResponse.include?('NET5500') || xmlResponse.include?('NET5516') || xmlResponse.include?('NET5508')
      return Exploit::CheckCode::Appears
    end

Consider simplifying this complex logical expression.

Open

      if (version[0].to_i < 11) or
      (version[0].to_i == 11 and version[1].to_i <= 3) or
      (version[0].to_i == 11 and version[1].to_i == 3 and version[2].to_i == 0 and version[3].to_i < 999)
        ctx = { 'Msf' => framework, 'MsfExploit' => self }
        sock = Rex::Socket.create_tcp({ 'PeerHost' => rhost, 'PeerPort' => datastore['RPORT_REMOTING'], 'Context' => ctx })

Consider simplifying this complex logical expression.

Open

          elsif (error[0].empty? or (error[0].unpack('C')[0] & 3) == 0) and # fd_nextsize
                (error[1].empty? or (error[1].unpack('C')[0] & 3) == 0) and # fd
                (error[2] =~ /\A503 [^s].?\z/mn) and ((error[2].unpack('C*')[4] & 7) == PREV_INUSE) and # size
                (error[3] == "177") # the last \x7F of our BAD1 command, encoded as \\177 by string_printing()
            leaked_arch = ARCH_X86