rapid7/metasploit-framework

View on GitHub

Showing 7,361 of 22,177 total issues

Avoid deeply nested control flow statements.
Open

              if result["Packets"][0]["DATA"][0] == "10"
                system("cansend #{bus} #{srcid}#3000000000000000")
                candump(bus, dstid, timeout, maxpkts)
                @packets_sent += 1
                @last_sent = Time.now.to_i
Severity: Major
Found in modules/auxiliary/server/local_hwbridge.rb - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                if datastore['INLINE']
                  print_warning('This might be expected or you can still try again with the `INLINE` option set to false')
                end
    Severity: Major
    Found in modules/auxiliary/gather/windows_secrets_dump.rb - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                  if ['ALL', 'CACHE'].include?(action.name)
                    nlkm_key = get_nlkm_secret_key(windows_reg, lsa_key)
                    if nlkm_key.nil? || nlkm_key.empty?
                      print_warning('No NLKM key (skip cached hashes dump)')
                      if datastore['INLINE']
      Severity: Major
      Found in modules/auxiliary/gather/windows_secrets_dump.rb - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                  unless report_creds(print_name, key_data, **credential_opts)
                    vprint_bad("Error when reporting #{print_name} machine kerberos key #{krb_enc_key_to_s(key)}")
                  end
        Severity: Major
        Found in modules/auxiliary/gather/windows_secrets_dump.rb - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                      if ['ALL', 'LSA'].include?(action.name)
                        dump_lsa_secrets(windows_reg, lsa_key)
                      end
          Severity: Major
          Found in modules/auxiliary/gather/windows_secrets_dump.rb - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                          if (getsin_observation[index][x] != getsin_observation[next_index][x]) && (getsin_observation[index][x - 1] != getsin_observation[next_index][x - 1]) && ((getsin_observation[(index - 1) % 4][x - 1] == getsin_observation[index][x - 1]) || (getsin_observation[next_index][x - 1] == getsin_observation[(next_index + 1) % 4][x - 1]))
                            target_offset_range.delete(x)
                            inference_results[x] = xor_strings(getsin_observation[index][x], '9')
                            break
                          end
            Severity: Major
            Found in modules/auxiliary/gather/darkcomet_filedownloader.rb - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                        save_note(datastore['HOSTNAME'], ip, port, proto, false) if datastore['REPORT_LEAKS']
              Severity: Major
              Found in modules/auxiliary/gather/cloud_lookup.rb - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                if (liste_dst_ips.include? pkt.arp_saddr_ip and liste_src_ips.include? pkt.arp_daddr_ip) or
                                  (args[:BIDIRECTIONAL] and liste_dst_ips.include? pkt.arp_daddr_ip and liste_src_ips.include? pkt.arp_saddr_ip)
                                  vprint_status("Listener : Request from #{pkt.arp_saddr_ip} for #{pkt.arp_daddr_ip}")
                                  reply = buildreply(pkt.arp_daddr_ip, @smac, pkt.arp_saddr_ip, pkt.eth_saddr)
                                  3.times{listener_capture.inject(reply.to_s)}
                Severity: Major
                Found in modules/auxiliary/spoof/arp/arp_poisoning.rb - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                              if ending[i] == base[pos]
                                isthere = true
                                partnum += pos.to_s
                                if pos == 0
                                  if !startnum
                  Severity: Major
                  Found in modules/auxiliary/admin/http/webnms_cred_disclosure.rb - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                if pos == 0
                                  if !startnum
                                    answer += '0'
                                  end
                                else
                    Severity: Major
                    Found in modules/auxiliary/admin/http/webnms_cred_disclosure.rb - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                    if not origin.nil?
                                      print_good(/\w+\@[\w+\.]+/.match(origin.to_s).to_s)
                                    else
                                      print_status("Ringing message received but no user/gateway sent...")
                                    end
                      Severity: Major
                      Found in modules/auxiliary/scanner/sip/sipdroid_ext_enum.rb - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                    if sock.recv(150)  =~ /access denied/
                                      print_error("#{host_port} - Access denied")
                                      sock.recv(packet_len)
                                      packet_len = sock.recv(4).unpack('H*')[0].to_i 16
                                    else
                        Severity: Major
                        Found in modules/auxiliary/scanner/sap/sap_router_info_request.rb - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                return if trigger.nil?
                          Severity: Major
                          Found in modules/auxiliary/scanner/http/http_traversal.rb - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                              if alive.nil?
                                                print_good("[#{rhost}] #{target} is alive.")
                                                alive = true
                                              end
                            Severity: Major
                            Found in modules/auxiliary/scanner/http/squid_pivot_scanning.rb - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                              elsif res.body =~ /id="sysmsg".*No route to host/
                                                dead = true
                                                print_error("[#{rhost}] No route to #{target}")
                              Severity: Major
                              Found in modules/auxiliary/scanner/http/squid_pivot_scanning.rb - About 45 mins to fix

                                Avoid deeply nested control flow statements.
                                Open

                                                  :sname => (ssl ? 'https' : 'http'),
                                Severity: Major
                                Found in modules/auxiliary/scanner/http/web_vulndb.rb - About 45 mins to fix

                                  Avoid deeply nested control flow statements.
                                  Open

                                              ssid = ssid_input[0]['value'] if ssid_input.count == 1
                                  Severity: Major
                                  Found in modules/auxiliary/scanner/http/canon_wireless.rb - About 45 mins to fix

                                    Avoid deeply nested control flow statements.
                                    Open

                                                    service_name: (ssl ? 'https' : 'http'),
                                    Severity: Major
                                    Found in modules/auxiliary/scanner/http/wordpress_scanner.rb - About 45 mins to fix

                                      Avoid deeply nested control flow statements.
                                      Open

                                                      rescue ::Rex::ConnectionRefused, ::Rex::HostUnreachable, ::Rex::ConnectionTimeout
                                      Severity: Major
                                      Found in modules/auxiliary/scanner/http/svn_scanner.rb - About 45 mins to fix

                                        Avoid deeply nested control flow statements.
                                        Open

                                                  for c in @charset_names
                                                    @queue  <<(url +c)
                                                  end
                                        Severity: Major
                                        Found in modules/auxiliary/scanner/http/iis_shortname_scanner.rb - About 45 mins to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language