Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star

Showing 7,301 of 22,004 total issues

Similar blocks of code found in 11 locations. Consider refactoring.
Open

    if res and res.size > 0
      print_status("\tThe following users have SUPER Privilege:")
      res.each do |row|
        print_status("\t\tUser: #{row[0]} Host: #{row[1]}")
      end
Severity: Major
Found in modules/auxiliary/admin/mysql/mysql_enum.rb and 10 other locations - About 15 mins to fix
modules/auxiliary/admin/mysql/mysql_enum.rb on lines 156..161
modules/auxiliary/admin/mysql/mysql_enum.rb on lines 165..170
modules/auxiliary/admin/mysql/mysql_enum.rb on lines 173..178
modules/auxiliary/admin/mysql/mysql_enum.rb on lines 181..186
modules/auxiliary/admin/mysql/mysql_enum.rb on lines 197..202
modules/auxiliary/admin/mysql/mysql_enum.rb on lines 205..210
modules/auxiliary/admin/mysql/mysql_enum.rb on lines 220..225
modules/auxiliary/admin/mysql/mysql_enum.rb on lines 231..236
modules/auxiliary/admin/mysql/mysql_enum.rb on lines 241..246
modules/auxiliary/admin/mysql/mysql_enum.rb on lines 251..256

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language